Skip to content

Commit d34d8ce

Browse files
authored
Optimize get_revision.sh (#26)
1 parent 775f45f commit d34d8ce

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

Scripts/CI/get_revision.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ PACKAGE_RESOLVED_PATH="Package.resolved"
2323

2424
# Check if the Package.resolved file exists
2525
if [[ ! -f "$PACKAGE_RESOLVED_PATH" ]]; then
26-
echo "Error: $PACKAGE_RESOLVED_PATH file not found!"
26+
echo "Error: $PACKAGE_RESOLVED_PATH file not found!" >&2
2727
exit 1
2828
fi
2929

@@ -36,7 +36,7 @@ REVISION=$(jq -r --arg name "$DEPENDENCY_NAME" '
3636

3737
# Check if a revision was found
3838
if [[ -z "$REVISION" ]]; then
39-
echo "No revision found for dependency: $DEPENDENCY_NAME"
39+
echo "No revision found for dependency: $DEPENDENCY_NAME" >&2
4040
exit 1
4141
else
4242
echo "$REVISION"

Scripts/CI/rb_setup.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,11 @@ clone_checkout_rb() {
2121
git stash --quiet || true
2222
git reset --hard --quiet origin/main
2323
fi
24-
git checkout --quiet $revision
24+
if [ -n "$revision" ]; then
25+
git checkout --quiet "$revision"
26+
else
27+
echo "No pinned revision for DarwinPrivateFrameworks, using default branch."
28+
fi
2529
}
2630

2731
update_rb() {

0 commit comments

Comments
 (0)