Skip to content

Commit 8be680d

Browse files
authored
Merge pull request #59 from Sebastian-Maier/refactor/container-entrypoint
Rename docker-entrypoint to container-entrypoint
2 parents f7e9501 + 107aa80 commit 8be680d

26 files changed

Lines changed: 178 additions & 159 deletions

README.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -116,14 +116,15 @@ The following environment variables are supported:
116116

117117
## Initialization Scripts
118118

119-
If you would like to do additional initialization, add a directory called `/docker-custom-entrypoint.d/` and fill it with `.sh` scripts.
119+
If you would like to do additional initialization, add a directory called `/container-custom-entrypoint.d/` and fill it with `.sh` scripts.
120120

121-
You can also create sub-directories in `/docker-custom-entrypoint.d/` for scripts that have to run at different stages.
121+
You can also create sub-directories in `/container-custom-entrypoint.d/` for scripts that have to run at different stages.
122122

123-
- `/docker-custom-entrypoint.d/` - scripts that run after the default entrypoint scripts, but before the openvoxserver service is started.
124-
- `/docker-custom-entrypoint.d/post-startup/` - scripts that run after the openvoxserver service is started.
125-
- `/docker-custom-entrypoint.d/sigterm-handler/` - scripts that run when the container receives a SIGTERM signal.
126-
- `/docker-custom-entrypoint.d/post-execution/` - scripts that run after the openvoxserver service has stopped.
123+
- `/container-custom-entrypoint.d/pre-default/` - scripts that run before the default entrypoints scripts.
124+
- `/container-custom-entrypoint.d/` - scripts that run after the default entrypoint scripts, but before the openvoxserver service is started.
125+
- `/container-custom-entrypoint.d/post-startup/` - scripts that run after the openvoxserver service is started.
126+
- `/container-custom-entrypoint.d/sigterm-handler/` - scripts that run when the container receives a SIGTERM signal.
127+
- `/container-custom-entrypoint.d/post-execution/` - scripts that run after the openvoxserver service has stopped.
127128

128129
## Persistence
129130

openvoxserver/Containerfile

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,12 +70,13 @@ ENV AUTOSIGN=true \
7070
SSLDIR=/etc/puppetlabs/puppet/ssl \
7171
USE_OPENVOXDB=true
7272

73-
COPY docker-entrypoint.sh \
73+
COPY container-entrypoint.sh \
74+
docker-entrypoint.sh \
7475
healthcheck.sh \
7576
Containerfile \
7677
/
7778

78-
COPY docker-entrypoint.d /docker-entrypoint.d
79+
COPY container-entrypoint.d /container-entrypoint.d
7980
COPY --from=builder /var/lib/gems/ /var/lib/gems/
8081
COPY --from=builder /usr/local/bin/r10k /usr/local/bin/
8182

@@ -86,7 +87,7 @@ RUN apt-get update && \
8687

8788
RUN groupadd -g ${OPENVOX_USER_GID} puppet && \
8889
useradd -m -u ${OPENVOX_USER_UID} -g puppet puppet && \
89-
chmod +x /docker-entrypoint.sh /healthcheck.sh /docker-entrypoint.d/*.sh && \
90+
chmod +x /container-entrypoint.sh /docker-entrypoint.sh /healthcheck.sh /container-entrypoint.d/*.sh && \
9091
apt-get update && \
9192
apt-get upgrade -y && \
9293
apt-get install -y \
@@ -120,5 +121,5 @@ HEALTHCHECK --interval=20s --timeout=15s --retries=12 --start-period=3m CMD ["/h
120121
# NOTE: this is just documentation on defaults
121122
EXPOSE 8140
122123

123-
ENTRYPOINT ["dumb-init", "/docker-entrypoint.sh"]
124+
ENTRYPOINT ["dumb-init", "/container-entrypoint.sh"]
124125
CMD ["foreground"]

openvoxserver/Containerfile.alpine

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -164,14 +164,15 @@ COPY --from=build /etc/puppetlabs /etc/puppetlabs
164164
COPY --from=build /var/log/puppetlabs /var/log/puppetlabs
165165
COPY --from=build /var/run/puppetlabs /var/run/puppetlabs
166166

167-
COPY docker-entrypoint.sh \
167+
COPY container-entrypoint.sh \
168+
docker-entrypoint.sh \
168169
healthcheck.sh \
169170
Containerfile.alpine \
170171
/
171172

172173
COPY conf.d/product.conf /etc/puppetlabs/puppetserver/conf.d/
173174
COPY conf.d/puppetserver.conf /etc/puppetlabs/puppetserver/conf.d/
174-
COPY docker-entrypoint.d /docker-entrypoint.d
175+
COPY container-entrypoint.d /container-entrypoint.d
175176
COPY logback.xml /etc/puppetlabs/puppetserver/
176177
COPY puppetdb.conf /var/tmp/puppet/
177178
COPY puppetserver /etc/default/puppetserver
@@ -210,7 +211,7 @@ RUN apk update \
210211
&& chmod 700 ${data_dir}/puppetserver/yaml \
211212
&& find /etc/puppetlabs/puppet/ssl -type d -print0 | xargs -0 chmod 770 \
212213
&& echo 'alias ll="ls -la --color=auto"' >> ~/.bashrc \
213-
&& chmod +x /docker-entrypoint.sh /healthcheck.sh /docker-entrypoint.d/*.sh \
214+
&& chmod +x /container-entrypoint.sh /docker-entrypoint.sh /healthcheck.sh /container-entrypoint.d/*.sh \
214215
&& mkdir -p /opt/puppetlabs/puppet/bin \
215216
&& ln -s /usr/bin/puppet /opt/puppetlabs/puppet/bin/puppet \
216217
&& ln -s /usr/bin/facter /opt/puppetlabs/puppet/bin/facter \
@@ -228,5 +229,5 @@ HEALTHCHECK --interval=20s --timeout=15s --retries=12 --start-period=3m CMD ["/h
228229

229230
EXPOSE 8140
230231

231-
ENTRYPOINT ["dumb-init", "/docker-entrypoint.sh"]
232+
ENTRYPOINT ["dumb-init", "/container-entrypoint.sh"]
232233
CMD ["foreground"]

openvoxserver/docker-entrypoint.d/20-use-templates-initially.sh renamed to openvoxserver/container-entrypoint.d/20-use-templates-initially.sh

File renamed without changes.

openvoxserver/docker-entrypoint.d/30-set-permissions.sh renamed to openvoxserver/container-entrypoint.d/30-set-permissions.sh

File renamed without changes.

openvoxserver/docker-entrypoint.d/40-update-puppetdb-conf.sh renamed to openvoxserver/container-entrypoint.d/40-update-puppetdb-conf.sh

File renamed without changes.

openvoxserver/docker-entrypoint.d/50-set-certname.sh renamed to openvoxserver/container-entrypoint.d/50-set-certname.sh

File renamed without changes.

openvoxserver/docker-entrypoint.d/55-set-masterport.sh renamed to openvoxserver/container-entrypoint.d/55-set-masterport.sh

File renamed without changes.

openvoxserver/docker-entrypoint.d/56-set-environmentpath.sh renamed to openvoxserver/container-entrypoint.d/56-set-environmentpath.sh

File renamed without changes.

openvoxserver/docker-entrypoint.d/57-set-hiera_config.sh renamed to openvoxserver/container-entrypoint.d/57-set-hiera_config.sh

File renamed without changes.

0 commit comments

Comments
 (0)