parcels.convert breaks with AttributeError: module 'parcels' has no attribute 'convert'

[erikvansebille]

Parcels version

v4

Description

Our notebook renderings fail - both on RTD as well as locally. Surprisingly, our tests all pass. It has to do with parcels.convert

When running pixi run docs-clean, I now get

AttributeError: module 'parcels' has no attribute 'convert'

Adding a line import parcels.convert does make the rendering of notebooks work again

No idea why this has suddenly happened. I did a git bisect and that returned a8db856 (merging #2777) as the first breaking commit on main.

@VeckoTheGecko, could you take a look?

Code sample

import parcels
parcels.convert

Error

AttributeError: module 'parcels' has no attribute 'convert'

[j-atkins]

I wonder whether it does indeed have something to do with #2777 with the from parcels.convert... line removed from model.py (i.e. here).

Could this previously have been keeping the convert module 'alive' and in-memory via a chain of: parcels/__init__.py imports FieldSet from fieldset.py -> fieldset.py imports from parcels._core.model -> model.py imports from parcels.convert?

And now that from parcels.convert... is removed from model.py in #2777 means it's never brought in on start up?