Merge pull request #5707 from Particular/john/generic_settings

Replace TrialMetadata table with a generic Settings key/value table

Author: johnsimons

src/ServiceControl.Persistence.EFCore.PostgreSql/Migrations/20260807012019_AddSettings.Designer.cs

@@ -0,0 +1,56 @@
+using System;
+using Microsoft.EntityFrameworkCore.Migrations;
+using Npgsql.EntityFrameworkCore.PostgreSQL.Metadata;
+
+#nullable disable
+
+namespace ServiceControl.Persistence.EFCore.PostgreSql.Migrations
+{
+    /// <inheritdoc />
+    public partial class AddSettings : Migration
+    {
+        /// <inheritdoc />
+        protected override void Up(MigrationBuilder migrationBuilder)
+        {
+            migrationBuilder.DropTable(
+                name: "trial_metadata");
+
+            migrationBuilder.CreateTable(
+                name: "settings",
+                columns: table => new
+                {
+                    key = table.Column<string>(type: "character varying(450)", maxLength: 450, nullable: false),
+                    value = table.Column<string>(type: "text", nullable: false)
+                },
+                constraints: table =>
+                {
+                    table.PrimaryKey("pk_settings", x => x.key);
+                });
+        }
+
+        /// <inheritdoc />
+        protected override void Down(MigrationBuilder migrationBuilder)
+        {
+            migrationBuilder.DropTable(
+                name: "settings");
+
+            migrationBuilder.CreateTable(
+                name: "trial_metadata",
+                columns: table => new
+                {
+                    id = table.Column<int>(type: "integer", nullable: false)
+                        .Annotation("Npgsql:ValueGenerationStrategy", NpgsqlValueGenerationStrategy.IdentityByDefaultColumn),
+                    trial_end_date = table.Column<DateOnly>(type: "date", nullable: true)
+                },
+                constraints: table =>
+                {
+                    table.PrimaryKey("pk_trial_metadata", x => x.id);
+                });
+
+            migrationBuilder.InsertData(
+                table: "trial_metadata",
+                columns: new[] { "id", "trial_end_date" },
+                values: new object[] { 1, null });
+        }
+    }
+}

src/ServiceControl.Persistence.EFCore.PostgreSql/Migrations/20260807012019_AddSettings.cs

@@ -668,6 +668,24 @@ protected override void BuildModel(ModelBuilder modelBuilder)
                     b.ToTable("retry_batch_now_forwarding", (string)null);
                 });
 
+            modelBuilder.Entity("ServiceControl.Persistence.EFCore.Entities.SettingEntity", b =>
+                {
+                    b.Property<string>("Key")
+                        .HasMaxLength(450)
+                        .HasColumnType("character varying(450)")
+                        .HasColumnName("key");
+
+                    b.Property<string>("Value")
+                        .IsRequired()
+                        .HasColumnType("text")
+                        .HasColumnName("value");
+
+                    b.HasKey("Key")
+                        .HasName("pk_settings");
+
+                    b.ToTable("settings", (string)null);
+                });
+
             modelBuilder.Entity("ServiceControl.Persistence.EFCore.Entities.SubscriptionEntity", b =>
                 {
                     b.Property<string>("MessageType")
@@ -692,31 +710,6 @@ protected override void BuildModel(ModelBuilder modelBuilder)
                     b.ToTable("subscriptions", (string)null);
                 });
 
-            modelBuilder.Entity("ServiceControl.Persistence.EFCore.Entities.TrialMetadataEntity", b =>
-                {
-                    b.Property<int>("Id")
-                        .ValueGeneratedOnAdd()
-                        .HasColumnType("integer")
-                        .HasColumnName("id");
-
-                    NpgsqlPropertyBuilderExtensions.UseIdentityByDefaultColumn(b.Property<int>("Id"));
-
-                    b.Property<DateOnly?>("TrialEndDate")
-                        .HasColumnType("date")
-                        .HasColumnName("trial_end_date");
-
-                    b.HasKey("Id")
-                        .HasName("pk_trial_metadata");
-
-                    b.ToTable("trial_metadata", (string)null);
-
-                    b.HasData(
-                        new
-                        {
-                            Id = 1
-                        });
-                });
-
             modelBuilder.Entity("ServiceControl.Persistence.EFCore.Entities.UnacknowledgedRetryOperationEntity", b =>
                 {
                     b.Property<string>("RequestId")