Mixin into Controlling to fix debug options counting as keybind conflicts for non-debug options

[Wyvest]

jaredlll08/Controlling#237

[jaredlll08]

Hi yes controlling author here.

Please don't mixin into my mod.

I would happily add an event that is fired somewhere here https://github.com/jaredlll08/Controlling/blob/26.1.2/common/src/main/java/com/blamejared/controlling/client/NewKeyBindsList.java#L268 that can be used to override if a key conflicts or not.

I do not want to deal with issues from users if I change my code and someone else's mixin now fails.

[Wyvest]

Hi yes controlling author here.

Please don't mixin into my mod.

I would happily add an event that is fired somewhere here jaredlll08/Controlling@26.1.2/common/src/main/java/com/blamejared/controlling/client/NewKeyBindsList.java#L268 that can be used to override if a key conflicts or not.

I do not want to deal with issues from users if I change my code and someone else's mixin now fails.

Oh we were gonna make it require = 0 and expect = 0 like we do all other with all other mod mixins.

Can you guys fix that issue on your end then? Seems like an easier solution to all this

[jaredlll08]

like I said on the issue, there isn't a "fix" for the actual issue, but like I said here, I can add an event that is fired that can be used instead of a mixin.

I just need to know what MC versions you need this for.

[Wyvest]

like I said on the issue, there isn't a "fix" for the actual issue, but like I said here, I can add an event that is fired that can be used instead of a mixin.

I just need to know what MC versions you need this for.

check the issue for what I think could be the solution, but if we're going ahead with the event, we would need it in 1.21.1,.4,.5,.8,.10,.11, 26.1, and 26.2 (you can realistically ignore .5 if youre too lazy cause like 0.0001% of our users are on it)

[Wyvest]

like I said on the issue, there isn't a "fix" for the actual issue, but like I said here, I can add an event that is fired that can be used instead of a mixin.

I just need to know what MC versions you need this for.

Considering your recent message on the related Controlling issue, you should probably add this event in.

[Wyvest]

While you're here, it would be nice if Controlling made an event for modifying keybind labels (like the button that says the keybind) and an event for capturing the key record state (when you click the button with the keybind). We have mixins for that for OneConfig to add support for multi-key keybinds in the MC controls menu