From cb68d6c7b6dafe7a22f02478cea5938c6fab2164 Mon Sep 17 00:00:00 2001 From: mohamed-elkholy95 Date: Mon, 1 Jun 2026 09:45:51 -0400 Subject: [PATCH] fix(ci): restore version-tag trigger glob in release workflows MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit fb7fdbf changed the v* tag trigger from "v[0-9]+.[0-9]+.[0-9]+" to "v+([0-9]).+([0-9]).+([0-9])". GitHub Actions ref filters are not ksh extglob — `(` and `)` are literal, so the new pattern matches no real version tag and silently fires nothing. v0.28.0 was the first tag pushed after the change and triggered zero release/installer/promote/distribution workflows. Restore the proven "v[0-9]+.[0-9]+.[0-9]+" pattern (which shipped v0.24.0–v0.27.0) across all 7 affected workflows: release-pythinker-cli, promote-release, linux-installer, windows-installer, homebrew-tap, scoop-bucket, docker. The pythinker-core/host/sdk release workflows use pythinker-*-* globs and were unaffected. [skip changelog] — CI trigger fix, no user-facing product change. --- .github/workflows/docker.yml | 2 +- .github/workflows/homebrew-tap.yml | 2 +- .github/workflows/linux-installer.yml | 2 +- .github/workflows/promote-release.yml | 2 +- .github/workflows/release-pythinker-cli.yml | 2 +- .github/workflows/scoop-bucket.yml | 2 +- .github/workflows/windows-installer.yml | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index 6f249ac6..6e7ae8fb 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -3,7 +3,7 @@ name: Docker (GHCR) on: push: tags: - - "v+([0-9]).+([0-9]).+([0-9])" + - "v[0-9]+.[0-9]+.[0-9]+" workflow_dispatch: inputs: version: diff --git a/.github/workflows/homebrew-tap.yml b/.github/workflows/homebrew-tap.yml index b4ddfb57..40ba7015 100644 --- a/.github/workflows/homebrew-tap.yml +++ b/.github/workflows/homebrew-tap.yml @@ -3,7 +3,7 @@ name: Update Homebrew tap on: push: tags: - - "v+([0-9]).+([0-9]).+([0-9])" + - "v[0-9]+.[0-9]+.[0-9]+" workflow_dispatch: inputs: version: diff --git a/.github/workflows/linux-installer.yml b/.github/workflows/linux-installer.yml index 7fffe247..cfab2ab8 100644 --- a/.github/workflows/linux-installer.yml +++ b/.github/workflows/linux-installer.yml @@ -4,7 +4,7 @@ on: push: tags: # Same scheme as release-pythinker-cli.yml and windows-installer.yml. - - "v+([0-9]).+([0-9]).+([0-9])" + - "v[0-9]+.[0-9]+.[0-9]+" workflow_dispatch: inputs: version: diff --git a/.github/workflows/promote-release.yml b/.github/workflows/promote-release.yml index 9443ba5a..58b15668 100644 --- a/.github/workflows/promote-release.yml +++ b/.github/workflows/promote-release.yml @@ -16,7 +16,7 @@ name: Promote release on: push: tags: - - "v+([0-9]).+([0-9]).+([0-9])" + - "v[0-9]+.[0-9]+.[0-9]+" workflow_dispatch: inputs: tag: diff --git a/.github/workflows/release-pythinker-cli.yml b/.github/workflows/release-pythinker-cli.yml index 7cb85b38..270dc98f 100644 --- a/.github/workflows/release-pythinker-cli.yml +++ b/.github/workflows/release-pythinker-cli.yml @@ -3,7 +3,7 @@ name: Release (pythinker-code) on: push: tags: - - "v+([0-9]).+([0-9]).+([0-9])" + - "v[0-9]+.[0-9]+.[0-9]+" permissions: contents: write diff --git a/.github/workflows/scoop-bucket.yml b/.github/workflows/scoop-bucket.yml index e78d8414..6e333650 100644 --- a/.github/workflows/scoop-bucket.yml +++ b/.github/workflows/scoop-bucket.yml @@ -3,7 +3,7 @@ name: Update Scoop bucket on: push: tags: - - "v+([0-9]).+([0-9]).+([0-9])" + - "v[0-9]+.[0-9]+.[0-9]+" workflow_dispatch: inputs: version: diff --git a/.github/workflows/windows-installer.yml b/.github/workflows/windows-installer.yml index 5fc6581b..106dfd42 100644 --- a/.github/workflows/windows-installer.yml +++ b/.github/workflows/windows-installer.yml @@ -4,7 +4,7 @@ on: push: tags: # Match the existing PyPI release workflow's tag scheme: v... - - "v+([0-9]).+([0-9]).+([0-9])" + - "v[0-9]+.[0-9]+.[0-9]+" workflow_dispatch: inputs: version: