fix: address second round of PR review findings

- AGENTS.md: replace a developer-specific absolute file:// link with a
  repository-relative one, so it resolves in any clone.
- preflight.ts: set windowsHide on the detached Windows update spawn —
  detached child processes get their own console window on Windows
  regardless of stdio, so stdio: 'ignore' alone did not suppress it.

Author: elkaix

AGENTS.md

@@ -23,7 +23,7 @@ Any OpenAI-compatible endpoint (DeepSeek, Qwen, GLM, Grok, Together AI, Firework
 
 ### Model Selection
 
-Flows through the **catalog** ([catalog.ts](file:///Users/panda/Projects/active/pythinker-code-tsc/packages/kosong/src/catalog.ts)):
+Flows through the **catalog** ([catalog.ts](packages/kosong/src/catalog.ts)):
 
 1. JSON catalog maps `providerId → models[]` with context window, capabilities, cost, and modality metadata.
 2. `inferWireType()` resolves provider → wire type (explicit `type` field, then heuristic on `npm`/`id`).

apps/pythinker-code/src/cli/update/preflight.ts

@@ -812,6 +812,9 @@ async function startBackgroundInstall(
 
     const child = spawn(cmd, [...args], {
       detached: true,
+      // A detached child gets its own console window on Windows regardless
+      // of stdio; stdio: 'ignore' alone does not suppress it.
+      windowsHide: platform === 'win32',
       stdio: 'ignore',
       env: env === undefined ? undefined : { ...process.env, ...env },
     });

apps/pythinker-code/test/cli/update/preflight.test.ts

@@ -312,7 +312,7 @@ describe('runUpdatePreflight', () => {
     expect(mocks.spawn).toHaveBeenCalledWith(
       expect.stringMatching(/^npm(\.cmd)?$/),
       ['install', '-g', '@pythoughts/pythinker-code@0.5.0'],
-      { detached: true, stdio: 'ignore' },
+      { detached: true, windowsHide: false, stdio: 'ignore' },
     );
   });
 
@@ -576,6 +576,7 @@ describe('runUpdatePreflight', () => {
         ],
         {
           detached: true,
+          windowsHide: true,
           stdio: 'ignore',
           env: expect.objectContaining({ PYTHINKER_VERSION: '0.5.0' }),
         },
@@ -633,7 +634,7 @@ describe('runUpdatePreflight', () => {
     expect(mocks.spawn).toHaveBeenCalledWith(
       expect.stringMatching(/^npm(\.cmd)?$/),
       ['install', '-g', '@pythoughts/pythinker-code@0.5.0'],
-      { detached: true, stdio: 'ignore' },
+      { detached: true, windowsHide: false, stdio: 'ignore' },
     );
     expect(writeUpdateInstallState).toHaveBeenCalledWith(expect.objectContaining({
       active: expect.objectContaining({
@@ -816,7 +817,7 @@ describe('runUpdatePreflight', () => {
     expect(mocks.spawn).toHaveBeenCalledWith(
       expect.stringMatching(/^npm(\.cmd)?$/),
       ['install', '-g', '@pythoughts/pythinker-code@0.6.0'],
-      { detached: true, stdio: 'ignore' },
+      { detached: true, windowsHide: false, stdio: 'ignore' },
     );
   });
 
@@ -840,7 +841,7 @@ describe('runUpdatePreflight', () => {
     expect(mocks.spawn).toHaveBeenCalledWith(
       expect.stringMatching(/^npm(\.cmd)?$/),
       ['install', '-g', '@pythoughts/pythinker-code@0.6.0'],
-      { detached: true, stdio: 'ignore' },
+      { detached: true, windowsHide: false, stdio: 'ignore' },
     );
   });
 
@@ -864,7 +865,7 @@ describe('runUpdatePreflight', () => {
     expect(mocks.spawn).toHaveBeenCalledWith(
       expect.stringMatching(/^npm(\.cmd)?$/),
       ['install', '-g', '@pythoughts/pythinker-code@0.6.0'],
-      { detached: true, stdio: 'ignore' },
+      { detached: true, windowsHide: false, stdio: 'ignore' },
     );
   });
 
@@ -1017,7 +1018,7 @@ describe('runUpdatePreflight', () => {
     expect(mocks.spawn).toHaveBeenCalledWith(
       expect.stringMatching(/^npm(\.cmd)?$/),
       ['install', '-g', '@pythoughts/pythinker-code@0.5.0'],
-      { detached: true, stdio: 'ignore' },
+      { detached: true, windowsHide: false, stdio: 'ignore' },
     );
   });
 
@@ -1307,7 +1308,7 @@ describe('runUpdatePreflight', () => {
       expect(mocks.spawn).toHaveBeenCalledWith(
         expect.stringMatching(/^npm(\.cmd)?$/),
         ['install', '-g', '@pythoughts/pythinker-code@0.5.0'],
-        { detached: true, stdio: 'ignore' },
+        { detached: true, windowsHide: false, stdio: 'ignore' },
       );
       expect(track).toHaveBeenCalledWith('update_background_install_started', expect.objectContaining({
         target_version: '0.5.0',
@@ -1433,7 +1434,7 @@ describe('runUpdatePreflight', () => {
       expect(mocks.spawn).toHaveBeenCalledWith(
         expect.stringMatching(/^npm(\.cmd)?$/),
         ['install', '-g', '@pythoughts/pythinker-code@0.5.0'],
-        { detached: true, stdio: 'ignore' },
+        { detached: true, windowsHide: false, stdio: 'ignore' },
       );
       expect(track).toHaveBeenCalledWith('update_background_install_started', expect.objectContaining({
         target_version: '0.5.0',