Skip to content

Commit 7321b89

Browse files
committed
ci: gate the desktop suite and typecheck on pull requests
apps/desktop shipped 65 vitest cases and a typecheck script that no required check ran: the root vitest projects list stopped at apps/pythinker-code, and the typecheck job looped packages/* plus apps/pythinker-code only. A desktop regression merged green. Register the project and add a per-package typecheck step rather than extending the tsgo loop, which would cover the source tsconfig and silently skip tests/tsconfig.json.
1 parent 815b892 commit 7321b89

3 files changed

Lines changed: 4 additions & 2 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,3 +88,5 @@ jobs:
8888
run: pnpm --filter @pymodel/dashboard-server run typecheck
8989
- name: Typecheck dashboard-web
9090
run: pnpm --filter @pymodel/dashboard-web run typecheck
91+
- name: Typecheck desktop
92+
run: pnpm --filter @pymodel/pythinker-desktop run typecheck

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"build:plugin-marketplace": "pnpm -C apps/pythinker-code run build:plugin-marketplace",
1919
"dashboard": "pnpm -C apps/dashboard run dev",
2020
"dev:docs": "pnpm -C docs install --ignore-workspace && pnpm -C docs run dev",
21-
"typecheck": "pnpm run build:packages && pnpm -r --filter './packages/*' run typecheck && pnpm --filter @pymodel/pythinker-code run typecheck && pnpm --filter @pymodel/pythinker-web run typecheck && pnpm --filter @pymodel/dashboard-server run typecheck && pnpm --filter @pymodel/dashboard-web run typecheck",
21+
"typecheck": "pnpm run build:packages && pnpm -r --filter './packages/*' run typecheck && pnpm --filter @pymodel/pythinker-code run typecheck && pnpm --filter @pymodel/pythinker-web run typecheck && pnpm --filter @pymodel/dashboard-server run typecheck && pnpm --filter @pymodel/dashboard-web run typecheck && pnpm --filter @pymodel/pythinker-desktop run typecheck",
2222
"lint": "oxlint --type-aware",
2323
"lint:fix": "pnpm run lint --fix",
2424
"lint:pkg": "pnpm --filter @pymodel/pythinker-code exec publint && npm_config_cache=${TMPDIR:-/tmp}/pythinker-code-npm-cache pnpm --filter @pymodel/pythinker-code exec attw --pack . --profile node16",

vitest.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { defineConfig } from 'vitest/config';
22

33
export default defineConfig({
44
test: {
5-
projects: ['packages/*', 'apps/pythinker-code'],
5+
projects: ['packages/*', 'apps/pythinker-code', 'apps/desktop'],
66
coverage: {
77
provider: 'v8',
88
include: ['packages/*/src/**/*.ts', 'apps/*/src/**/*.ts'],

0 commit comments

Comments
 (0)