Skip to content

Commit 8ae5114

Browse files
committed
fix: address PR review findings
Cover the new question, approval, and prompt lifecycle events in the SDK event exhaustiveness test, align the session listing test with the intentional skip-invalid contract, and drop an unused path import from the desktop staging script.
1 parent 2dfd2db commit 8ae5114

3 files changed

Lines changed: 13 additions & 3 deletions

File tree

apps/desktop/scripts/stage-runtime.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { spawn } from 'node:child_process'
44
import { existsSync } from 'node:fs'
55
import { cp, lstat, mkdir, mkdtemp, readFile, readdir, realpath, rm, writeFile } from 'node:fs/promises'
66
import { tmpdir } from 'node:os'
7-
import { dirname, join, resolve, sep } from 'node:path'
7+
import { join, resolve, sep } from 'node:path'
88

99
const desktopRoot = resolve(import.meta.dirname, '..')
1010
const repositoryRoot = resolve(desktopRoot, '../..')

packages/node-sdk/test/list-sessions.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -311,15 +311,15 @@ describe('SessionStore.list', () => {
311311
expect(sessions.find((session) => session.id === fallback.id)?.title).toBe('Fallback Title');
312312
});
313313

314-
it('rejects malformed indexed state instead of treating it as an incomplete summary', async () => {
314+
it('skips malformed indexed state instead of treating it as an incomplete summary', async () => {
315315
const homeDir = await makeTempDir();
316316
const workDir = await makeTempDir();
317317
const store = new SessionStore(homeDir);
318318

319319
const malformed = await createStoredSession(store, { id: 'ses_bad_state', workDir });
320320
await writeFile(join(malformed.sessionDir, 'state.json'), '{bad json', 'utf-8');
321321

322-
await expect(store.list({ workDir })).rejects.toMatchObject({ code: 'session.state_invalid' });
322+
await expect(store.list({ workDir })).resolves.toEqual([]);
323323
});
324324

325325
it('sorts by filesystem activity descending', async () => {

packages/node-sdk/test/session-event-types.test.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,13 @@ describe('Event public types', () => {
7676
case 'event.workspace.updated':
7777
case 'event.workspace.deleted':
7878
case 'event.config.changed':
79+
case 'event.question.requested':
80+
case 'event.question.answered':
81+
case 'event.question.dismissed':
82+
case 'event.question.expired':
83+
case 'event.approval.requested':
84+
case 'event.approval.resolved':
85+
case 'event.approval.expired':
7986
case 'goal.updated':
8087
case 'skill.activated':
8188
case 'error':
@@ -111,6 +118,9 @@ describe('Event public types', () => {
111118
case 'background.task.terminated':
112119
case 'cron.fired':
113120
case 'prompt.submitted':
121+
case 'prompt.completed':
122+
case 'prompt.aborted':
123+
case 'prompt.steered':
114124
return;
115125
default:
116126
assertNever(event);

0 commit comments

Comments
 (0)