fix(workflow): reject a misplaced --personal flag in /workflow save

A workflow name may contain spaces, so the flag was stripped wherever it
appeared. That let 'save report --personal extra' save under the name
'report extra' in personal scope without a word to the user.

Recognise --personal only as the first or last token and reject the rest,
and document that a saved workflow is invoked under its generated skill
name rather than the name as typed.

Author: elkaix

apps/pythinker-code/src/tui/commands/dynamic-workflow.ts

@@ -134,11 +134,16 @@ async function handleSaveSubcommand(host: SlashCommandHost, input: string): Prom
   if (match === null) return false;
 
   const tokens = (match[1] ?? '').split(/\s+/u).filter((token) => token.length > 0);
-  const personalIndex = tokens.indexOf('--personal');
-  const scope: SavedWorkflowScope = personalIndex === -1 ? 'project' : 'personal';
-  if (personalIndex !== -1) tokens.splice(personalIndex, 1);
+  // A name may contain spaces, so the flag is only recognised at either end.
+  // Anywhere else — or twice — it is a typo rather than part of the name, and
+  // folding it in would silently save under a different name and scope.
+  const personalFirst = tokens[0] === '--personal';
+  const personalLast = !personalFirst && tokens.at(-1) === '--personal';
+  if (personalFirst) tokens.shift();
+  else if (personalLast) tokens.pop();
+  const scope: SavedWorkflowScope = personalFirst || personalLast ? 'personal' : 'project';
   const name = tokens.join(' ');
-  if (name.length === 0) {
+  if (name.length === 0 || tokens.includes('--personal')) {
     host.showError('Usage: /workflow save <name> [--personal]');
     return true;
   }

apps/pythinker-code/test/tui/commands/dynamic-workflow.test.ts

@@ -510,8 +510,7 @@ describe('/workflow save', () => {
 
   it('saves --personal into the data dir and records the size guideline', async () => {
     const home = await fs.mkdtemp(join(tmpdir(), 'workflow-home-'));
-    const previousHome = process.env['PYTHINKER_CODE_HOME'];
-    process.env['PYTHINKER_CODE_HOME'] = home;
+    vi.stubEnv('PYTHINKER_CODE_HOME', home);
     // Explicit empty env: the default is process.env, where an exported
     // PYTHINKER_CODE_WORKFLOW_SIZE_GUIDELINE would override 'small' and fail
     // this test for reasons unrelated to the change under test.
@@ -532,15 +531,25 @@ describe('/workflow save', () => {
       expect(session.reloadSkills).toHaveBeenCalledOnce();
       expect(host.showError).not.toHaveBeenCalled();
     } finally {
-      if (previousHome === undefined) {
-        delete process.env['PYTHINKER_CODE_HOME'];
-      } else {
-        process.env['PYTHINKER_CODE_HOME'] = previousHome;
-      }
+      vi.unstubAllEnvs();
       // The module-level cache cannot return to unset; the resolved default
       // ('medium') matches what TUI startup would have cached in production.
       setWorkflowSizeGuideline(undefined, {});
       await fs.rm(home, { recursive: true, force: true });
     }
   });
+
+  it('rejects --personal when it is repeated or not at either end', async () => {
+    for (const input of [
+      'save Audit --personal Routes',
+      'save --personal Audit --personal',
+      'save --personal --personal',
+    ]) {
+      const { host } = makeHost({ permissionMode: 'auto' });
+
+      await handleDynamicWorkflowCommand(host, input);
+
+      expect(host.showError).toHaveBeenCalledWith('Usage: /workflow save <name> [--personal]');
+    }
+  });
 });

docs/reference/slash-commands.md

@@ -52,7 +52,7 @@ Some commands are only available in the idle state. Executing these commands whi
 | `/workflow [on\|off]` | — | Toggle Dynamic Workflow mode without sending a prompt. Without arguments, flips the current state; explicitly passing `on`/`off` forces the setting. | No |
 | `/workflow <task>` | — | Turn Dynamic Workflow mode on, then send `<task>` as a normal prompt. If the turn completes normally, Dynamic Workflow mode turns off automatically. In `manual` permission mode, Pythinker Code asks whether to switch to `auto` or `yolo` before starting. | No |
 | `/workflow model [alias\|off]` | — | Ask Dynamic Workflow subagents to run on `alias` instead of the session model, so workers can use a cheaper or faster model than the agent orchestrating them. Without arguments, shows the current setting; `off` clears it. Lasts for the session. | No |
-| `/workflow save <name> [--personal]` | — | Save the last Dynamic Workflow that ran in this session as a skill, immediately invocable as `/<name>`. Saves into the project (`<repo root>/.pythinker-code/skills/`) by default; `--personal` saves into your home skills directory instead. | No |
+| `/workflow save <name> [--personal]` | — | Save the last Dynamic Workflow that ran in this session as a skill, immediately invocable under its generated skill name — `Audit Routes` becomes `/audit-routes`. Saves into the project (`<repo root>/.pythinker-code/skills/`) by default; `--personal` saves into your home skills directory instead. | No |
 | `/goal [...]` | — | Start or manage an autonomous goal | See below |
 
 ::: info