fix(update): keep the unverified reason on manual installs too

Author: elkaix

apps/pythinker-code/src/cli/sub/upgrade.ts

@@ -13,6 +13,7 @@ import {
 } from '#/cli/update/install-state';
 import { isTargetInstallable, selectUpdateTarget } from '#/cli/update/select';
 import { detectInstallSource } from '#/cli/update/source';
+import type { InstallVerification } from '#/cli/update/verify-install';
 import {
   canAutoInstall,
   installCommandFor,
@@ -47,7 +48,7 @@ export interface UpgradeDeps {
     source: InstallSource,
     version: string,
     platform: NodeJS.Platform,
-  ) => Promise<void>;
+  ) => Promise<InstallVerification>;
   readonly promptForInstallChoice: (
     options: InstallPromptOptions,
   ) => Promise<InstallPromptChoiceValue>;
@@ -180,7 +181,7 @@ export async function handleUpgrade(
       target_version: target.version,
       source,
     });
-    await deps.installUpdate(source, target.version, deps.platform);
+    const verification = await deps.installUpdate(source, target.version, deps.platform);
     await deps.writeUpdateInstallState({
       ...installState,
       active: null,
@@ -189,6 +190,7 @@ export async function handleUpgrade(
         version: target.version,
         installedAt: nowIso(),
         notifiedAt: null,
+        unverified: verification.ok ? verification.unverified : undefined,
       },
     }).catch(() => {});
     trackUpgradeEvent(deps.track, 'upgrade_command_succeeded', {

apps/pythinker-code/src/cli/update/preflight.ts

@@ -583,7 +583,7 @@ export async function installUpdate(
   source: InstallSource,
   version: string,
   platform: NodeJS.Platform,
-): Promise<void> {
+): Promise<InstallVerification> {
   const { cmd, args, env } = spawnForSource(source, version, platform);
   await new Promise<void>((resolve, reject) => {
     const child = spawn(cmd, [...args], {
@@ -605,6 +605,9 @@ export async function installUpdate(
   // installer gets, instead of printing "Updated …" over an unchanged binary.
   const verification = await verifyInstalledVersion(source, version);
   if (!verification.ok) throw new Error(verification.reason);
+  // Returned so the caller can record *why* a success is unproven; see
+  // verify-install.ts for the fail-open rule.
+  return verification;
 }
 
 /** Keep the tail only: installers can be chatty, and the state file is small. */
@@ -1449,7 +1452,7 @@ export async function runUpdatePreflight(
     if (lock === null) return 'continue';
 
     try {
-      await installUpdate(source, userVisibleTarget.version, platform);
+      const verification = await installUpdate(source, userVisibleTarget.version, platform);
       await writeUpdateInstallState({
         ...installState,
         active: null,
@@ -1458,6 +1461,7 @@ export async function runUpdatePreflight(
           version: userVisibleTarget.version,
           installedAt: nowIso(),
           notifiedAt: null,
+          unverified: verification.ok ? verification.unverified : undefined,
         },
       }).catch(() => {});
       stdout.write(renderInstallSuccessMessage(userVisibleTarget));

apps/pythinker-code/test/cli/upgrade.test.ts

@@ -5,6 +5,7 @@ import { emptyUpdateInstallState } from '#/cli/update/install-state';
 import type { UpdateInstallLockHandle } from '#/cli/update/install-lock';
 import type { InstallPromptChoiceValue } from '#/cli/update/prompt';
 import type { InstallSource, UpdateCache, UpdateInstallState } from '#/cli/update/types';
+import type { InstallVerification } from '#/cli/update/verify-install';
 
 function cacheWith(
   version: string | null,
@@ -69,7 +70,11 @@ function createDeps(overrides: {
   readonly source?: InstallSource;
   readonly isInteractive?: boolean;
   readonly promptForInstallChoice?: () => Promise<InstallPromptChoiceValue>;
-  readonly installUpdate?: (source: InstallSource, version: string, platform: NodeJS.Platform) => Promise<void>;
+  readonly installUpdate?: (
+    source: InstallSource,
+    version: string,
+    platform: NodeJS.Platform,
+  ) => Promise<InstallVerification>;
   readonly readUpdateInstallState?: () => Promise<UpdateInstallState>;
   readonly writeUpdateInstallState?: (state: UpdateInstallState) => Promise<void>;
   readonly tryAcquireUpdateInstallLock?: () => Promise<UpdateInstallLockHandle | null>;
@@ -80,7 +85,7 @@ function createDeps(overrides: {
       source: InstallSource,
       version: string,
       platform: NodeJS.Platform,
-    ) => Promise<void>>().mockResolvedValue(undefined);
+    ) => Promise<InstallVerification>>().mockResolvedValue({ ok: true });
 
   return {
     refreshUpdateCache: vi
@@ -212,6 +217,29 @@ describe('handleUpgrade', () => {
     expect(stdout.join('')).toContain('To update manually, run: npm install -g @pythoughts/pythinker-code@0.5.0');
   });
 
+  it('records why a manual install could not be verified', async () => {
+    const { writable } = captureOutput();
+    const writeUpdateInstallState = vi.fn().mockResolvedValue(undefined);
+    const deps = createDeps({
+      latest: '0.5.0',
+      source: 'native',
+      installUpdate: vi.fn().mockResolvedValue({
+        ok: true,
+        unverified: '/usr/local/bin/pythinker could not be run: ETIMEDOUT',
+      }),
+      writeUpdateInstallState,
+    });
+
+    await expect(handleUpgrade('0.4.0', { ...deps, ...writable })).resolves.toBe(0);
+
+    expect(writeUpdateInstallState).toHaveBeenCalledWith(expect.objectContaining({
+      lastSuccess: expect.objectContaining({
+        version: '0.5.0',
+        unverified: expect.stringContaining('ETIMEDOUT'),
+      }),
+    }));
+  });
+
   it('returns a failing exit code when the foreground install fails', async () => {
     const { stderr, writable } = captureOutput();
     const deps = createDeps({