Commit f670efe
authored
docs: require pull requests for every change to main (#19)
## Related Issue
No issue — this documents a repository setting change made directly on
GitHub.
## Problem
`main` had branch protection, but `enforce_admins` was off and required
approvals were `0`. Admins
bypassed every rule, so changes were landing on `main` by direct push
with no PR and no gate. The
constraint existed on paper but not in practice.
## What changed
`main` branch protection now sets `enforce_admins: true`. Direct pushes
are rejected for everyone,
admins included — verified by an empty commit that came back `GH006:
Changes must be made through a
pull request`.
Required approvals stay at `0` deliberately: the repository has a single
collaborator, and
`coderabbitai` only ever submits `COMMENTED` reviews, never `APPROVED`.
Requiring an approval would
make every self-authored PR permanently unmergeable. The gate is
therefore PR + green checks +
resolved conversations rather than a human approval signature.
This PR records the rule in `AGENTS.md`, where the other workflow
constraints live, and is itself
the first change to go through the new flow.
## Checklist
- [x] I have read the
[CONTRIBUTING](https://github.com/Pythoughts-labs/pythinker-code/blob/main/CONTRIBUTING.md)
document.
- [x] I have linked a related issue, or explained the problem above.
- [ ] I have added tests that prove my feature works. — documentation
only, nothing executable
- [x] Ran `gen-changesets` skill, or this PR needs no changeset. —
docs-only, no CLI bump
- [x] Ran `gen-docs` skill, or this PR needs no doc update.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Documentation**
* Added contribution guidelines requiring changes to be submitted
through pull requests.
* Documented requirements for passing checks, resolving review comments,
and keeping branches up to date.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->1 parent d7a5db0 commit f670efe
1 file changed
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
92 | 99 | | |
93 | 100 | | |
94 | 101 | | |
| |||
0 commit comments