Skip to content

Commit 8cd86cc

Browse files
authored
Fix error in epf logic (#152)
1 parent 4494216 commit 8cd86cc

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

src/popt/loop/optimize.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ def run_loop(self):
198198
previous_state = self.xk
199199
self.epf['r'] *= self.epf['r_factor'] # increase penalty factor
200200
self.obj_func_tol *= self.epf['tol_factor'] # decrease tolerance
201-
self.obj_func_values = self.fun(self.xk, **self.epf)
201+
self.obj_func_values = self.fun(self.xk, epf=self.epf)
202202
self.iteration = 0
203203
self.epf_iteration += 1
204204
optimize_result = ot.get_optimize_result(self)

src/popt/update_schemes/enopt.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,9 @@ def __set__variable(var_name=None, defalut=None):
9797

9898
# Set other optimization parameters
9999
self.obj_func_tol = __set__variable('tol', 1e-6)
100-
self.alpha = __set__variable('alpha', 0.1)
100+
self.alpha = __set__variable('step_size', 0.1)
101+
self.alpha = __set__variable('alpha', 0.1) # accept either 'step_size' or 'alpha' for step size,
102+
# with 'alpha' as the default
101103
self.alpha_cov = __set__variable('alpha_cov', 0.001)
102104
self.beta = __set__variable('beta', 0.0) # this is stored in the optimizer class
103105
self.nesterov = __set__variable('nesterov', False) # use Nesterov acceleration if value is true

0 commit comments

Comments
 (0)