feat: check sess package version and prompt for update

- Added version comparison between bundled and installed sess package.

- Added unit tests in sessInstall.test.ts.

- Used exports workaround in util.ts to enable stubbing of local functions in tests.

Author: randy3k

src/test/suite/sessInstall.test.ts

@@ -0,0 +1,81 @@
+import * as assert from 'assert';
+import * as vscode from 'vscode';
+import * as sinon from 'sinon';
+import * as path from 'path';
+import * as util from '../../util';
+import { mockExtensionContext } from '../common/mockvscode';
+
+const extension_root: string = path.join(__dirname, '..', '..', '..');
+
+suite('Sess Install Test Suite', () => {
+    let sandbox: sinon.SinonSandbox;
+    let originalSessionWatcher: boolean | undefined;
+
+    setup(() => {
+        sandbox = sinon.createSandbox();
+        mockExtensionContext(extension_root, sandbox);
+        originalSessionWatcher = vscode.workspace.getConfiguration('r').get<boolean>('sessionWatcher');
+    });
+
+    teardown(async () => {
+        await vscode.workspace.getConfiguration('r').update('sessionWatcher', originalSessionWatcher, vscode.ConfigurationTarget.Global);
+        sandbox.restore();
+    });
+
+    test('promptToInstallSessPackage does nothing if sessionWatcher is disabled', async () => {
+        await vscode.workspace.getConfiguration('r').update('sessionWatcher', false, vscode.ConfigurationTarget.Global);
+        
+        const getVersionStub = sandbox.stub(util, 'getRPackageVersion').resolves(undefined);
+        const showMessageStub = sandbox.stub(vscode.window, 'showErrorMessage').resolves(undefined);
+        
+        await util.promptToInstallSessPackage();
+        
+        assert.strictEqual(getVersionStub.called, false);
+        assert.strictEqual(showMessageStub.called, false);
+    });
+
+    test('promptToInstallSessPackage prompts to install if not installed', async () => {
+        await vscode.workspace.getConfiguration('r').update('sessionWatcher', true, vscode.ConfigurationTarget.Global);
+        sandbox.stub(util, 'getRPackageVersion').resolves(undefined);
+        
+        // Mock reading DESCRIPTION file
+        sandbox.stub(util, 'readFileSyncSafe').returns('Package: sess\nVersion: 0.1.0\n');
+        
+        const showMessageStub = sandbox.stub(vscode.window, 'showErrorMessage').resolves(undefined);
+        
+        await util.promptToInstallSessPackage();
+        
+        assert.strictEqual(showMessageStub.calledOnce, true);
+        const args = showMessageStub.getCall(0).args;
+        assert.ok(args[0].includes('required for the session watcher to work'));
+    });
+
+    test('promptToInstallSessPackage prompts to update if installed version is older', async () => {
+        await vscode.workspace.getConfiguration('r').update('sessionWatcher', true, vscode.ConfigurationTarget.Global);
+        sandbox.stub(util, 'getRPackageVersion').resolves('0.0.9');
+        
+        // Mock reading DESCRIPTION file with newer version
+        sandbox.stub(util, 'readFileSyncSafe').returns('Package: sess\nVersion: 0.1.0\n');
+        
+        const showMessageStub = sandbox.stub(vscode.window, 'showErrorMessage').resolves(undefined);
+        
+        await util.promptToInstallSessPackage();
+        
+        assert.strictEqual(showMessageStub.calledOnce, true);
+        const args = showMessageStub.getCall(0).args;
+        assert.ok(args[0].includes('A newer version of R package "sess" (0.1.0) is available'));
+    });
+
+    test('promptToInstallSessPackage does not prompt if installed version is newer or equal', async () => {
+        await vscode.workspace.getConfiguration('r').update('sessionWatcher', true, vscode.ConfigurationTarget.Global);
+        sandbox.stub(util, 'getRPackageVersion').resolves('0.1.0');
+        
+        sandbox.stub(util, 'readFileSyncSafe').returns('Package: sess\nVersion: 0.1.0\n');
+        
+        const showMessageStub = sandbox.stub(vscode.window, 'showErrorMessage').resolves(undefined);
+        
+        await util.promptToInstallSessPackage();
+        
+        assert.strictEqual(showMessageStub.called, false);
+    });
+});

src/util.ts

@@ -592,19 +592,33 @@ export async function promptToInstallRPackage(name: string, section: string, cwd
  * Prompt to install the bundled "sess" package
  */
 export async function promptToInstallSessPackage(cwd?: string | vscode.Uri): Promise<void> {
-    const _config = config();
+    const _config = (exports as typeof import('./util')).config();
     const sessionWatcher = _config.get<boolean>('sessionWatcher');
     if (!sessionWatcher) {
         return;
     }
-    const sessVersion = await getRPackageVersion('sess', cwd instanceof vscode.Uri ? cwd.fsPath : cwd);
-    if (sessVersion) {
-        return;
-    }
 
     const sessPath = extensionContext.asAbsolutePath('sess').replace(/\\/g, '/');
+    const descriptionPath = path.join(sessPath, 'DESCRIPTION');
+    const descriptionContent = (exports as typeof import('./util')).readFileSyncSafe(descriptionPath);
+    const match = descriptionContent?.match(/^Version:\s*(.+)$/m);
+    const bundledVersion = match ? match[1] : undefined;
+
+    const installedVersion = await (exports as typeof import('./util')).getRPackageVersion('sess', cwd instanceof vscode.Uri ? cwd.fsPath : cwd);
+
+    if (installedVersion && bundledVersion && compareVersions(installedVersion, bundledVersion) >= 0) {
+        return; // Already up to date
+    } else if (installedVersion && !bundledVersion) {
+        return; // Cannot determine bundled version, assume OK
+    }
+
     const installSessScript = extensionContext.asAbsolutePath(path.join('R', 'install_sess.R')).replace(/\\/g, '/');
-    const installMsg = 'R package "sess" (shipped with vscode-R) is required for the session watcher to work. Do you want to install it?';
+    
+    let installMsg = 'R package "sess" (shipped with vscode-R) is required for the session watcher to work. Do you want to install it?';
+    if (installedVersion && bundledVersion && compareVersions(installedVersion, bundledVersion) < 0) {
+        installMsg = `A newer version of R package "sess" (${bundledVersion}) is available (installed: ${installedVersion}). Do you want to update it?`;
+    }
+
     await vscode.window.showErrorMessage(installMsg, 'Yes', 'No')
         .then(async function (select) {
             if (select === 'Yes') {