From 7cf15f9e02c53e3fe97cb69384953895decaeaf1 Mon Sep 17 00:00:00 2001 From: Artur Wojcik Date: Fri, 8 May 2026 10:10:24 +0200 Subject: [PATCH 1/6] clean up the include graph for the instruction_ref --- src/include/migraphx/instruction_ref.hpp | 4 ---- src/include/migraphx/split_reduce.hpp | 1 + test/promote_literals_test.cpp | 2 ++ 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/include/migraphx/instruction_ref.hpp b/src/include/migraphx/instruction_ref.hpp index 4c6b6876334..95008c99273 100644 --- a/src/include/migraphx/instruction_ref.hpp +++ b/src/include/migraphx/instruction_ref.hpp @@ -87,8 +87,4 @@ struct hash } // namespace std -#ifdef _MSC_VER -#include -#endif - #endif diff --git a/src/include/migraphx/split_reduce.hpp b/src/include/migraphx/split_reduce.hpp index 687f363b0d2..72364ceca59 100644 --- a/src/include/migraphx/split_reduce.hpp +++ b/src/include/migraphx/split_reduce.hpp @@ -32,6 +32,7 @@ namespace migraphx { inline namespace MIGRAPHX_INLINE_NS { struct module_pass_manager; +struct instruction; /// For large reductions that are larger than the split_size, this pass will /// split the fused_reduce operators so that the reduction will happen across diff --git a/test/promote_literals_test.cpp b/test/promote_literals_test.cpp index 6e6e021c5b2..f566c442172 100644 --- a/test/promote_literals_test.cpp +++ b/test/promote_literals_test.cpp @@ -22,6 +22,8 @@ * THE SOFTWARE. */ +#include +#include #include #include #include From e1eba5464d896ae960dba244f48dac4e59c5391f Mon Sep 17 00:00:00 2001 From: Artur Wojcik Date: Fri, 8 May 2026 10:31:03 +0200 Subject: [PATCH 2/6] update licenses --- src/include/migraphx/instruction_ref.hpp | 2 +- src/include/migraphx/split_reduce.hpp | 2 +- test/promote_literals_test.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/include/migraphx/instruction_ref.hpp b/src/include/migraphx/instruction_ref.hpp index 95008c99273..695f0464695 100644 --- a/src/include/migraphx/instruction_ref.hpp +++ b/src/include/migraphx/instruction_ref.hpp @@ -1,7 +1,7 @@ /* * The MIT License (MIT) * - * Copyright (c) 2015-2025 Advanced Micro Devices, Inc. All rights reserved. + * Copyright (c) 2015-2026 Advanced Micro Devices, Inc. All rights reserved. * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to deal diff --git a/src/include/migraphx/split_reduce.hpp b/src/include/migraphx/split_reduce.hpp index 72364ceca59..050c52bc094 100644 --- a/src/include/migraphx/split_reduce.hpp +++ b/src/include/migraphx/split_reduce.hpp @@ -1,7 +1,7 @@ /* * The MIT License (MIT) * - * Copyright (c) 2015-2024 Advanced Micro Devices, Inc. All rights reserved. + * Copyright (c) 2015-2026 Advanced Micro Devices, Inc. All rights reserved. * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to deal diff --git a/test/promote_literals_test.cpp b/test/promote_literals_test.cpp index f566c442172..f4d876558f8 100644 --- a/test/promote_literals_test.cpp +++ b/test/promote_literals_test.cpp @@ -1,7 +1,7 @@ /* * The MIT License (MIT) * - * Copyright (c) 2015-2025 Advanced Micro Devices, Inc. All rights reserved. + * Copyright (c) 2015-2026 Advanced Micro Devices, Inc. All rights reserved. * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to deal From 8bf5d58f466410f2d0ddf7600ce14621e58fd949 Mon Sep 17 00:00:00 2001 From: Artur Wojcik Date: Mon, 11 May 2026 12:50:36 +0200 Subject: [PATCH 3/6] incorporate review feedback --- src/include/migraphx/split_reduce.hpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/include/migraphx/split_reduce.hpp b/src/include/migraphx/split_reduce.hpp index 050c52bc094..caee417be4d 100644 --- a/src/include/migraphx/split_reduce.hpp +++ b/src/include/migraphx/split_reduce.hpp @@ -32,7 +32,6 @@ namespace migraphx { inline namespace MIGRAPHX_INLINE_NS { struct module_pass_manager; -struct instruction; /// For large reductions that are larger than the split_size, this pass will /// split the fused_reduce operators so that the reduction will happen across From 76e3c5a94422a49289e0fcab1ed4f63310bc84a5 Mon Sep 17 00:00:00 2001 From: Artur Wojcik Date: Mon, 11 May 2026 15:56:38 +0200 Subject: [PATCH 4/6] revert update licenses --- src/include/migraphx/instruction_ref.hpp | 2 +- src/include/migraphx/split_reduce.hpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/include/migraphx/instruction_ref.hpp b/src/include/migraphx/instruction_ref.hpp index e8b3e6511e9..5198f9339fc 100644 --- a/src/include/migraphx/instruction_ref.hpp +++ b/src/include/migraphx/instruction_ref.hpp @@ -1,7 +1,7 @@ /* * The MIT License (MIT) * - * Copyright (c) 2015-2026 Advanced Micro Devices, Inc. All rights reserved. + * Copyright (c) 2015-2024 Advanced Micro Devices, Inc. All rights reserved. * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to deal diff --git a/src/include/migraphx/split_reduce.hpp b/src/include/migraphx/split_reduce.hpp index caee417be4d..687f363b0d2 100644 --- a/src/include/migraphx/split_reduce.hpp +++ b/src/include/migraphx/split_reduce.hpp @@ -1,7 +1,7 @@ /* * The MIT License (MIT) * - * Copyright (c) 2015-2026 Advanced Micro Devices, Inc. All rights reserved. + * Copyright (c) 2015-2024 Advanced Micro Devices, Inc. All rights reserved. * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to deal From 19712118fa1ad5c886ec5a712ce4d7fd028de646 Mon Sep 17 00:00:00 2001 From: Artur Wojcik Date: Thu, 14 May 2026 17:11:22 +0200 Subject: [PATCH 5/6] update licenses --- src/include/migraphx/instruction_ref.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/include/migraphx/instruction_ref.hpp b/src/include/migraphx/instruction_ref.hpp index 5198f9339fc..e8b3e6511e9 100644 --- a/src/include/migraphx/instruction_ref.hpp +++ b/src/include/migraphx/instruction_ref.hpp @@ -1,7 +1,7 @@ /* * The MIT License (MIT) * - * Copyright (c) 2015-2024 Advanced Micro Devices, Inc. All rights reserved. + * Copyright (c) 2015-2026 Advanced Micro Devices, Inc. All rights reserved. * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to deal From 5edfbab8d042633cf49eefd02d32672b66527252 Mon Sep 17 00:00:00 2001 From: Artur Wojcik Date: Thu, 14 May 2026 19:12:02 +0200 Subject: [PATCH 6/6] incorporate review feedback --- test/promote_literals_test.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/promote_literals_test.cpp b/test/promote_literals_test.cpp index f4d876558f8..f00d9c421cf 100644 --- a/test/promote_literals_test.cpp +++ b/test/promote_literals_test.cpp @@ -22,9 +22,9 @@ * THE SOFTWARE. */ +#include #include #include -#include #include #include #include