Commit ca9dafc
feat: Auto-register ai-skills for extensions whenever applicable (github#1840)
* feat: Auto-register ai-skills for extensions whenever applicable
* fix: failing test
* fix: address copilot review comments – path traversal guard and use short_name in title
* fix: address remaining copilot review comments – is_file guard, skills type-validation, and exact extension ownership check on fallback rmtree
* fix: address copilot round-3 comments – align skill naming with presets.py convention, safe rmdir on fail, require SKILL.md for fallback rmtree, normalize skill_count in CLI
* fix: is_dir() guard in fast-path rmtree and fix ghost-skill assertion naming
* fix: path-traversal guard on skill_name in both rmtree paths of _unregister_extension_skills
* fix: add SKILL.md ownership check to fast-path rmtree and alias shadowed _get_skills_dir import1 parent f3d0a2e commit ca9dafc
6 files changed
Lines changed: 972 additions & 5 deletions
File tree
- extensions
- src/specify_cli
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
292 | 292 | | |
293 | 293 | | |
294 | 294 | | |
295 | | - | |
| 295 | + | |
296 | 296 | | |
297 | 297 | | |
298 | 298 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
187 | 187 | | |
188 | 188 | | |
189 | 189 | | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
190 | 205 | | |
191 | 206 | | |
192 | 207 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3658 | 3658 | | |
3659 | 3659 | | |
3660 | 3660 | | |
| 3661 | + | |
| 3662 | + | |
| 3663 | + | |
| 3664 | + | |
| 3665 | + | |
| 3666 | + | |
| 3667 | + | |
| 3668 | + | |
| 3669 | + | |
3661 | 3670 | | |
3662 | 3671 | | |
3663 | 3672 | | |
| |||
3696 | 3705 | | |
3697 | 3706 | | |
3698 | 3707 | | |
3699 | | - | |
| 3708 | + | |
3700 | 3709 | | |
3701 | 3710 | | |
| 3711 | + | |
| 3712 | + | |
| 3713 | + | |
3702 | 3714 | | |
3703 | 3715 | | |
3704 | 3716 | | |
3705 | 3717 | | |
3706 | 3718 | | |
| 3719 | + | |
| 3720 | + | |
3707 | 3721 | | |
3708 | 3722 | | |
3709 | 3723 | | |
| |||
0 commit comments