fix: preserve deterministic behavior with connected updates#74
Open
wshlavacek wants to merge 5 commits into
Open
fix: preserve deterministic behavior with connected updates#74wshlavacek wants to merge 5 commits into
wshlavacek wants to merge 5 commits into
Conversation
Author
|
Converting this PR back to draft for now. Local validation found connect-specific output differences that are not covered by the current build-only checks, including a regression on Tutorial_Example and additional deltas in a few feature-coverage models. We are investigating the connected-update path further and will update this PR with validated fixes/results before requesting review again. |
|
@wshlavacek Please resolve conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MoleculeTypereaction order in the connected-update fast path while still using the precomputed connectivity matrixtest/tlbr/tlbr.xmlandtest/testSuite/t3.xmlWhy
On current
master, seeded NFsim runs can diverge between the full membership updater and the connectivity-limited updater even on the same XML and RNG seed. The connected-update path was still able to differ from the full updater in two important ways:MoleculeTypereaction orderThis branch preserves the full updater's effective ordering and broadens the reachable update set where needed, while still falling back to the full updater for indirect-product cases that the connected fast path cannot safely preserve.
In-Repo Repros
These shipped XML fixtures diverge on
masterbetween standard mode and-connect, but match on this branch for the same seed:test/tlbr/tlbr.xmltest/testSuite/t3.xmltest/AN_chemotaxis/an2.xmlValidation
cmake -S . -B /tmp/nfsim-build-connectivitycmake --build /tmp/nfsim-build-connectivity -j4uv run --with numpy python -m unittest validate.TestIssueRegressions.test_connectivity_preserves_seeded_tlbr_trajectory validate.TestIssueRegressions.test_connectivity_preserves_seeded_local_function_trajectorytest/andmodels/masterand now match on this branchtest/testSuite/t_dor2.xml, which fails on bothmasterand this branch because standalone NFsim does not support that two-reactant DOR case