Skip to content

Commit 1e1b72b

Browse files
he-is-harryIanMcCurdy
authored andcommitted
Removed comment about empty string boolean input
- Removed the comment about the behaviour change in DFV 7 which affects empty string inputs for BOOLEAN. - The behaviour will be clear in the test change for BOOLEAN in a separate pull request Bug: 342310
1 parent 583ef9c commit 1e1b72b

1 file changed

Lines changed: 13 additions & 14 deletions

File tree

test/acceptance/db.DataType.js

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1149,8 +1149,7 @@ describe('db', function () {
11491149
var booleanExpectedDFV7 = [{A: true}, {A: null}, {A: false}, {A: true}, {A: true},
11501150
{A: false}, {A: true}, {A: false}, {A: null}, {A: true},
11511151
{A: false}, {A: null}];
1152-
// In DFV1, non number strings are not supported ('true', 'unknown'). There is also a behaviour change
1153-
// for '' which returns null in DFV7 but 0 (false) in DFV1.
1152+
// In DFV1, non number strings are not supported ('true', 'unknown').
11541153
var booleanInsertValuesDFV1 = [
11551154
[true],
11561155
[null],
@@ -1368,8 +1367,8 @@ describe('db', function () {
13681367

13691368
describeRemoteDB('DFV >= 8', function () {
13701369
describeRemoteDB('FIXED8', function () {
1371-
before(setUpTableRemoteDB('FIXED8_TABLE', ['A DECIMAL(15, 5)'], 8));
1372-
after(dropTableRemoteDB('FIXED8_TABLE', 8));
1370+
before(setUpTable('FIXED8_TABLE', ['A DECIMAL(15, 5)'], 8));
1371+
after(dropTable('FIXED8_TABLE', 8));
13731372

13741373
it('should insert and return valid FIXED8 decimals', function (done) {
13751374
testDataTypeValid('FIXED8_TABLE', fixed8InsertValues, [81], fixed8Expected, done);
@@ -1383,8 +1382,8 @@ describe('db', function () {
13831382
});
13841383

13851384
describeRemoteDB('FIXED12', function () {
1386-
before(setUpTableRemoteDB('FIXED12_TABLE', ['A DECIMAL(23, 5)'], 8));
1387-
after(dropTableRemoteDB('FIXED12_TABLE', 8));
1385+
before(setUpTable('FIXED12_TABLE', ['A DECIMAL(23, 5)'], 8));
1386+
after(dropTable('FIXED12_TABLE', 8));
13881387

13891388
it('should insert and return valid FIXED12 decimals', function (done) {
13901389
testDataTypeValid('FIXED12_TABLE', fixed12InsertValues, [82], fixed12Expected, done);
@@ -1398,8 +1397,8 @@ describe('db', function () {
13981397
});
13991398

14001399
describeRemoteDB('FIXED16', function () {
1401-
before(setUpTableRemoteDB('FIXED16_TABLE', ['A DECIMAL(35, 5)'], 8));
1402-
after(dropTableRemoteDB('FIXED16_TABLE', 8));
1400+
before(setUpTable('FIXED16_TABLE', ['A DECIMAL(35, 5)'], 8));
1401+
after(dropTable('FIXED16_TABLE', 8));
14031402

14041403
it('should insert and return valid FIXED16 decimals', function (done) {
14051404
testDataTypeValid('FIXED16_TABLE', fixed16InsertValues, [76], fixed16ExpectedDFV8, done);
@@ -1418,8 +1417,8 @@ describe('db', function () {
14181417
after(changeDataFormatSupport(ORGINAL_DATA_FORMAT));
14191418

14201419
describeRemoteDB('FIXED8', function () {
1421-
before(setUpTableRemoteDB('FIXED8_TABLE', ['A DECIMAL(15, 5)'], 7));
1422-
after(dropTableRemoteDB('FIXED8_TABLE', 7));
1420+
before(setUpTable('FIXED8_TABLE', ['A DECIMAL(15, 5)'], 7));
1421+
after(dropTable('FIXED8_TABLE', 7));
14231422

14241423
it('should insert and return valid FIXED8 decimals', function (done) {
14251424
testDataTypeValid('FIXED8_TABLE', fixed8InsertValues, [5], fixed8Expected, done);
@@ -1434,8 +1433,8 @@ describe('db', function () {
14341433
});
14351434

14361435
describeRemoteDB('FIXED12', function () {
1437-
before(setUpTableRemoteDB('FIXED12_TABLE', ['A DECIMAL(23, 5)'], 7));
1438-
after(dropTableRemoteDB('FIXED12_TABLE', 7));
1436+
before(setUpTable('FIXED12_TABLE', ['A DECIMAL(23, 5)'], 7));
1437+
after(dropTable('FIXED12_TABLE', 7));
14391438

14401439
it('should insert and return valid FIXED12 decimals', function (done) {
14411440
testDataTypeValid('FIXED12_TABLE', fixed12InsertValues, [5], fixed12Expected, done);
@@ -1449,8 +1448,8 @@ describe('db', function () {
14491448
});
14501449

14511450
describeRemoteDB('FIXED16', function () {
1452-
before(setUpTableRemoteDB('FIXED16_TABLE', ['A DECIMAL(35, 5)'], 7));
1453-
after(dropTableRemoteDB('FIXED16_TABLE', 7));
1451+
before(setUpTable('FIXED16_TABLE', ['A DECIMAL(35, 5)'], 7));
1452+
after(dropTable('FIXED16_TABLE', 7));
14541453

14551454
it('should insert and return valid FIXED16 decimals', function (done) {
14561455
testDataTypeValid('FIXED16_TABLE', fixed16InsertValues, [5], fixed16ExpectedDFV7, done);

0 commit comments

Comments
 (0)