Skip to content

Commit 4a0e5ad

Browse files
authored
ci: bump actions/checkout, test against Node 24, fix other issues
1 parent ecd3158 commit 4a0e5ad

4 files changed

Lines changed: 9 additions & 7 deletions

File tree

.github/workflows/nodejs.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@ jobs:
1010
fail-fast: false
1111
max-parallel: 2
1212
matrix:
13-
node: [ 20, 22 ]
13+
node: [ 20, 22, 24 ]
1414

1515
steps:
16-
- uses: actions/checkout@v4
16+
- uses: actions/checkout@v5
1717
- name: Using Node ${{ matrix.node }}
1818
uses: actions/setup-node@v4
1919
with:

src/UserscriptTools/MetaSmokeAPI.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ export class MetaSmokeAPI extends Reporter {
343343

344344
if (!token) return;
345345

346-
resolve(token.toString());
346+
resolve(token);
347347
});
348348
});
349349
}

src/UserscriptTools/Post.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ export default class Post {
312312
const flagPopup = document.querySelector('#popup-flag-post');
313313
const submit = flagPopup?.querySelector('.js-popup-submit');
314314

315-
if (!submit || !flagPopup || submit.textContent?.trim().startsWith('Retract')) return;
315+
if (!submit || !flagPopup || submit.textContent.trim().startsWith('Retract')) return;
316316

317317
// add "Send feedback to: ..." buttons
318318
appendLabelAndBoxes(submit, this);
@@ -559,7 +559,7 @@ export default class Post {
559559
private getScore(): number {
560560
const voteElement = this.element.querySelector('.js-vote-count');
561561

562-
return Number(voteElement?.textContent?.trim()) || 0;
562+
return Number(voteElement?.textContent.trim()) || 0;
563563
}
564564

565565
private getOpReputation(): number {
@@ -588,7 +588,7 @@ export default class Post {
588588
// in Flags page, authorName will be empty, but we aren't interested in it there anyways...
589589
const lastNameEl = [...this.element.querySelectorAll('.user-info .user-details a')].pop();
590590

591-
return lastNameEl?.textContent?.trim() ?? '';
591+
return lastNameEl?.textContent.trim() ?? '';
592592
}
593593

594594
private getCreationDate(): Date {

src/popover.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -524,7 +524,9 @@ function increaseTooltipWidth(menu: HTMLUListElement): void {
524524
.filter(li => li.firstElementChild?.classList.contains('s-block-link'))
525525
.map(reportLink => reportLink.nextElementSibling)
526526
.forEach(tooltip => {
527-
const textLength = tooltip?.textContent?.length;
527+
if (!tooltip) return;
528+
529+
const textLength = tooltip.textContent.length;
528530
if (!textLength) return;
529531

530532
tooltip.classList.add(

0 commit comments

Comments
 (0)