Client feedback changes#121
Merged
Merged
Conversation
imonroe
requested changes
Jun 9, 2026
imonroe
left a comment
imonroe
left a comment
Collaborator
There was a problem hiding this comment.
A few little things to check, otherwise looks good to me.
| }} | ||
| className={`border-1 w-full rounded-md shadow-sm py-2 px-3 [appearance:textfield] [&::-webkit-outer-spin-button]:appearance-none [&::-webkit-inner-spin-button]:appearance-none ${interestRateError ? "border-[var(--color-inline-error)] border-2" : ""}`} | ||
| min={0} | ||
| max={100} |
Collaborator
There was a problem hiding this comment.
Suggested change
| max={100} | |
| max={1000} |
Shouldn't this be 1000 per the spreadsheet?
Collaborator
Author
There was a problem hiding this comment.
Sorry @imonroe There was a comment in the spreadsheet: " Sorry I should have updated this feild -- In the google doc with the errors & warning states for this calcualtor we have entered a range of 0 - 1,000. That way users can't keep entering things in forever "
| }} | ||
| className={`border-1 w-full rounded-md shadow-sm py-2 px-3 [appearance:textfield] [&::-webkit-outer-spin-button]:appearance-none [&::-webkit-inner-spin-button]:appearance-none ${paymentInterestRateError ? "border-[var(--color-inline-error)] border-2" : ""}`} | ||
| min={0} | ||
| max={100} |
Collaborator
There was a problem hiding this comment.
Suggested change
| max={100} | |
| max={1000} |
| const val = Number(raw); | ||
| if (val > 1000) { | ||
| setPaymentInterestRateError( | ||
| "Annual interest rate cannot exceed 100%.", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "Annual interest rate cannot exceed 100%.", | |
| "Annual interest rate cannot exceed 1000%.", |
| min={1} | ||
| min={0} | ||
| max={1000} | ||
| step={1} |
Collaborator
There was a problem hiding this comment.
Suggested change
| step={1} | |
| step="any" |
or maybe `step={.01}
| min={1} | ||
| min={0} | ||
| max={1000} | ||
| step={1} |
Collaborator
There was a problem hiding this comment.
Suggested change
| step={1} | |
| step="any" |
or step={.01}
| role="tooltip" | ||
| className="absolute left-1/2 -translate-x-1/2 bottom-full mb-2 w-56 rounded-md bg-[var(--info-popup-background)] border-1 border-grey-border text-xs p-4 invisible group-hover:visible group-focus-within:visible opacity-0 group-hover:opacity-100 group-focus-within:opacity-100 transition-opacity pointer-events-none z-10" | ||
| > | ||
| A lump sum recieved or paid at the end of the payment |
Collaborator
There was a problem hiding this comment.
Suggested change
| A lump sum recieved or paid at the end of the payment | |
| A lump sum received or paid at the end of the payment |
imonroe
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Review By (Date)
Criticality
Review Tasks
Setup tasks and/or behavior to test
Front End Validation
Backend / Functional Validation
Code
Code security
General
Affected Projects or Products
Associated Issues and/or People
@mentionthem here)Resources