Brush Toolbox Item Appearance Behavior Inconsistent

[joshua-dean]

The "Brush Tool" Toolbox item automatically appears when the "polygon" mode is selected, however when switching to a subtask where "polygon" is the default, the toolbox item does not automatically appear.

This is problematic for subtasks with only the "polygon" annotation mode, as there is not a way to coerce the toolbox item into appearing without manually passing a toolbox configuration.

Steps to reproduce:

1. Change the single-class.html demo subtasks to the following:

let subtasks = {
    "car_detection": {
        "display_name": "Car Detection",
        "classes": [
            {
                "name": "Car",
                "color": "orange",
                "id": 10
            }
        ],
        "allowed_modes": ["bbox", "polygon", "contour"],
        "resume_from": null,
        "task_meta": null,
        "annotation_meta": null
    },
    "car_detection2": {
        "display_name": "Car Detection 2",
        "classes": [
            {
                "name": "Car",
                "color": "orange",
                "id": 10
            }
        ],
        "allowed_modes": ["polygon"],
        "resume_from": null,
        "task_meta": null,
        "annotation_meta": null
    },
};

2. Launch the demo
3. In the "Car Detection" subtask, select anything but the "polygon" mode
4. With to the "Car Detection 2" subtask
5. Observe the lack of the brush toolbox item

[joshua-dean]

Upon further experimentation, even manual passing of AllowedToolboxItem.Brush does not alleviate this issue.
The g keybind still works as intended.

Temporary workaround is adding a mode like "contour" to click on and off of to make the item appear.

[joshua-dean]

So I've confirmed adding:

if (ann_mode === "polygon") {
    BrushToolboxItem.show_brush_toolbox_item();
} else {
    BrushToolboxItem.hide_brush_toolbox_item();
}

to update_annotation_mode() in index.js does resolve the issue.

update_annotation_mode() gets called when changing the subtask, and from set_annotation_mode() - but nothing seems to call the later. ModeSelectionToolboxItem has an event listener for mode selection buttons, but doesn't call either function.

@TrevorBurgoyne @CarterSolberg should we consolidate these? If so, is the preference to keep logic in the toolbox functions in index.js or move it to toolbox.ts (or another file)?

[TrevorBurgoyne]

I don't really have a preference. Maybe better to move it toolbox, but if that's too large a lift then just adding the fix you mentioned in index.js would be great

[joshua-dean]

I started on consolidating everything, a couple of notes:

• Multi-class polygon does call BrushToolboxItem.show_brush_toolbox_item() but it doesn't render regardless (even before my changes)
• ulabel.toggle_erase_mode() and ulabel.toggled_brush_mode need an event, but only if being activated. I think we couple simplify that interface somewhat
• At some point we should probably have some automated integration tests. Open to suggestions on a framework