Skip to content

Commit 881473d

Browse files
isaacroldanclaude
andcommitted
Move include_assets-only specs to the 'bundle' lifecycle
include_assets is conceptually a bundle-time step: it copies extension assets into the bundle output and (for some specs) emits manifest.json. It has no role in producing local build artifacts. For the 5 specs whose only client step is include_assets — admin, admin_link, channel, flow_template, order_attribution_config — move the group from 'build' to 'bundle'. After this, `shopify app build` is a no-op for these extension types; they run during dev/deploy as before. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent b903a96 commit 881473d

6 files changed

Lines changed: 6 additions & 6 deletions

File tree

packages/app/src/cli/models/extensions/specifications/admin.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ const adminSpecificationSpec = createExtensionSpecification<AdminConfigType>({
4343
},
4444
clientSteps: [
4545
{
46-
lifecycle: 'build',
46+
lifecycle: 'bundle',
4747
steps: [
4848
{
4949
id: 'hosted_app_copy_files',

packages/app/src/cli/models/extensions/specifications/admin_link.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ describe('admin_link', async () => {
5252
const extension = await getTestAdminLink(tmpDir)
5353
const clientSteps = extension.specification.clientSteps!
5454
expect(clientSteps).toHaveLength(1)
55-
expect(clientSteps[0]!.lifecycle).toBe('build')
55+
expect(clientSteps[0]!.lifecycle).toBe('bundle')
5656

5757
const steps = clientSteps[0]!.steps
5858
expect(steps).toHaveLength(1)

packages/app/src/cli/models/extensions/specifications/admin_link.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const adminLinkSpec = createContractBasedModuleSpecification({
66
experience: 'extension',
77
clientSteps: [
88
{
9-
lifecycle: 'build',
9+
lifecycle: 'bundle',
1010
steps: [
1111
{
1212
id: 'include-admin-link-assets',

packages/app/src/cli/models/extensions/specifications/channel.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ const channelSpecificationSpec = createContractBasedModuleSpecification({
99
experience: 'extension',
1010
clientSteps: [
1111
{
12-
lifecycle: 'build',
12+
lifecycle: 'bundle',
1313
steps: [
1414
{
1515
id: 'copy-files',

packages/app/src/cli/models/extensions/specifications/flow_template.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ const flowTemplateSpec = createExtensionSpecification({
5151
appModuleFeatures: (_) => ['ui_preview'],
5252
clientSteps: [
5353
{
54-
lifecycle: 'build',
54+
lifecycle: 'bundle',
5555
steps: [
5656
{
5757
id: 'copy-files',

packages/app/src/cli/models/extensions/specifications/order_attribution_config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ const orderAttributionConfigSpec = createContractBasedModuleSpecification({
99
experience: 'extension',
1010
clientSteps: [
1111
{
12-
lifecycle: 'build',
12+
lifecycle: 'bundle',
1313
steps: [
1414
{
1515
id: 'copy-files',

0 commit comments

Comments
 (0)