From 04411a541e4b94c95875759d6748ecb682c83cc6 Mon Sep 17 00:00:00 2001 From: Alfonso Noriega Date: Tue, 5 May 2026 12:35:15 +0200 Subject: [PATCH] Remove unused 'Breaking change approval' job --- .github/workflows/tests-pr.yml | 13 +------------ workspace/src/major-change-check.js | 2 +- 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/.github/workflows/tests-pr.yml b/.github/workflows/tests-pr.yml index f3d96d0e50..6b8c4fc502 100644 --- a/.github/workflows/tests-pr.yml +++ b/.github/workflows/tests-pr.yml @@ -331,16 +331,5 @@ jobs: - name: Fail if breaking changes detected if: steps.check.outputs.has_breaking_changes == 'true' run: | - echo '::error::Breaking changes detected. A member of @shopify/dev_experience must approve the breaking-change-approval environment.' + echo '::error::Breaking changes detected. See the sticky comment on the PR for details.' exit 1 - - major-change-approval: - name: 'Breaking change approval' - needs: major-change-check - if: always() && needs.major-change-check.outputs.has_breaking_changes == 'true' - runs-on: ubuntu-latest - timeout-minutes: 5 - environment: breaking-change-approval - steps: - - name: Approved - run: echo '✅ Breaking changes approved by dev_experience team member' diff --git a/workspace/src/major-change-check.js b/workspace/src/major-change-check.js index a43e91030b..03000746a8 100644 --- a/workspace/src/major-change-check.js +++ b/workspace/src/major-change-check.js @@ -593,7 +593,7 @@ function buildReport({majorChangesets, manifestChanges, schemaChanges}) { This PR contains changes that may break the existing contract. -**@shopify/dev_experience** — this PR contains breaking changes that require coordination for the next major release. This check will remain failed until a member of the team approves the workflow run. +**@shopify/dev_experience** — this PR contains breaking changes that require coordination for the next major release. > 💬 Head to [#help-dev-platform](https://shopify.enterprise.slack.com/archives/C07UJ7UNMTK) to discuss timing and plan the release.