From 664c4e44e0f2e2b8bf2f436ff169f352a941696e Mon Sep 17 00:00:00 2001 From: Guilherme Carreiro Date: Wed, 15 Jul 2026 14:32:21 +0200 Subject: [PATCH] Fix warning when running theme commands in valid theme directories --- .changeset/fix-theme-directory-warning.md | 5 +++++ .../theme/src/cli/utilities/theme-fs.test.ts | 16 ++++++++++++++++ packages/theme/src/cli/utilities/theme-fs.ts | 3 +-- 3 files changed, 22 insertions(+), 2 deletions(-) create mode 100644 .changeset/fix-theme-directory-warning.md diff --git a/.changeset/fix-theme-directory-warning.md b/.changeset/fix-theme-directory-warning.md new file mode 100644 index 00000000000..9d0cb0459f2 --- /dev/null +++ b/.changeset/fix-theme-directory-warning.md @@ -0,0 +1,5 @@ +--- +'@shopify/theme': patch +--- + +Fix warning when running theme commands in valid theme directories diff --git a/packages/theme/src/cli/utilities/theme-fs.test.ts b/packages/theme/src/cli/utilities/theme-fs.test.ts index bd546d467a5..8c09df84edd 100644 --- a/packages/theme/src/cli/utilities/theme-fs.test.ts +++ b/packages/theme/src/cli/utilities/theme-fs.test.ts @@ -628,6 +628,22 @@ describe('theme-fs', () => { expect(result).toBeFalsy() }) }) + + test(`returns true for a valid theme directory`, async () => { + await inTemporaryDirectory(async (tmpDir) => { + // Given + const root = tmpDir + await mkdir(joinPath(root, 'config')) + await mkdir(joinPath(root, 'layout')) + await mkdir(joinPath(root, 'templates')) + + // When + const result = await hasRequiredThemeDirectories(root) + + // Then + expect(result).toBeTruthy() + }) + }) }) describe('listing functionality', () => { diff --git a/packages/theme/src/cli/utilities/theme-fs.ts b/packages/theme/src/cli/utilities/theme-fs.ts index 68f6f6ac22d..9692a5c9ac2 100644 --- a/packages/theme/src/cli/utilities/theme-fs.ts +++ b/packages/theme/src/cli/utilities/theme-fs.ts @@ -547,8 +547,7 @@ export async function hasRequiredThemeDirectories(path: string) { }), ) - const requiredDirectories = ['config', 'layout', 'sections', 'templates'] - + const requiredDirectories = ['config', 'layout', 'templates'] return requiredDirectories.every((dir) => directories.has(dir)) }