From 422f25cb632dd9fb6f9537084762096c1d9d22c1 Mon Sep 17 00:00:00 2001 From: Manan Date: Thu, 14 Aug 2025 14:46:41 +1200 Subject: [PATCH] Added changes for refactoring code --- src/main/java/com/gildedrose/GildedRose.java | 54 +++++++++++--------- 1 file changed, 29 insertions(+), 25 deletions(-) diff --git a/src/main/java/com/gildedrose/GildedRose.java b/src/main/java/com/gildedrose/GildedRose.java index e6feb75..8f1bc70 100644 --- a/src/main/java/com/gildedrose/GildedRose.java +++ b/src/main/java/com/gildedrose/GildedRose.java @@ -9,51 +9,55 @@ public GildedRose(Item[] items) { public void updateQuality() { for (int i = 0; i < items.length; i++) { - if (!items[i].name.equals("Aged Brie") - && !items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { - if (items[i].quality > 0) { - if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) { - items[i].quality = items[i].quality - 1; + Item item = items[i]; + boolean isAgedBrie = item.name.equals("Aged Brie"); + boolean isBackstage = item.name.equals("Backstage passes to a TAFKAL80ETC concert"); + boolean isSulfuras = item.name.equals("Sulfuras, Hand of Ragnaros"); + + if (!isAgedBrie && !isBackstage) { + if (item.quality > 0) { + if (!isSulfuras) { + item.quality = item.quality - 1; } } } else { - if (items[i].quality < 50) { - items[i].quality = items[i].quality + 1; + if (item.quality < 50) { + item.quality = item.quality + 1; - if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { - if (items[i].sellIn < 11) { - if (items[i].quality < 50) { - items[i].quality = items[i].quality + 1; + if (isBackstage) { + if (item.sellIn < 11) { + if (item.quality < 50) { + item.quality = item.quality + 1; } } - if (items[i].sellIn < 6) { - if (items[i].quality < 50) { - items[i].quality = items[i].quality + 1; + if (item.sellIn < 6) { + if (item.quality < 50) { + item.quality = item.quality + 1; } } } } } - if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) { - items[i].sellIn = items[i].sellIn - 1; + if (!isSulfuras) { + item.sellIn = item.sellIn - 1; } - if (items[i].sellIn < 0) { - if (!items[i].name.equals("Aged Brie")) { - if (!items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { - if (items[i].quality > 0) { - if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) { - items[i].quality = items[i].quality - 1; + if (item.sellIn < 0) { + if (!isAgedBrie) { + if (!isBackstage) { + if (item.quality > 0) { + if (!isSulfuras) { + item.quality = item.quality - 1; } } } else { - items[i].quality = items[i].quality - items[i].quality; + item.quality = item.quality - item.quality; } } else { - if (items[i].quality < 50) { - items[i].quality = items[i].quality + 1; + if (item.quality < 50) { + item.quality = item.quality + 1; } } }