Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion SPECS/ARCHIVE/INDEX.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
# mcpbridge-wrapper Tasks Archive

**Last Updated:** 2026-03-01 (P3-T11 archived)
**Last Updated:** 2026-03-03 (P1-T9 archived)

## Archived Tasks

| Task ID | Folder | Archived | Verdict |
|---------|--------|----------|---------|
| P1-T9 | [P1-T9_Add_direct_links_for_all_command_steps_in_FLOW/](P1-T9_Add_direct_links_for_all_command_steps_in_FLOW/) | 2026-03-03 | PASS |
| P3-T11 | [P3-T11_Add_Stop_broker_service_control_button_to_Web_UI/](P3-T11_Add_Stop_broker_service_control_button_to_Web_UI/) | 2026-03-01 | PASS |
| P1-T8 | [P1-T8_Update_config_examples_for_broker_setup_first/](P1-T8_Update_config_examples_for_broker_setup_first/) | 2026-03-01 | PASS |
| P2-T6 | [P2-T6_Remove_legacy_broker_connect_and_broker_spawn_flags/](P2-T6_Remove_legacy_broker_connect_and_broker_spawn_flags/) | 2026-03-01 | PASS |
Expand Down Expand Up @@ -182,6 +183,7 @@

| File | Description |
|------|-------------|
| [REVIEW_p1_t9_flow_command_links.md](_Historical/REVIEW_p1_t9_flow_command_links.md) | Review report for P1-T9 |
| [REVIEW_p3_t11_webui_stop_control.md](_Historical/REVIEW_p3_t11_webui_stop_control.md) | Review report for P3-T11 |
| [REVIEW_p1_t8_config_broker_setup_first.md](_Historical/REVIEW_p1_t8_config_broker_setup_first.md) | Review report for P1-T8 |
| [REVIEW_P2-T5_webui_mismatch_warning.md](_Historical/REVIEW_P2-T5_webui_mismatch_warning.md) | Review report for P2-T5 |
Expand Down Expand Up @@ -309,6 +311,8 @@

| Date | Task ID | Action |
|------|---------|--------|
| 2026-03-03 | P1-T9 | Archived REVIEW_p1_t9_flow_command_links report |
| 2026-03-03 | P1-T9 | Archived Add direct links for all command steps in FLOW.md (PASS) |
| 2026-03-01 | P1-T8 | Archived REVIEW_p1_t8_config_broker_setup_first report |
| 2026-03-01 | P1-T8 | Archived Update /config examples for broker setup first (PASS) |
| 2026-03-01 | P2-T6 | Archived REVIEW_p2_t6_remove_legacy_broker_flags report |
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
# P1-T9 - Add direct links for all command steps in FLOW.md

**Task ID:** P1-T9
**Priority:** P2
**Dependencies:** none
**Status:** Planned

## Goal

Make `SPECS/COMMANDS/FLOW.md` directly navigable by adding explicit links to every command-backed step in the workflow.

## Problem Statement

`SPECS/COMMANDS/FLOW.md` describes the workflow sequence and names commands such as PLAN, EXECUTE, ARCHIVE, REVIEW, and FOLLOW-UP, but navigation is inconsistent because some steps are not directly linked to their command documents from the step sections. This slows task execution and increases the chance of missing step-specific guidance.

## Deliverables

- `SPECS/COMMANDS/FLOW.md`
- Add direct links for command-backed steps in the step sections.
- Ensure PLAN step links to `PLAN.md` directly.
- Keep wording and quick reference consistent with the linked step names.

## Acceptance Criteria

- Each command-backed step section in `SPECS/COMMANDS/FLOW.md` includes a direct markdown link to its command file.
- PLAN step includes a direct link to `PLAN.md`.
- Existing links remain valid after edits.
- Required quality gates pass:
- `pytest`
- `ruff check src/`
- `mypy src/`
- `pytest --cov` (>=90%)

## Implementation Notes

- Use repository-relative links matching neighboring command docs (for example, `PLAN.md`, `EXECUTE.md`, `ARCHIVE.md`, `REVIEW.md`, `PRIMITIVES/FOLLOW_UP.md`).
- Keep the workflow sequence and commit message patterns unchanged.
- Avoid broad formatting churn in `FLOW.md`; keep this task focused on link coverage and clarity.

## Validation Plan

1. Inspect `SPECS/COMMANDS/FLOW.md` to confirm direct links exist for each command-backed step.
2. Run required quality gates.
3. Create `SPECS/INPROGRESS/P1-T9_Validation_Report.md` with command outcomes and final verdict.

## Risks

- Over-editing wording could accidentally drift from established FLOW semantics.

## Out of Scope

- Changing workflow order or commit message patterns.
- Editing command-specific behavior in files other than `SPECS/COMMANDS/FLOW.md`.
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
# Validation Report: P1-T9 — Add direct links for all command steps in FLOW.md

**Date:** 2026-03-03
**Verdict:** PASS

## Summary

Updated `SPECS/COMMANDS/FLOW.md` so command-backed workflow steps now include direct links to their corresponding command documents, including PLAN.

## Delivered Changes

- Updated workflow command link coverage in:
- `SPECS/COMMANDS/FLOW.md`
- Added direct command link list in the Overview section.
- Converted command-backed step headings to direct links (`SELECT`, `PLAN`, `EXECUTE`, `ARCHIVE`, `REVIEW`, `FOLLOW-UP`).
- Updated Quick Reference step names to use direct links for command-backed steps.

## Acceptance Criteria Check

- [x] Each command-backed step section in `SPECS/COMMANDS/FLOW.md` includes a direct markdown link to its command file.
- [x] PLAN step includes a direct link to `PLAN.md`.
- [x] Existing links remain valid after edits.
- [x] Required quality gates pass: `pytest`, `ruff check src/`, `mypy src/`, `pytest --cov` (>=90%).

## Quality Gates

1. `pytest`
- Result: PASS
- Evidence: `741 passed, 5 skipped, 2 warnings in 7.83s`

2. `ruff check src/`
- Result: PASS
- Evidence: `All checks passed!`

3. `mypy src/`
- Result: PASS
- Evidence: `Success: no issues found in 18 source files`

4. `pytest --cov`
- Result: PASS
- Evidence: `Required test coverage of 90.0% reached. Total coverage: 91.03%`

## Link Verification

Direct link targets present in `SPECS/COMMANDS/FLOW.md`:
- `SELECT.md`
- `PLAN.md`
- `EXECUTE.md`
- `ARCHIVE.md`
- `REVIEW.md`
- `PRIMITIVES/FOLLOW_UP.md`

## Notes

- Changes are documentation-only for FLOW navigation and do not modify runtime behavior.
34 changes: 34 additions & 0 deletions SPECS/ARCHIVE/_Historical/REVIEW_p1_t9_flow_command_links.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
## REVIEW REPORT — P1-T9 FLOW command links

**Scope:** origin/main..HEAD
**Files:** 6

### Summary Verdict
- [x] Approve
- [ ] Approve with comments
- [ ] Request changes
- [ ] Block

### Critical Issues

- None.

### Secondary Issues

- None.

### Architectural Notes

- `SPECS/COMMANDS/FLOW.md` now consistently exposes direct navigation to command-backed step docs, reducing operator friction during manual FLOW execution.
- Quick Reference step links now mirror step-section links, improving discoverability without changing workflow semantics.

### Tests

- `pytest` passed (`741 passed, 5 skipped`).
- `ruff check src/` passed.
- `mypy src/` passed.
- `pytest --cov` passed with `91.03%` total coverage (>=90% threshold).

### Next Steps

- No actionable findings; FOLLOW-UP is skipped.
26 changes: 14 additions & 12 deletions SPECS/COMMANDS/FLOW.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ BRANCH → SELECT → PLAN → EXECUTE → ARCHIVE → REVIEW → FOLLOW-UP →
COMMIT COMMIT COMMIT COMMIT COMMIT COMMIT COMMIT COMMIT
```

Direct command links used by this workflow: [`SELECT`](SELECT.md), [`PLAN`](PLAN.md), [`EXECUTE`](EXECUTE.md), [`ARCHIVE`](ARCHIVE.md), [`REVIEW`](REVIEW.md), [`FOLLOW_UP`](PRIMITIVES/FOLLOW_UP.md).

---

## Changelog
Expand All @@ -38,7 +40,7 @@ Branch for {TASK_ID}: {short description}

---

### 2. SELECT
### 2. [`SELECT`](SELECT.md)

Choose the next task from the workplan.

Expand All @@ -55,7 +57,7 @@ Select task {TASK_ID}: {TASK_NAME}

---

### 3. PLAN
### 3. [`PLAN`](PLAN.md)

Create the task PRD following documentation rules.

Expand All @@ -70,7 +72,7 @@ Plan task {TASK_ID}: {TASK_NAME}

---

### 4. EXECUTE
### 4. [`EXECUTE`](EXECUTE.md)

Implement the task per the PRD.

Expand All @@ -94,7 +96,7 @@ Implement {TASK_ID}: {brief description of changes}

---

### 5. ARCHIVE
### 5. [`ARCHIVE`](ARCHIVE.md)

Move completed task to archive (run periodically or at milestones).

Expand All @@ -111,7 +113,7 @@ Archive task {TASK_ID}: {TASK_NAME} ({VERDICT})

---

### 6. REVIEW
### 6. [`REVIEW`](REVIEW.md)

Run a structured review after archiving to capture findings and follow-ups.

Expand All @@ -126,7 +128,7 @@ Review {TASK_ID}: {short subject}

---

### 7. FOLLOW-UP
### 7. [`FOLLOW-UP`](PRIMITIVES/FOLLOW_UP.md)

Create subtasks for issues discovered during review.

Expand Down Expand Up @@ -163,12 +165,12 @@ Archive REVIEW_{subject} report
| Step | Output | Commit Message Pattern |
|------|--------|------------------------|
| BRANCH | Feature branch created | `Branch for {TASK_ID}: {short description}` |
| SELECT | `next.md` updated | `Select task {TASK_ID}: {TASK_NAME}` |
| PLAN | `{TASK_ID}_{TASK_NAME}.md` created | `Plan task {TASK_ID}: {TASK_NAME}` |
| EXECUTE | Code + validation report | `Implement {TASK_ID}: {DESCRIPTION}` |
| ARCHIVE | Task in archive folder + workplan updated | `Archive task {TASK_ID}: {TASK_NAME} ({VERDICT})` |
| REVIEW | `REVIEW_{subject}.md` created | `Review {TASK_ID}: {SUBJECT}` |
| FOLLOW-UP | New tasks in workplan | `Follow-up {TASK_ID}: {SUBJECT}` |
| [`SELECT`](SELECT.md) | `next.md` updated | `Select task {TASK_ID}: {TASK_NAME}` |
| [`PLAN`](PLAN.md) | `{TASK_ID}_{TASK_NAME}.md` created | `Plan task {TASK_ID}: {TASK_NAME}` |
| [`EXECUTE`](EXECUTE.md) | Code + validation report | `Implement {TASK_ID}: {DESCRIPTION}` |
| [`ARCHIVE`](ARCHIVE.md) | Task in archive folder + workplan updated | `Archive task {TASK_ID}: {TASK_NAME} ({VERDICT})` |
| [`REVIEW`](REVIEW.md) | `REVIEW_{subject}.md` created | `Review {TASK_ID}: {SUBJECT}` |
| [`FOLLOW-UP`](PRIMITIVES/FOLLOW_UP.md) | New tasks in workplan | `Follow-up {TASK_ID}: {SUBJECT}` |
| ARCHIVE-REVIEW | Review report archived | `Archive REVIEW_{subject} report` |

## Extensions
Expand Down
4 changes: 2 additions & 2 deletions SPECS/INPROGRESS/next.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
# No Active Task

**Status:** Idle — P3-T11 archived. Select the next task from `SPECS/Workplan.md`.
**Status:** Idle — P1-T9 archived. Select the next task from `SPECS/Workplan.md`.

## Recently Archived

- **P1-T9** — Add direct links for all command steps in FLOW.md (2026-03-03, PASS)
- **P3-T11** — Add Stop broker/service control button to Web UI (2026-03-01, PASS)
- **P1-T8** — Update /config examples for broker setup first (2026-03-01, PASS)
- **P2-T6** — Remove legacy --broker-connect and --broker-spawn flags (2026-03-01, PASS)
- **P1-T7** — Hide README version badge maintenance note (2026-03-01, PASS)
- **P1-T4** — Update docs to reflect broker robustness improvements (2026-03-01, PASS)
- **P2-T5** — Warn or restart daemon when --web-ui requested but running broker lacks it (2026-03-01, PASS)
- **P2-T4** — Surface broker unavailability as JSON-RPC error instead of silent timeout (2026-03-01, PASS)
- **P2-T3** — Fix double-spawn race condition when MCP client toggles rapidly (2026-03-01, PASS)
14 changes: 14 additions & 0 deletions SPECS/Workplan.md
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,20 @@ Add new tasks using the canonical template in [TASK_TEMPLATE.md](TASK_TEMPLATE.m
- [x] Claude Code and Codex CLI config templates present a broker command first
- [x] Broker-first guidance is consistent with existing `*-broker` templates and `--broker` usage

#### ✅ P1-T9: Add direct links for all command steps in FLOW.md
- **Status:** ✅ Completed (2026-03-03)
- **Description:** `SPECS/COMMANDS/FLOW.md` now includes direct links for command-backed steps in both the step sections and quick-reference coverage, including a direct PLAN link.
- **Priority:** P2
- **Dependencies:** none
- **Parallelizable:** yes
- **Outputs/Artifacts:**
- `SPECS/COMMANDS/FLOW.md` updated with direct links for command-backed workflow steps
- `SPECS/ARCHIVE/P1-T9_Add_direct_links_for_all_command_steps_in_FLOW/` archived task artifacts
- **Acceptance Criteria:**
- [x] `SPECS/COMMANDS/FLOW.md` includes direct links for command-backed steps, including PLAN (`PLAN.md`)
- [x] Any summary or quick-reference text in `SPECS/COMMANDS/FLOW.md` remains consistent with the linked-step wording
- [x] All links resolve correctly within `SPECS/COMMANDS/`

### Phase 2: Broker Robustness

#### ✅ P2-T1: Replace --broker-spawn/--broker-connect with single --broker flag
Expand Down