No clients detected yet.
';
+ return;
+ }
+
+ container.innerHTML = clients.map(function (client) {
+ var name = client.name || "unknown";
+ var version = client.version || "unknown";
+ var count = client.initialize_count || 0;
+ var lastSeen = formatRelativeAge(client.last_seen);
+ return "
-
Active Client
-
--
+
+
+
diff --git a/tests/unit/webui/test_metrics.py b/tests/unit/webui/test_metrics.py
index 9a96d260..ac7b5fc4 100644
--- a/tests/unit/webui/test_metrics.py
+++ b/tests/unit/webui/test_metrics.py
@@ -209,6 +209,7 @@ def test_initial_client_info_unknown(self):
summary = metrics.get_summary()
assert summary["client_name"] == "unknown"
assert summary["client_version"] == "unknown"
+ assert summary["clients"] == []
def test_set_client_info(self):
"""Test setting client info is reflected in summary."""
@@ -217,15 +218,29 @@ def test_set_client_info(self):
summary = metrics.get_summary()
assert summary["client_name"] == "Cursor"
assert summary["client_version"] == "1.2.3"
+ assert len(summary["clients"]) == 1
+ assert summary["clients"][0]["name"] == "Cursor"
+ assert summary["clients"][0]["version"] == "1.2.3"
+ assert summary["clients"][0]["initialize_count"] == 1
def test_set_client_info_overwrite(self):
- """Test that set_client_info overwrites previous values."""
+ """Test that latest client remains current while history is preserved."""
metrics = MetricsCollector()
metrics.set_client_info("Cursor", "1.0.0")
metrics.set_client_info("Claude", "2.0.0")
summary = metrics.get_summary()
assert summary["client_name"] == "Claude"
assert summary["client_version"] == "2.0.0"
+ assert len(summary["clients"]) == 2
+
+ def test_set_client_info_increments_initialize_count(self):
+ """Repeated initialize handshakes for same client increment count."""
+ metrics = MetricsCollector()
+ metrics.set_client_info("Cursor", "1.2.3")
+ metrics.set_client_info("Cursor", "1.2.3")
+ summary = metrics.get_summary()
+ assert len(summary["clients"]) == 1
+ assert summary["clients"][0]["initialize_count"] == 2
def test_reset_clears_client_info(self):
"""Test that reset() clears client info back to 'unknown'."""
@@ -235,6 +250,7 @@ def test_reset_clears_client_info(self):
summary = metrics.get_summary()
assert summary["client_name"] == "unknown"
assert summary["client_version"] == "unknown"
+ assert summary["clients"] == []
def test_error_counts_by_code_in_summary(self):
"""Test that error_counts_by_code appears in summary."""
diff --git a/tests/unit/webui/test_server.py b/tests/unit/webui/test_server.py
index a2b135ab..b327f053 100644
--- a/tests/unit/webui/test_server.py
+++ b/tests/unit/webui/test_server.py
@@ -58,6 +58,18 @@ def test_get_metrics(self, client, metrics):
data = response.json()
assert data["total_requests"] == 1
assert data["tool_counts"]["XcodeRead"] == 1
+ assert "clients" in data
+
+ def test_get_metrics_includes_multi_client_summary(self, client, metrics):
+ """Metrics response includes all seen clients for dashboard widgets."""
+ metrics.set_client_info("Cursor", "1.0.0")
+ metrics.set_client_info("Claude", "2.0.0")
+ response = client.get("/api/metrics")
+ assert response.status_code == 200
+ data = response.json()
+ assert len(data["clients"]) == 2
+ names = {entry["name"] for entry in data["clients"]}
+ assert names == {"Cursor", "Claude"}
def test_get_timeseries(self, client, metrics):
"""Test getting timeseries data."""
diff --git a/tests/unit/webui/test_shared_metrics.py b/tests/unit/webui/test_shared_metrics.py
index b66e743d..6c53b003 100644
--- a/tests/unit/webui/test_shared_metrics.py
+++ b/tests/unit/webui/test_shared_metrics.py
@@ -190,6 +190,7 @@ def test_initial_client_info_unknown(self, store):
summary = store.get_summary()
assert summary["client_name"] == "unknown"
assert summary["client_version"] == "unknown"
+ assert summary["clients"] == []
def test_set_client_info(self, store):
"""Test that set_client_info stores and retrieves client identity."""
@@ -197,14 +198,27 @@ def test_set_client_info(self, store):
summary = store.get_summary()
assert summary["client_name"] == "Cursor"
assert summary["client_version"] == "1.2.3"
+ assert len(summary["clients"]) == 1
+ assert summary["clients"][0]["name"] == "Cursor"
+ assert summary["clients"][0]["version"] == "1.2.3"
+ assert summary["clients"][0]["initialize_count"] == 1
def test_set_client_info_upsert(self, store):
- """Test that set_client_info upserts (overwrites) on repeated calls."""
+ """Test latest-client overwrite while retaining multi-client history."""
store.set_client_info("Cursor", "1.0.0")
store.set_client_info("Claude", "3.5.0")
summary = store.get_summary()
assert summary["client_name"] == "Claude"
assert summary["client_version"] == "3.5.0"
+ assert len(summary["clients"]) == 2
+
+ def test_set_client_info_same_client_increments_count(self, store):
+ """Repeated initialize from same client increments initialize_count."""
+ store.set_client_info("Cursor", "1.0.0")
+ store.set_client_info("Cursor", "1.0.0")
+ summary = store.get_summary()
+ assert len(summary["clients"]) == 1
+ assert summary["clients"][0]["initialize_count"] == 2
def test_reset_clears_client_info(self, store):
"""Test that reset() clears client info back to 'unknown'."""
@@ -213,6 +227,7 @@ def test_reset_clears_client_info(self, store):
summary = store.get_summary()
assert summary["client_name"] == "unknown"
assert summary["client_version"] == "unknown"
+ assert summary["clients"] == []
def test_error_counts_by_code_empty_by_default(self, store):
"""Test that error_counts_by_code is empty when no errors recorded."""