Gravity gets reset after using a ladder.

[JayCroghan]

When using a custom gravity for a player/zombie class, if the player/zombie uses a ladder it resets their gravity again. I will play with fixing this myself but other than checking OnTick for (wereOnLadder & !isOnLadder) and resetting gravity i'm a bit stumped so far.

[Vauff]

Related https://github.com/xen-000/FixPlayerGravity

[JayCroghan]

The proper thing to do would be hook CGameMovement::LadderMove() - during the hook call the original method with SH_CALL and if m_MoveType was MOVETYPE_LADDER before SH_CALL and the new movetype is anything else then they have left the ladder and I need to reset their gravity to their class gravity.

The problem is getting CBasePlayer from CGameMovement META_IFACEPTR. I am just too new at the moment.

...

Either that or hook SetGravityScale and stop it from being reset.

[JayCroghan]

Related https://github.com/xen-000/FixPlayerGravity

Ohhhh he did what I was trying to avoid, add a full loop of players to every gameframe :(

[Vauff]

Ohhhh he did what I was trying to avoid, add a full loop of players to every gameframe :(

Pretty sure we reached the conclusion at the time that there was no clean ladder mount/unmount function that could be hooked in CS:GO, though it's been a few years. Might also be different in Source 2.

[JayCroghan]

Ohhhh he did what I was trying to avoid, add a full loop of players to every gameframe :(

Pretty sure we reached the conclusion at the time that there was no clean ladder mount/unmount function that could be hooked in CS:GO, though it's been a few years. Might also be different in Source 2.

Unfortunately, it is very different in CS2. In previous versions, there was literally an ExitLadder() virtual method on the player. That method still exists in the binary but is not called at all. What I described above is probably the cleanest way to know whether they have left the ladder in CS2.

I've just implemented what is in that plugin above about to run it and see.

[JayCroghan]

It works perfectly. My only problem is the code path I'm using to reset gravity is not great, because I want it to use the gravity in the zombie class. I thought the path of least resistance might be best. Check it out.

These were only called when I left a ladder, and they did reset my gravity.

I'll do a PR and you can look at what I did to see how horrific it is.

[JayCroghan]

JayCroghan@3325a87

It's not pretty - I didn't want to disturb the original CS2Fixes ZR code too much or change the ordering that things are applied to the player (as I've noticed sometimes this actually matters a lot) so I tried to leave as much intact as I could.

[JayCroghan]

@Vauff I hated how horrible the original push was, so I undid it entirely and wrote it fresh and more in line with how CS2Fixes works. Ignore the ZM bits. want me to do a clean PR for CSFixes with this? Store the gravity on each ZEPlayer when setting it, then loop every GameFrame, check if they just left the ladder, and if so, set the gravity.

JayCroghan@106f6f1

[Vauff]

@Vauff I hated how horrible the original push was, so I undid it entirely and wrote it fresh and more in line with how CS2Fixes works. Ignore the ZM bits. want me to do a clean PR for CSFixes with this? Store the gravity on each ZEPlayer when setting it, then loop every GameFrame, check if they just left the ladder, and if so, set the gravity.

JayCroghan@106f6f1

This bug fix is applicable to more than just ZR, as maps can also change gravity themselves, so I'd try to make it a more generic implementation like the CS:GO plugin. You can also just replace g_pOnLadder with a field in ZEPlayer.

[JayCroghan]

@Vauff I hated how horrible the original push was, so I undid it entirely and wrote it fresh and more in line with how CS2Fixes works. Ignore the ZM bits. want me to do a clean PR for CSFixes with this? Store the gravity on each ZEPlayer when setting it, then loop every GameFrame, check if they just left the ladder, and if so, set the gravity.
JayCroghan@106f6f1

This bug fix is applicable to more than just ZR, as maps can also change gravity themselves, so I'd try to make it a more generic implementation like the CS:GO plugin. You can also just replace g_pOnLadder with a field in ZEPlayer.

The only reason I didn't at first is that plugin isn't using GravityScale it's using SetEntityGravity which I assume is the not the same at all, so I do not think the same applies, i.e. Class.flGravity * sv_gravity - what do you suggest in this case? Am I wrong and actually doing our class gravity times sv_gravity is correct in this instance??

[Vauff]

The only reason I didn't at first is that plugin isn't using GravityScale it's using SetEntityGravity which I assume is the not the same at all, so I do not think the same applies, i.e. Class.flGravity * sv_gravity - what do you suggest in this case? Am I wrong and actually doing our class gravity times sv_gravity is correct in this instance??

Gravity scale & entity gravity are the same yes, they're a simple multiplier on world gravity for the entity. You don't need to worry about sv_gravity here since the engine handles that aspect. The only reason it's used in that linked plugin is because it's fixing two separate bugs (not only ladder gravity reset, but missing clientside gravity prediction). In CS2, entity gravity prediction mostly works, so that part is no longer needed.

[JayCroghan]

Ah so then you mean figuring out a signature for getting entity gravity to be able to know if a map changes it? Wt the moment cs2fixes only has a Set signature and it’s not virtual :(

[Vauff]

Ah so then you mean figuring out a signature for getting entity gravity to be able to know if a map changes it? Wt the moment cs2fixes only has a Set signature and it’s not virtual :(

You can just check it through the m_flGravityScale schema field.

[JayCroghan]

Ah so then you mean figuring out a signature for getting entity gravity to be able to know if a map changes it? Wt the moment cs2fixes only has a Set signature and it’s not virtual :(

You can just check it through the m_flGravityScale schema field.

Not gonna ask why you don’t just set that I’m sure there’s a reason. Check the PR. I wonder is it worth doing the check every say, 4 frames, instead of every single frame though. It’s not like you go from ladder to surface in a single frame.