Add allmazz/decky-desktop-apps#1029
Conversation
Issues FoundNo issues with your PR description were found. Next Steps
Thank you for your contribution! If you need any help, please reach out on our Discord server. ❤️ |
|
Code LGTM, just have before we approve this Question: I know in your previous PR you said you didn't have access to SteamOS to test it on, did you or someone you know test this plugin on SteamOS and it all worked And then also, you will need to update your plugin's license to include the BSD-3 license that the plugin template uses |
|
About SteamOS: yes, I have no clear SteamOS and asked for help on the Discord server. |
You can append the BSD license at the bottom of your existing GPL one as they are compatible, it just needs to be included. Even if you didn't directly fork the template repo, we still would like it to be there as it is essentially impossible to have created a plugin without having in some way used code or knowledge derived from the template. |
Good idea. Could you check, did I done it right? |
EMERALD0874
left a comment
There was a problem hiding this comment.
License LGTM. However, I disagree with adding a plugin titled "Apps" to the store, as this is overly generic and could confuse users (e.g., this could be confused as an app store, a way to run mobile apps, or a bundle of apps). Something like "App Launcher" would add more clarity. Is that fine?
Apps is simple and straightforward title, no need to make it longer. Menus like this are typically named exactly like this in different interfaces. Since there is a description and screenshot in the store, I think it's fine to go with Apps. If we could set the store name and the UI button title independently, I’d agree that “Apps Launcher” or “Apps Menu” would be clearer and worth switching to. |
The difference is your plugin is not a feature of Decky Loader, SteamOS, or any other part of the Steam Deck. It's an independent plugin and should likely be titled as such. I'll bring this to the Decky team and let you know what we decide. |
|
Gonna agree with Emerald here. I would also propose the name "App Launcher" or alternatively, "App Menu", "App Manager", these all make it much more clear that the plugin inside of Decky controls apps outside of it. |
|
i agree with beebles on this |
There was a problem hiding this comment.
Considering that three of the five people (missing TrainDoctor and RodoMa92) who typically review or have opinions on plugins have expressed the same view, I'm considering it the opinion of the team that the plugin name needs to change to be more descriptive.
Please update your plugin title per the previous guidance. You can do this by changing the name in definePlugin in index.tsx and your plugin.json. Some names you and members of the team have proposed that would be acceptable:
- App(s) Launcher
- App(s) Manager
- App(s) Menu
- App(s) Shortcut(s)
- allmazzApps (or other developer name-based title)
Please let me know if you have any questions.
|
Desktop Apps? |
|
That should be clear enough! |
|
renamed to Desktop Apps |
|
This pull request is stale as no updates or testing reports have been posted within the last 7 days. Please ensure you are actively recruiting testers or resolving the issues discussed. If you do not remove the stale label or comment, this will be closed in 7 days. Please close this pull request if you need more time to resolve issues so we can keep our repo healthy. |
|
This pull request is stale as no updates or testing reports have been posted within the last 7 days. Please ensure you are actively recruiting testers or resolving the issues discussed. If you do not remove the stale label or comment, this will be closed in 7 days. Please close this pull request if you need more time to resolve issues so we can keep our repo healthy. |
|
There is no issues and I'm only waiting for a test report. Do not close it. |
Plugin Testing ReportInstalled Plugins
Specifications
IssuesHas the following major blocking issue(s): None SummaryWorks as advertised, no issues at all. |
|
You have merge conflicts preventing us from merging this, we'll need you to rebase onto main |
done |
Add Desktop Apps to Plugin Store
Run your desktop apps from game mode without switching to desktop.
Read more.
There is similar plugin named Quick Launch, but it does not support one-shot runs without adding persistent shortcut and have less convenient interface(in my opinion). I tried to make Apps as simple as possible with must-have features.
Task Checklist
Developer
Plugin
Backend
Community
Testing