Terraform module's lack of compatibility

[gleidin]

Hi Folks,

I was trying to use this repository as a terraform module instead of copying all files into my terraform project, and I have seen that is not possible to do, is it designed to work only with all files? It would be better to be a module instead of being a terraform generic module, not?

The error threw was:

The way that i'm referencing it:

module "sumologic_observability_solution" {
  source = "github.com/SumoLogic/sumologic-solution-templates//aws-observability-terraform"
  aws_account_alias         = local.account_name
  sumologic_environment     = local.sumologic_environment
  sumologic_organization_id = local.sumologic_organization_id
  sumologic_access_id       = var.sumologic_access_id
  sumologic_access_key      = var.sumologic_access_key
}

[gleidin]

Update: I found the problem, and ain't because of the module's lack of compatibility, it's a reference that breaks the code plan/init.

Inside of the aws-observability-terraform/main.tf line 20 we have the wrong module reference to cwd instead of point to the module ref, so I changed
json_file_directory_path = dirname(path.cwd) to json_file_directory_path = dirname(path.module) and works well.

I'm using the terraform version: Terraform v1.0.11 should this module support this version? 

Update: When using as a module as I first posted, we need to remove the dirname func and works fine either.

[gleidin]

If necessary i can open a pr to fix it, I'm looking forward to using this module in production! Thanks.

[himanshu219]

Currently it doesn't support module as a whole because the app json(https://github.com/SumoLogic/sumologic-solution-templates/tree/master/aws-observability/json) folder is in the CF solution and is referred by both tf and cf solution.

[gleidin]

Yeap, I have seen that, and there is a bunch of other things that make it complicated, but should we have it? I mean, having this repository would be great and less complicated to apply and handle the state, if it was a module.