Enforce dev-runtime boundaries and isolate mock seed test code - PR_26158_039-dev-runtime-boundary-enforcement

Author: ToolboxAid

docs_build/dev/reports/coverage_changed_js_guardrail.txt

@@ -6,17 +6,24 @@ Missing changed runtime JS files are WARN, not FAIL.
 Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
-(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) src/dev-runtime/guest-seeds/palette-source-mock-db.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) src/dev-runtime/guest-seeds/tool-state-samples.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) src/dev-runtime/persistence/tool-repositories/game-configuration-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) src/dev-runtime/persistence/tool-repositories/game-design-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) src/dev-runtime/persistence/tool-repositories/palette-workspace-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) src/dev-runtime/persistence/tool-repositories/project-journey-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) src/dev-runtime/persistence/tool-repositories/project-workspace-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) toolbox/assets/assets-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) toolbox/colors/palette-workspace-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) toolbox/project-journey/project-journey-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(80%) src/engine/api/mock-db-api-client.js - executed lines 19/19; executed functions 4/5
-(87%) src/engine/api/mock-db-viewer-ui.js - executed lines 517/517; executed functions 85/98
+(60%) src/engine/api/mock-db-api-client.js - executed lines 19/19; executed functions 3/5
 
 Guardrail warnings:
-(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file missing from coverage; advisory only
+(0%) src/dev-runtime/guest-seeds/palette-source-mock-db.js - WARNING: changed runtime JS file missing from coverage; advisory only
+(0%) src/dev-runtime/guest-seeds/tool-state-samples.js - WARNING: changed runtime JS file missing from coverage; advisory only
+(0%) src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only
+(0%) src/dev-runtime/persistence/tool-repositories/game-configuration-mock-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only
+(0%) src/dev-runtime/persistence/tool-repositories/game-design-mock-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only
+(0%) src/dev-runtime/persistence/tool-repositories/palette-workspace-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only
+(0%) src/dev-runtime/persistence/tool-repositories/project-journey-mock-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only
+(0%) src/dev-runtime/persistence/tool-repositories/project-workspace-mock-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only
 (0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file missing from coverage; advisory only
-(0%) toolbox/assets/assets-mock-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only
-(0%) toolbox/colors/palette-workspace-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only
-(0%) toolbox/project-journey/project-journey-mock-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only

docs_build/dev/reports/dev-runtime-audit.md

@@ -0,0 +1,67 @@
+# Dev Runtime Audit
+
+## Scope
+
+PR_26158_039 audited active mock, seed, guest, fixture, demo, dev-only, and local-only runtime code that could be imported by browser/tool surfaces or packaged into non-local deployments.
+
+The audit focused on:
+
+- Active browser/tool roots: `account`, `admin`, `assets`, `toolbox`, `src/engine`, and `src/shared`
+- Dev-runtime persistence and seed ownership
+- Local Mem/Local DB seed and reseed paths
+- Mock repository file placement
+- UAT/PROD import boundary candidates
+
+## Files Moved Into `src/dev-runtime`
+
+| Previous Path | New Path | Status |
+| --- | --- | --- |
+| `toolbox/assets/assets-mock-repository.js` | `src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js` | PASS |
+| `toolbox/colors/palette-workspace-repository.js` | `src/dev-runtime/persistence/tool-repositories/palette-workspace-repository.js` | PASS |
+| `toolbox/colors/palette-source-mock-db.js` | `src/dev-runtime/guest-seeds/palette-source-mock-db.js` | PASS |
+| `toolbox/game-configuration/game-configuration-mock-repository.js` | `src/dev-runtime/persistence/tool-repositories/game-configuration-mock-repository.js` | PASS |
+| `toolbox/game-design/game-design-mock-repository.js` | `src/dev-runtime/persistence/tool-repositories/game-design-mock-repository.js` | PASS |
+| `toolbox/project-journey/project-journey-mock-repository.js` | `src/dev-runtime/persistence/tool-repositories/project-journey-mock-repository.js` | PASS |
+| `toolbox/project-workspace/project-workspace-mock-repository.js` | `src/dev-runtime/persistence/tool-repositories/project-workspace-mock-repository.js` | PASS |
+
+## New Dev-Runtime Seed Ownership
+
+| Area | File | Status |
+| --- | --- | --- |
+| Palette source seed rows | `src/dev-runtime/guest-seeds/palette-source-mock-db.js` | PASS |
+| Local Mem guest/user tool-state sample seed rows | `src/dev-runtime/guest-seeds/tool-state-samples.js` | PASS |
+| Local Mem/Local DB persistence and reseed store | `src/dev-runtime/persistence/mock-db-store.js` | PRESERVED |
+| SQLite Local DB adapter | `src/dev-runtime/persistence/local-db-adapter.mjs` | PRESERVED |
+
+## Import Boundary Results
+
+| Check | Evidence | Result |
+| --- | --- | --- |
+| Active browser/tool roots do not import `src/dev-runtime`. | `rg` over `account admin assets toolbox src`, excluding `src/dev-runtime`, returned no matches. | PASS |
+| Active browser/tool roots do not import moved mock repositories. | `rg` for mock repository imports outside `src/dev-runtime` returned no matches. | PASS |
+| Server router imports moved repositories only through dev-runtime paths. | `src/dev-runtime/server/mock-api-router.mjs` imports from `../persistence/tool-repositories/*`. | PASS |
+| Tests may import dev-runtime repositories for direct validation. | Repository-focused Playwright specs import from `src/dev-runtime/persistence/tool-repositories/*`. | PASS |
+| Retired toolbox mock repository files are absent. | `tests/dev-runtime/DevRuntimeBoundary.test.mjs` asserts old toolbox paths do not exist. | PASS |
+| UAT/PROD candidate browser surfaces do not import dev-runtime. | `DevRuntimeBoundary.test.mjs` scans `account`, `admin`, `assets`, `src/engine`, `src/shared`, and `toolbox`. | PASS |
+
+## Remaining Allowed Dev-Runtime Areas
+
+| Path | Purpose | Audit Result |
+| --- | --- | --- |
+| `src/dev-runtime/auth/` | Local login/session implementation behind gateways. | ALLOWED |
+| `src/dev-runtime/persistence/` | Local Mem/Local DB persistence, mock repositories, SQLite adapter. | ALLOWED |
+| `src/dev-runtime/admin/` | Local admin DB Viewer implementation behind route shell. | ALLOWED |
+| `src/dev-runtime/testing/` | Dev-runtime test support. | ALLOWED |
+| `src/dev-runtime/guest-seeds/` | Guest and local seed data. | ALLOWED |
+| `src/dev-runtime/server/` | Local API server boundary. | ALLOWED as API boundary, not browser data ownership |
+
+## Remaining Violations
+
+None found.
+
+## Notes
+
+- The static audit intentionally excludes `archive/v1-v2`, `docs_build/dev`, and `tmp`.
+- Test files under `tests/**` import dev-runtime modules only for validation. They are not browser runtime code.
+- `docs_build/dev/reports/project-workspace-mock-repository.md` is historical/report documentation and is not runtime code.
+- Existing seed-only audit fallback diagnostics remain visible during validation. They are not new boundary violations and are still isolated under dev-runtime seed/bootstrap behavior.

docs_build/dev/reports/dev-runtime-boundary-enforcement-report.md

@@ -0,0 +1,65 @@
+# PR_26158_039 Dev Runtime Boundary Enforcement Report
+
+## Summary
+
+PR_26158_039 moves the remaining active mock repository and guest seed implementation out of `toolbox/**` and into `src/dev-runtime/**`, while preserving the Browser -> Server API -> Data Source boundary.
+
+No active browser/tool surface now imports `src/dev-runtime`, mock repositories, or moved seed files directly. The local API server remains the only runtime bridge to the dev-only implementations.
+
+## Implementation
+
+| Change | Evidence | Status |
+| --- | --- | --- |
+| Moved Asset mock repository into dev-runtime persistence. | `src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js`; `toolbox/assets/assets-mock-repository.js` deleted. | PASS |
+| Moved Palette mock repository into dev-runtime persistence. | `src/dev-runtime/persistence/tool-repositories/palette-workspace-repository.js`; `toolbox/colors/palette-workspace-repository.js` deleted. | PASS |
+| Moved Palette source seed rows into dev-runtime guest seeds. | `src/dev-runtime/guest-seeds/palette-source-mock-db.js`; `toolbox/colors/palette-source-mock-db.js` deleted. | PASS |
+| Moved Game Configuration mock repository into dev-runtime persistence. | `src/dev-runtime/persistence/tool-repositories/game-configuration-mock-repository.js`; old toolbox file deleted. | PASS |
+| Moved Game Design mock repository into dev-runtime persistence. | `src/dev-runtime/persistence/tool-repositories/game-design-mock-repository.js`; old toolbox file deleted. | PASS |
+| Moved Project Journey mock repository into dev-runtime persistence. | `src/dev-runtime/persistence/tool-repositories/project-journey-mock-repository.js`; old toolbox file deleted. | PASS |
+| Moved Project Workspace mock repository into dev-runtime persistence. | `src/dev-runtime/persistence/tool-repositories/project-workspace-mock-repository.js`; old toolbox file deleted. | PASS |
+| Moved Local Mem guest/user tool-state sample construction into dev-runtime guest seeds. | `src/dev-runtime/guest-seeds/tool-state-samples.js`; `src/dev-runtime/server/mock-api-router.mjs` calls `createServerSeedTables()`. | PASS |
+| Updated server router imports to dev-runtime repositories only. | `src/dev-runtime/server/mock-api-router.mjs` imports from `../persistence/tool-repositories/*` and `../guest-seeds/tool-state-samples.js`. | PASS |
+| Updated repository-focused tests to import dev-runtime repositories. | `tests/playwright/tools/*MockRepository.spec.mjs`; `tests/playwright/tools/AdminDbViewer.spec.mjs`; `tests/playwright/tools/ProjectJourneyTool.spec.mjs`. | PASS |
+| Added explicit boundary validation. | `tests/dev-runtime/DevRuntimeBoundary.test.mjs`. | PASS |
+
+## Requirement Checklist
+
+| Requirement | Evidence | Result |
+| --- | --- | --- |
+| Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` first. | Read before implementation. | PASS |
+| Audit mock, seed, test, guest, demo, fixture, dev-only, and local-only runtime code. | Static searches plus `DevRuntimeBoundary.test.mjs`; see `dev-runtime-audit.md`. | PASS |
+| Move remaining dev-only implementation into approved `src/dev-runtime` areas. | Mock repositories moved to `src/dev-runtime/persistence/tool-repositories`; seed data moved to `src/dev-runtime/guest-seeds`. | PASS |
+| Verify UAT/PROD bundles do not import/package `src/dev-runtime`. | Static audit over active browser/UAT/PROD candidate roots returned no matches. | PASS |
+| Verify active tools consume runtime contracts only and do not import dev-runtime directly. | `rg` audit over `account`, `admin`, `assets`, `toolbox`, and active `src` surfaces returned no matches. | PASS |
+| Verify Local Mem, guest seeds, test fixtures, and reseed behavior originate from `src/dev-runtime`. | Server seed creation now lives in `src/dev-runtime/guest-seeds/tool-state-samples.js`; reseed validation passed. | PASS |
+| Preserve SQLite-backed Local DB behind API boundary. | AdminDbViewer Local DB readonly lane passed. | PASS |
+| Preserve independent Local Mem and Local DB reseed behavior. | `DbSeedIntegrity` and LoginSessionMode Playwright passed. | PASS |
+| Update reports with remaining violations. | This report and `dev-runtime-audit.md` list findings. | PASS |
+| Do not add UAT/Prod adapter behavior. | No UAT/Prod adapter files changed. | PASS |
+| Do not modify `start_of_day` folders. | No `start_of_day` files changed. | PASS |
+
+## Validation
+
+| Validation | Result |
+| --- | --- |
+| Changed-file syntax checks | PASS |
+| `node --test tests/dev-runtime/DevRuntimeBoundary.test.mjs` | PASS, 3/3 |
+| `node --test tests/dev-runtime/DbSeedIntegrity.test.mjs` | PASS, 2/2 |
+| `npx playwright test tests/playwright/tools/LoginSessionMode.spec.mjs` | PASS, 6/6 |
+| `npx playwright test tests/playwright/tools/AdminDbViewer.spec.mjs` | PASS, 7/7 |
+| `npx playwright test tests/playwright/tools/PaletteToolMockRepository.spec.mjs` | PASS, 4/4 |
+| `npx playwright test tests/playwright/tools/AssetToolMockRepository.spec.mjs` | PASS, 6/6 |
+| `npx playwright test tests/playwright/tools/ProjectJourneyTool.spec.mjs` | PASS, 13/13 |
+| Static import boundary audit | PASS |
+| `git diff --check` | PASS, line-ending warnings only |
+
+## Remaining Violations
+
+None found in active browser/tool surfaces.
+
+`src/dev-runtime/server/` remains as the local API server boundary created by prior migration work. It is not mock data ownership; it imports the dev-runtime persistence and guest seed modules and exposes them through API routes.
+
+## Notes
+
+- V8 coverage is advisory for this PR because the moved modules are server/dev-runtime JavaScript and are not directly collected by browser V8 coverage.
+- Existing seed-only audit fallback diagnostics still appear during some Local Mem/Local DB initialization tests. They are existing seed diagnostics and did not cause validation failures.