Skip to content

Commit f1e9340

Browse files
committed
PR_26171_042 clean up idea board navigation fallback
1 parent 0c35f32 commit f1e9340

10 files changed

Lines changed: 590 additions & 943 deletions

File tree

assets/theme-v2/js/tool-display-mode.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -154,11 +154,6 @@
154154
body.appendChild(navigationRow);
155155
} catch (error) {
156156
console.warn("Tool navigation could not be loaded.", error);
157-
const diagnostic = document.createElement("p");
158-
diagnostic.className = "status";
159-
diagnostic.setAttribute("role", "status");
160-
diagnostic.textContent = "Tool navigation is temporarily unavailable. Refresh the page or try again shortly.";
161-
body.appendChild(diagnostic);
162157
}
163158
}
164159

Lines changed: 69 additions & 83 deletions
Original file line numberDiff line numberDiff line change
@@ -1,91 +1,77 @@
1-
# Codex Changed Files - PR_26171_041-idea-board-production-polish
1+
# PR_26171_042 Codex Changed Files Report
22

3-
## Git Workflow
4-
- Current branch: `codex/pr-26171-041-idea-board-production-polish`.
5-
- Expected starting branch: `main` (PASS before branch creation).
6-
- Created branch: `codex/pr-26171-041-idea-board-production-polish`.
7-
- Commit before conflict resolution: `ca626873a4cf19925229851b0da2a4ff55c2073f`.
8-
- Initial push result: PASS, branch pushed to `origin/codex/pr-26171-041-idea-board-production-polish`.
9-
- PR URL: `https://github.com/ToolboxAid/HTML-JavaScript-Gaming/pull/17`.
10-
- Conflict resolution: merged `origin/main` at `0a364f85516aea82e38eea2f498fde5980f9adf9`; conflicts were limited to `codex_changed_files.txt` and `codex_review.diff`.
11-
- Conflict resolution push result: pending until after merge-validation commit.
12-
- Merge result: pending until after PR validation/merge.
13-
- Final main sync: pending until after merge and final pull.
3+
## Instruction Compliance Gate
144

15-
## Git Status
16-
```text
17-
M assets/theme-v2/css/tables.css
18-
M assets/theme-v2/js/tool-display-mode.js
19-
M docs_build/dev/reports/codex_changed_files.txt
20-
M docs_build/dev/reports/codex_review.diff
21-
M docs_build/dev/reports/coverage_changed_js_guardrail.txt
22-
M docs_build/dev/reports/playwright_v8_coverage_report.txt
23-
M src/shared/toolbox/tool-metadata-inventory.js
24-
M tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
25-
M tests/playwright/tools/ToolboxRoutePages.spec.mjs
26-
M toolbox/idea-board/index.html
27-
M toolbox/idea-board/index.js
28-
```
5+
- Current branch before execution: `main`
6+
- Required execution branch before PR branch: `main`
7+
- Branch validation: PASS
8+
- Clean repository before branch creation: PASS
9+
- PR owner/parity: PASS, `042` is even and Idea/Tool Display navigation scope maps to PC / Environment 1.
10+
- Implementation path: PASS, active Idea Board and Theme V2 files only.
11+
- Validation scope: PASS, targeted Idea Board, targeted Toolbox route for Idea Board, and workspace contract lane because shared Tool Display Mode behavior changed.
12+
- Required reports: PASS, `docs_build/dev/reports/codex_review.diff` and this report are updated.
13+
- ZIP requirement: PASS, `tmp/PR_26171_042-idea-board-navigation-fallback-cleanup_delta.zip` is required and produced before final delivery.
2914

30-
## Diff Stat
31-
```text
32-
assets/theme-v2/css/tables.css | 70 +++++++-
33-
assets/theme-v2/js/tool-display-mode.js | 2 +-
34-
.../dev/reports/coverage_changed_js_guardrail.txt | 5 +-
35-
.../dev/reports/playwright_v8_coverage_report.txt | 11 +-
36-
src/shared/toolbox/tool-metadata-inventory.js | 6 +-
37-
.../playwright/tools/IdeaBoardTableNotes.spec.mjs | 71 +++++++-
38-
tests/playwright/tools/ToolboxRoutePages.spec.mjs | 26 ++-
39-
toolbox/idea-board/index.html | 31 ++--
40-
toolbox/idea-board/index.js | 191 ++++++++++++++++++++-
41-
9 files changed, 368 insertions(+), 45 deletions(-)
42-
```
15+
## Git Workflow Fields
16+
17+
- Created branch: `codex/pr-26171-042-idea-board-navigation-fallback-cleanup`
18+
- Push result: will be updated after push.
19+
- PR URL: will be updated after PR creation.
20+
- Merge result: recorded in final Codex delivery after GitHub merge returns the merge SHA.
21+
- Final main commit: recorded in final Codex delivery after returning to `main` and pulling latest.
22+
23+
## Scoped Files
24+
25+
- `assets/theme-v2/js/tool-display-mode.js`
26+
- `tests/playwright/tools/IdeaBoardTableNotes.spec.mjs`
27+
- `tests/playwright/tools/ToolboxRoutePages.spec.mjs`
28+
- `docs_build/pr/PR_26171_042-idea-board-navigation-fallback-cleanup/PLAN_PR.md`
29+
- `docs_build/pr/PR_26171_042-idea-board-navigation-fallback-cleanup/BUILD_PR.md`
30+
- `docs_build/pr/PR_26171_042-idea-board-navigation-fallback-cleanup/APPLY_PR.md`
31+
- `docs_build/dev/reports/coverage_changed_js_guardrail.txt`
32+
- `docs_build/dev/reports/playwright_v8_coverage_report.txt`
33+
- `docs_build/dev/reports/codex_review.diff`
34+
- `docs_build/dev/reports/codex_changed_files.txt`
4335

4436
## Requirement Evidence
45-
- PASS: Removed creator-visible Create Project from the right-side Next Steps area; no disabled `data-idea-board-create-project` panel remains.
46-
- PASS: Create Project is shown only in a Ready idea row's Actions column.
47-
- PASS: Clicking Create Project changes the idea status from Ready to Project and replaces Create Project/Delete with Open Project and Archive.
48-
- PASS: Project rows show Open Project and Archive and do not show Delete.
49-
- PASS: Added Archived status; archived rows are hidden by default.
50-
- PASS: Archived rows show Restore and Delete.
51-
- PASS: Restore returns archived ideas to their previous non-archived status, with Refining fallback in runtime.
52-
- PASS: Delete is guarded so Project ideas cannot be deleted unless archived first.
53-
- PASS: Status dropdown uses New, Exploring, Refining, Ready, Project, and Archived.
54-
- PASS: Added compact Show checkbox dropdown beside the visible table description line, with default statuses New, Exploring, Refining, Ready, and Project selected and Archived unselected.
55-
- PASS: Show dropdown supports any checkbox combination plus Select All and Clear All.
56-
- PASS: Updated creator-facing copy to "Capture, compare, and shape game ideas." and "Scan, compare, and update early ideas."
57-
- PASS: Replaced creator-visible Tool Display Mode navigation error with safe copy that does not mention server/API/local server/port/implementation details.
58-
- PASS: Chevron renders to the left of the Idea text, inline, same size, same color, and on the same text line; the whole Idea cell remains the expansion target.
59-
- PASS: Notes count remains informational only.
60-
- PASS: Table-first structure, inline Add Idea/Add Note, row-level Save/Cancel, status dropdown edit mode, notes indentation, and single-open accordion behavior remain covered.
37+
38+
- PASS: Removed creator-visible Tool Display Mode navigation diagnostic fallback. `tool-display-mode.js` now logs the navigation load failure to console only and appends no status paragraph.
39+
- PASS: Removed visible message `Tool navigation is temporarily unavailable. Refresh the page or try again shortly.`
40+
- PASS: Idea Board stays usable when registry-backed navigation cannot load. Static/no-registry Playwright path expands notes and adds a note successfully.
41+
- PASS: Creator-facing UI does not mention server, API, local server, port, registry, snapshot, or implementation details in the navigation fallback area.
42+
- PASS: Navigation failure does not affect Idea Board table functionality.
43+
- PASS: API-backed local route validated by targeted Idea Board and Toolbox route Playwright.
44+
- PASS: Static/no-registry route behavior validated by targeted Idea Board Playwright with the registry snapshot returning no data.
45+
- PASS: Optional previous/next navigation is omitted when unavailable.
46+
- PASS: Idea Board lifecycle, Show filter, Create Project, Archive, chevron, and table row editing behavior were not changed.
6147

6248
## Validation
63-
- PASS: `node --check toolbox/idea-board/index.js`.
64-
- PASS: `node --check assets/theme-v2/js/tool-display-mode.js`.
65-
- PASS: `node --check src/shared/toolbox/tool-metadata-inventory.js`.
66-
- PASS: `node --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjs`.
67-
- PASS: `node --check tests/playwright/tools/ToolboxRoutePages.spec.mjs`.
68-
- PASS: `npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --project=playwright --workers=1 --reporter=line --timeout=90000`.
69-
- PASS: `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --project=playwright --workers=1 --reporter=line -g "Idea Board launches" --timeout=90000`.
70-
- PASS: `npm run test:workspace-v2` (workspace-contract lane, 5 passed).
71-
- PASS: `git diff --check`.
72-
- PASS: Post-conflict rerun completed after merging `origin/main` at `0a364f85516aea82e38eea2f498fde5980f9adf9`.
73-
- PASS: Playwright V8 coverage report produced because runtime JavaScript changed.
74-
- WARN: Coverage report marks `src/shared/toolbox/tool-metadata-inventory.js` as not collected by browser V8 coverage; advisory only per project instructions.
75-
- SKIPPED: Full samples smoke was not run per request.
7649

77-
## ZIP
78-
- Path: `tmp/PR_26171_041-idea-board-production-polish_delta.zip`.
79-
- Size: final size reported in the delivery summary after conflict-resolution ZIP refresh.
80-
- Contents:
81-
- assets/theme-v2/css/tables.css
82-
- assets/theme-v2/js/tool-display-mode.js
83-
- docs_build/dev/reports/codex_changed_files.txt
84-
- docs_build/dev/reports/codex_review.diff
85-
- docs_build/dev/reports/coverage_changed_js_guardrail.txt
86-
- docs_build/dev/reports/playwright_v8_coverage_report.txt
87-
- src/shared/toolbox/tool-metadata-inventory.js
88-
- tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
89-
- tests/playwright/tools/ToolboxRoutePages.spec.mjs
90-
- toolbox/idea-board/index.html
91-
- toolbox/idea-board/index.js
50+
- PASS: `node --check assets/theme-v2/js/tool-display-mode.js`
51+
- PASS: `node --check toolbox/idea-board/index.js`
52+
- PASS: `node --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjs`
53+
- PASS: `node --check tests/playwright/tools/ToolboxRoutePages.spec.mjs`
54+
- PASS: `npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --project=playwright --workers=1 --reporter=line --timeout=90000`
55+
- PASS: `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --project=playwright --workers=1 --reporter=line -g "Idea Board launches" --timeout=90000`
56+
- PASS: `npm run test:workspace-v2`
57+
- PASS: `git diff --check`
58+
- SKIP: Full samples smoke, per user instruction.
59+
60+
## Coverage Evidence
61+
62+
- PASS: `docs_build/dev/reports/playwright_v8_coverage_report.txt` updated.
63+
- PASS: `docs_build/dev/reports/coverage_changed_js_guardrail.txt` updated.
64+
- PASS: Changed runtime JS coverage lists `assets/theme-v2/js/tool-display-mode.js` at 64% advisory function coverage.
65+
66+
## ZIP Contents
67+
68+
- `assets/theme-v2/js/tool-display-mode.js`
69+
- `docs_build/dev/reports/codex_changed_files.txt`
70+
- `docs_build/dev/reports/codex_review.diff`
71+
- `docs_build/dev/reports/coverage_changed_js_guardrail.txt`
72+
- `docs_build/dev/reports/playwright_v8_coverage_report.txt`
73+
- `docs_build/pr/PR_26171_042-idea-board-navigation-fallback-cleanup/APPLY_PR.md`
74+
- `docs_build/pr/PR_26171_042-idea-board-navigation-fallback-cleanup/BUILD_PR.md`
75+
- `docs_build/pr/PR_26171_042-idea-board-navigation-fallback-cleanup/PLAN_PR.md`
76+
- `tests/playwright/tools/IdeaBoardTableNotes.spec.mjs`
77+
- `tests/playwright/tools/ToolboxRoutePages.spec.mjs`

0 commit comments

Comments
 (0)