Edit Scheduling Subpart: Subpart Credit

- Max Units made editable when editing Variable Min/Max credit without the need to change the credit type first (when editing existing credit information)
- fixed an issue when no units or max units are provided (for a type that requires units/max units) or when the provided units are not a number

Author: tomas-muller

JavaSource/org/unitime/timetable/action/SchedulingSubpartEditAction.java

@@ -340,10 +340,10 @@ private void doLoad(SchedulingSubpart ss, String subpartId ) {
 	        	form.setCreditType(credit.getCreditType().getUniqueId());
 	        	form.setCreditUnitType(credit.getCreditUnitType().getUniqueId());
 	        	if (credit instanceof FixedCreditUnitConfig){
-	        		form.setUnits(((FixedCreditUnitConfig) credit).getFixedUnits());
+	        		form.setUnits(float2string(((FixedCreditUnitConfig) credit).getFixedUnits()));
 	        	} else if (credit instanceof VariableFixedCreditUnitConfig){
-	        		form.setUnits(((VariableFixedCreditUnitConfig) credit).getMinUnits());
-	        		form.setMaxUnits(((VariableFixedCreditUnitConfig) credit).getMaxUnits());
+	        		form.setUnits(float2string(((VariableFixedCreditUnitConfig) credit).getMinUnits()));
+	        		form.setMaxUnits(float2string(((VariableFixedCreditUnitConfig) credit).getMaxUnits()));
 	        		if (credit instanceof VariableRangeCreditUnitConfig){
 	        			form.setFractionalIncrementsAllowed(((VariableRangeCreditUnitConfig) credit).isFractionalIncrementsAllowed());
 	        		}
@@ -444,18 +444,27 @@ private void doUpdate(SchedulingSubpart ss, SchedulingSubpartDAO sdao, boolean t
         				CourseCreditUnitConfig origConfig = ss.getCredit();
             			ss.setCredit(null);
             			sdao.getSession().remove(origConfig);
-            			ss.setCredit(CourseCreditUnitConfig.createCreditUnitConfigOfFormat(form.getCreditFormat(), form.getCreditType(), form.getCreditUnitType(), form.getUnits(), form.getMaxUnits(), form.getFractionalIncrementsAllowed(), Boolean.valueOf(false)));
+            			ss.setCredit(CourseCreditUnitConfig.createCreditUnitConfigOfFormat(
+            					form.getCreditFormat(), form.getCreditType(), form.getCreditUnitType(),
+            					string2float(form.getUnits()), string2float(form.getMaxUnits()),
+            					form.getFractionalIncrementsAllowed(), Boolean.valueOf(false)));
             			ss.getCredit().setOwner(ss);
         			}
         		} else {
         			CourseCreditUnitConfig origConfig = ss.getCredit();
         			ss.setCredit(null);
         			sdao.getSession().remove(origConfig);
-        			ss.setCredit(CourseCreditUnitConfig.createCreditUnitConfigOfFormat(form.getCreditFormat(), form.getCreditType(), form.getCreditUnitType(), form.getUnits(), form.getMaxUnits(), form.getFractionalIncrementsAllowed(), Boolean.valueOf(false)));
+        			ss.setCredit(CourseCreditUnitConfig.createCreditUnitConfigOfFormat(
+        					form.getCreditFormat(), form.getCreditType(), form.getCreditUnitType(),
+        					string2float(form.getUnits()), string2float(form.getMaxUnits()),
+        					form.getFractionalIncrementsAllowed(), Boolean.valueOf(false)));
         			ss.getCredit().setOwner(ss);
         		}
         	} else {
-    			ss.setCredit(CourseCreditUnitConfig.createCreditUnitConfigOfFormat(form.getCreditFormat(), form.getCreditType(), form.getCreditUnitType(), form.getUnits(), form.getMaxUnits(), form.getFractionalIncrementsAllowed(), Boolean.valueOf(false)));
+    			ss.setCredit(CourseCreditUnitConfig.createCreditUnitConfigOfFormat(
+    					form.getCreditFormat(), form.getCreditType(), form.getCreditUnitType(),
+    					string2float(form.getUnits()), string2float(form.getMaxUnits()),
+    					form.getFractionalIncrementsAllowed(), Boolean.valueOf(false)));
     			ss.getCredit().setOwner(ss);
         	}
         }
@@ -485,6 +494,19 @@ private void doUpdate(SchedulingSubpart ss, SchedulingSubpartDAO sdao, boolean t
         sdao.getSession().flush();
     }
 
+    protected static Float string2float(String value) {
+    	try {
+    		return Float.valueOf(value);
+    	} catch (Exception e) {
+    		return 0f;
+    	}
+    }
+    
+    protected static String float2string(Float value) {
+    	if (value == null) return "";
+    	return value.toString();
+    }
+    
     protected void setupChildren(SchedulingSubpart ss) {
 		DatePattern selectedDatePattern = (form.getDatePattern() < 0 ? (ss.canInheritParentPreferences() ? ss.getParentSubpart().effectiveDatePattern() : ss.getSession().getDefaultDatePatternNotNull()) : DatePatternDAO.getInstance().get(form.getDatePattern()));
 		try {

JavaSource/org/unitime/timetable/form/SchedulingSubpartEditForm.java

@@ -50,8 +50,8 @@ public class SchedulingSubpartEditForm extends PreferencesForm {
     private String creditFormat;
     private Long creditType;
     private Long creditUnitType;
-    private Float units;
-    private Float maxUnits;
+    private String units;
+    private String maxUnits;
     private Boolean fractionalIncrementsAllowed;
     private String creditText;
     private Boolean sameItypeAsParent;
@@ -238,22 +238,22 @@ public void setFractionalIncrementsAllowed(Boolean fractionalIncrementsAllowed)
 		this.fractionalIncrementsAllowed = fractionalIncrementsAllowed;
 	}
 
-	public Float getMaxUnits() {
+	public String getMaxUnits() {
 		return maxUnits;
 	}
 
-	public void setMaxUnits(Float maxUnits) {
+	public void setMaxUnits(String maxUnits) {
 		this.maxUnits = maxUnits;
 	}
-
-	public Float getUnits() {
+	
+	public String getUnits() {
 		return units;
 	}
 
-	public void setUnits(Float units) {
+	public void setUnits(String units) {
 		this.units = units;
 	}
-
+	
 	public String getCreditText() {
 		return creditText;
 	}

WebContent/help/Release-Notes.xml

@@ -44,6 +44,13 @@
 				</line>
 			</description>
 		</item>
+		<item>
+			<name>Edit Scheduling Subpart: Subpart Credit</name>
+			<description>
+				<line>Max Units made editable when editing Variable Min/Max credit without the need to change the credit type first (when editing existing credit information).</line>
+				<line>Fixed an issue when no units or max units are provided (for a type that requires units/max units) or when the provided units are not a number.</line>
+			</description>
+		</item>
 		<item>
 			<name>Course Timetabling Solver: Optimization</name>
 			<description>

WebContent/user/schedulingSubpartEdit.jsp

@@ -209,7 +209,7 @@
 				<td nowrap><loc:message name="propertyMaxUnits"/></td>
 				<td>
 				<s:textfield name="form.maxUnits" maxlength="4" size="4"
-					disabled="%{form.creditFormat != 'variableRange'}"/>
+					disabled="%{form.creditFormat != 'variableRange' && form.creditFormat != 'variableMinMax'}"/>
 				</td>
 				</tr>
 				<tr>