From 0596fcf44d83eb6470abbc066ecce2a9f1130514 Mon Sep 17 00:00:00 2001 From: Martin Kustermann Date: Thu, 18 Jun 2026 11:13:58 +0200 Subject: [PATCH 1/6] Add --emit-module-names to wasm-opt The `wasm-split` command has this `--emit-module-names` flag already and this adds it to `wasm-opt` as well. Wasm runtimes may not know the URL where a wasm file came from, it may only be given the bytes. Currently e.g. V8 prints a V8 specific hash of the wasm file in stack traces. If we have the ability to keep module names, then it would print the module name (fallback if the url is not available) -- which would allow a stack trace decoding tool to tie the module name back to the right wasm module of an app. --- src/tools/wasm-opt.cpp | 16 ++++++++++++++++ test/lit/emit-module-names.wast | 15 +++++++++++++++ test/lit/help/wasm-opt.test | 4 ++++ 3 files changed, 35 insertions(+) create mode 100644 test/lit/emit-module-names.wast diff --git a/src/tools/wasm-opt.cpp b/src/tools/wasm-opt.cpp index 9bdfa4b06f7..7e363e2b21d 100644 --- a/src/tools/wasm-opt.cpp +++ b/src/tools/wasm-opt.cpp @@ -95,6 +95,7 @@ int main(int argc, const char* argv[]) { std::string outputSourceMapFilename; std::string outputSourceMapUrl; bool emitExnref = false; + bool emitModuleNames = false; const std::string WasmOptOption = "wasm-opt options"; @@ -269,6 +270,15 @@ For more on how to optimize effectively, see [&outputSourceMapUrl](Options* o, const std::string& argument) { outputSourceMapUrl = argument; }) + .add( + "--emit-module-names", + "", + "Emit module names, even if not emitting the rest of the names section", + WasmOptOption, + Options::Arguments::Zero, + [&emitModuleNames](Options*, const std::string&) { + emitModuleNames = true; + }) .add_positional("INFILE", Options::Arguments::One, [](Options* o, const std::string& argument) { @@ -407,6 +417,9 @@ For more on how to optimize effectively, see ModuleWriter writer(options.passOptions); writer.setBinary(emitBinary); writer.setDebugInfo(options.passOptions.debugInfo); + if (emitModuleNames) { + writer.setEmitModuleName(true); + } writer.write(wasm, options.extra["output"]); firstOutput = runCommand(extraFuzzCommand); std::cout << "[extra-fuzz-command first output:]\n" << firstOutput << '\n'; @@ -496,6 +509,9 @@ For more on how to optimize effectively, see ModuleWriter writer(options.passOptions); writer.setBinary(emitBinary); writer.setDebugInfo(options.passOptions.debugInfo); + if (emitModuleNames) { + writer.setEmitModuleName(true); + } if (outputSourceMapFilename.size()) { writer.setSourceMapFilename(outputSourceMapFilename); writer.setSourceMapUrl(outputSourceMapUrl); diff --git a/test/lit/emit-module-names.wast b/test/lit/emit-module-names.wast new file mode 100644 index 00000000000..8849d383636 --- /dev/null +++ b/test/lit/emit-module-names.wast @@ -0,0 +1,15 @@ +;; Check that --emit-module-names without -g strips function names but generates +;; and keeps the module name. + +;; RUN: wasm-opt %s --emit-module-names -o %t.wasm +;; RUN: wasm-dis %t.wasm -o - | filecheck %s + +;; CHECK: (module $module-name +;; CHECK: (func $0 +;; CHECK-NOT: $foo + +(module $module-name + (func $foo + (nop) + ) +) diff --git a/test/lit/help/wasm-opt.test b/test/lit/help/wasm-opt.test index 4dec96a4104..afe7bb209de 100644 --- a/test/lit/help/wasm-opt.test +++ b/test/lit/help/wasm-opt.test @@ -98,6 +98,10 @@ ;; CHECK-NEXT: --output-source-map-url,-osu Emit specified string as source ;; CHECK-NEXT: map URL ;; CHECK-NEXT: +;; CHECK-NEXT: --emit-module-names Emit module names, even if not +;; CHECK-NEXT: emitting the rest of the names +;; CHECK-NEXT: section +;; CHECK-NEXT: ;; CHECK-NEXT: --experimental-new-eh Deprecated; same as ;; CHECK-NEXT: --emit-exnref ;; CHECK-NEXT: From 99c2cdb61acebd3bfff0912b6ff9904d7b2dcb5c Mon Sep 17 00:00:00 2001 From: Martin Kustermann Date: Fri, 19 Jun 2026 12:00:03 +0200 Subject: [PATCH 2/6] Move flag to ToolOptions --- src/tools/tool-options.h | 21 ++++++++++++++------- src/tools/wasm-opt.cpp | 15 +++------------ src/tools/wasm-split/split-options.cpp | 12 +----------- src/tools/wasm-split/split-options.h | 2 -- 4 files changed, 18 insertions(+), 32 deletions(-) diff --git a/src/tools/tool-options.h b/src/tools/tool-options.h index 2106fc66a49..e859d41be3a 100644 --- a/src/tools/tool-options.h +++ b/src/tools/tool-options.h @@ -32,6 +32,7 @@ struct ToolOptions : public Options { bool quiet = false; bool preserveTypeOrder = false; + bool emitModuleNames = false; IRProfile profile = IRProfile::Normal; constexpr static const char* ToolOptionsCategory = "Tool options"; @@ -69,13 +70,19 @@ struct ToolOptions : public Options { ToolOptionsCategory, Arguments::Zero, [this](Options*, const std::string&) { quiet = true; }) - .add( - "--experimental-poppy", - "", - "Parse wast files as Poppy IR for testing purposes.", - ToolOptionsCategory, - Arguments::Zero, - [this](Options*, const std::string&) { profile = IRProfile::Poppy; }); + .add("--experimental-poppy", + "", + "Parse wast files as Poppy IR for testing purposes.", + ToolOptionsCategory, + Arguments::Zero, + [this](Options*, const std::string&) { profile = IRProfile::Poppy; }) + .add("--emit-module-names", + "", + "Emit module names, even if not emitting the rest of the names " + "section.", + ToolOptionsCategory, + Arguments::Zero, + [this](Options*, const std::string&) { emitModuleNames = true; }); (*this) .addFeature(FeatureSet::SignExt, "sign extension operations") .addFeature(FeatureSet::Atomics, "atomic operations") diff --git a/src/tools/wasm-opt.cpp b/src/tools/wasm-opt.cpp index 7e363e2b21d..972b75a322e 100644 --- a/src/tools/wasm-opt.cpp +++ b/src/tools/wasm-opt.cpp @@ -95,7 +95,6 @@ int main(int argc, const char* argv[]) { std::string outputSourceMapFilename; std::string outputSourceMapUrl; bool emitExnref = false; - bool emitModuleNames = false; const std::string WasmOptOption = "wasm-opt options"; @@ -270,15 +269,7 @@ For more on how to optimize effectively, see [&outputSourceMapUrl](Options* o, const std::string& argument) { outputSourceMapUrl = argument; }) - .add( - "--emit-module-names", - "", - "Emit module names, even if not emitting the rest of the names section", - WasmOptOption, - Options::Arguments::Zero, - [&emitModuleNames](Options*, const std::string&) { - emitModuleNames = true; - }) + .add_positional("INFILE", Options::Arguments::One, [](Options* o, const std::string& argument) { @@ -417,7 +408,7 @@ For more on how to optimize effectively, see ModuleWriter writer(options.passOptions); writer.setBinary(emitBinary); writer.setDebugInfo(options.passOptions.debugInfo); - if (emitModuleNames) { + if (options.emitModuleNames) { writer.setEmitModuleName(true); } writer.write(wasm, options.extra["output"]); @@ -509,7 +500,7 @@ For more on how to optimize effectively, see ModuleWriter writer(options.passOptions); writer.setBinary(emitBinary); writer.setDebugInfo(options.passOptions.debugInfo); - if (emitModuleNames) { + if (options.emitModuleNames) { writer.setEmitModuleName(true); } if (outputSourceMapFilename.size()) { diff --git a/src/tools/wasm-split/split-options.cpp b/src/tools/wasm-split/split-options.cpp index d62d22ad765..d20b57f6cd7 100644 --- a/src/tools/wasm-split/split-options.cpp +++ b/src/tools/wasm-split/split-options.cpp @@ -312,17 +312,7 @@ WasmSplitOptions::WasmSplitOptions() [&](Options* o, const std::string& argument) { secondaryMemoryName = argument; }) - .add( - "--emit-module-names", - "", - "Emit module names, even if not emitting the rest of the names section. " - "Can help differentiate the modules in stack traces. This option will be " - "removed once simpler ways of naming modules are widely available. See " - "https://bugs.chromium.org/p/v8/issues/detail?id=11808.", - WasmSplitOption, - {Mode::Split, Mode::MultiSplit, Mode::Instrument}, - Options::Arguments::Zero, - [&](Options* o, const std::string& arguments) { emitModuleNames = true; }) + .add("--initial-table", "", "A hack to ensure the split and instrumented modules have the same " diff --git a/src/tools/wasm-split/split-options.h b/src/tools/wasm-split/split-options.h index 7955721f5d3..1b061868873 100644 --- a/src/tools/wasm-split/split-options.h +++ b/src/tools/wasm-split/split-options.h @@ -52,8 +52,6 @@ struct WasmSplitOptions : ToolOptions { bool placeholderMap = false; bool stripDebug = false; - // TODO: Remove this. See the comment in wasm-binary.h. - bool emitModuleNames = false; std::string profileFile; std::string profileExport = DEFAULT_PROFILE_EXPORT; From c2263eac23fa5a58aa156bb57d33cc984a7ab2e0 Mon Sep 17 00:00:00 2001 From: Martin Kustermann Date: Fri, 19 Jun 2026 14:31:30 +0200 Subject: [PATCH 3/6] Update tests --- test/lit/help/wasm-as.test | 4 ++++ test/lit/help/wasm-ctor-eval.test | 4 ++++ test/lit/help/wasm-dis.test | 4 ++++ test/lit/help/wasm-emscripten-finalize.test | 4 ++++ test/lit/help/wasm-merge.test | 4 ++++ test/lit/help/wasm-metadce.test | 4 ++++ test/lit/help/wasm-opt.test | 8 ++++---- test/lit/help/wasm-reduce.test | 4 ++++ test/lit/help/wasm-split.test | 13 ++++--------- test/lit/help/wasm2js.test | 4 ++++ 10 files changed, 40 insertions(+), 13 deletions(-) diff --git a/test/lit/help/wasm-as.test b/test/lit/help/wasm-as.test index fbb4f9c35e5..9e2724b6acf 100644 --- a/test/lit/help/wasm-as.test +++ b/test/lit/help/wasm-as.test @@ -38,6 +38,10 @@ ;; CHECK-NEXT: --experimental-poppy Parse wast files as Poppy IR for testing ;; CHECK-NEXT: purposes. ;; CHECK-NEXT: +;; CHECK-NEXT: --emit-module-names Emit module names, even if not +;; CHECK-NEXT: emitting the rest of the names +;; CHECK-NEXT: section +;; CHECK-NEXT: ;; CHECK-NEXT: --enable-sign-ext Enable sign extension operations ;; CHECK-NEXT: ;; CHECK-NEXT: --disable-sign-ext Disable sign extension operations diff --git a/test/lit/help/wasm-ctor-eval.test b/test/lit/help/wasm-ctor-eval.test index 7807de5e1de..0111e35facc 100644 --- a/test/lit/help/wasm-ctor-eval.test +++ b/test/lit/help/wasm-ctor-eval.test @@ -45,6 +45,10 @@ ;; CHECK-NEXT: --experimental-poppy Parse wast files as Poppy IR for testing ;; CHECK-NEXT: purposes. ;; CHECK-NEXT: +;; CHECK-NEXT: --emit-module-names Emit module names, even if not +;; CHECK-NEXT: emitting the rest of the names +;; CHECK-NEXT: section +;; CHECK-NEXT: ;; CHECK-NEXT: --enable-sign-ext Enable sign extension operations ;; CHECK-NEXT: ;; CHECK-NEXT: --disable-sign-ext Disable sign extension operations diff --git a/test/lit/help/wasm-dis.test b/test/lit/help/wasm-dis.test index 2f95f7a448a..f6bdedf4dc4 100644 --- a/test/lit/help/wasm-dis.test +++ b/test/lit/help/wasm-dis.test @@ -31,6 +31,10 @@ ;; CHECK-NEXT: --experimental-poppy Parse wast files as Poppy IR for testing ;; CHECK-NEXT: purposes. ;; CHECK-NEXT: +;; CHECK-NEXT: --emit-module-names Emit module names, even if not +;; CHECK-NEXT: emitting the rest of the names +;; CHECK-NEXT: section +;; CHECK-NEXT: ;; CHECK-NEXT: --enable-sign-ext Enable sign extension operations ;; CHECK-NEXT: ;; CHECK-NEXT: --disable-sign-ext Disable sign extension operations diff --git a/test/lit/help/wasm-emscripten-finalize.test b/test/lit/help/wasm-emscripten-finalize.test index 5ce391f9548..d5f218dcda9 100644 --- a/test/lit/help/wasm-emscripten-finalize.test +++ b/test/lit/help/wasm-emscripten-finalize.test @@ -73,6 +73,10 @@ ;; CHECK-NEXT: --experimental-poppy Parse wast files as Poppy IR for testing ;; CHECK-NEXT: purposes. ;; CHECK-NEXT: +;; CHECK-NEXT: --emit-module-names Emit module names, even if not +;; CHECK-NEXT: emitting the rest of the names +;; CHECK-NEXT: section +;; CHECK-NEXT: ;; CHECK-NEXT: --enable-sign-ext Enable sign extension operations ;; CHECK-NEXT: ;; CHECK-NEXT: --disable-sign-ext Disable sign extension operations diff --git a/test/lit/help/wasm-merge.test b/test/lit/help/wasm-merge.test index f235c12fe5e..37a8ee55655 100644 --- a/test/lit/help/wasm-merge.test +++ b/test/lit/help/wasm-merge.test @@ -68,6 +68,10 @@ ;; CHECK-NEXT: --experimental-poppy Parse wast files as Poppy IR for testing ;; CHECK-NEXT: purposes. ;; CHECK-NEXT: +;; CHECK-NEXT: --emit-module-names Emit module names, even if not +;; CHECK-NEXT: emitting the rest of the names +;; CHECK-NEXT: section +;; CHECK-NEXT: ;; CHECK-NEXT: --enable-sign-ext Enable sign extension operations ;; CHECK-NEXT: ;; CHECK-NEXT: --disable-sign-ext Disable sign extension operations diff --git a/test/lit/help/wasm-metadce.test b/test/lit/help/wasm-metadce.test index aadf987cf33..f1068465fd3 100644 --- a/test/lit/help/wasm-metadce.test +++ b/test/lit/help/wasm-metadce.test @@ -698,6 +698,10 @@ ;; CHECK-NEXT: --experimental-poppy Parse wast files as Poppy IR for ;; CHECK-NEXT: testing purposes. ;; CHECK-NEXT: +;; CHECK-NEXT: --emit-module-names Emit module names, even if not +;; CHECK-NEXT: emitting the rest of the names +;; CHECK-NEXT: section +;; CHECK-NEXT: ;; CHECK-NEXT: --enable-sign-ext Enable sign extension operations ;; CHECK-NEXT: ;; CHECK-NEXT: --disable-sign-ext Disable sign extension diff --git a/test/lit/help/wasm-opt.test b/test/lit/help/wasm-opt.test index afe7bb209de..903d6130089 100644 --- a/test/lit/help/wasm-opt.test +++ b/test/lit/help/wasm-opt.test @@ -98,10 +98,6 @@ ;; CHECK-NEXT: --output-source-map-url,-osu Emit specified string as source ;; CHECK-NEXT: map URL ;; CHECK-NEXT: -;; CHECK-NEXT: --emit-module-names Emit module names, even if not -;; CHECK-NEXT: emitting the rest of the names -;; CHECK-NEXT: section -;; CHECK-NEXT: ;; CHECK-NEXT: --experimental-new-eh Deprecated; same as ;; CHECK-NEXT: --emit-exnref ;; CHECK-NEXT: @@ -738,6 +734,10 @@ ;; CHECK-NEXT: --experimental-poppy Parse wast files as Poppy IR for ;; CHECK-NEXT: testing purposes. ;; CHECK-NEXT: +;; CHECK-NEXT: --emit-module-names Emit module names, even if not +;; CHECK-NEXT: emitting the rest of the names +;; CHECK-NEXT: section +;; CHECK-NEXT: ;; CHECK-NEXT: --enable-sign-ext Enable sign extension operations ;; CHECK-NEXT: ;; CHECK-NEXT: --disable-sign-ext Disable sign extension diff --git a/test/lit/help/wasm-reduce.test b/test/lit/help/wasm-reduce.test index a85c42f13ec..fb2804283db 100644 --- a/test/lit/help/wasm-reduce.test +++ b/test/lit/help/wasm-reduce.test @@ -121,6 +121,10 @@ ;; CHECK-NEXT: --experimental-poppy Parse wast files as Poppy IR for testing ;; CHECK-NEXT: purposes. ;; CHECK-NEXT: +;; CHECK-NEXT: --emit-module-names Emit module names, even if not +;; CHECK-NEXT: emitting the rest of the names +;; CHECK-NEXT: section +;; CHECK-NEXT: ;; CHECK-NEXT: --enable-sign-ext Enable sign extension operations ;; CHECK-NEXT: ;; CHECK-NEXT: --disable-sign-ext Disable sign extension operations diff --git a/test/lit/help/wasm-split.test b/test/lit/help/wasm-split.test index 0bd68869a09..c395b8edc6b 100644 --- a/test/lit/help/wasm-split.test +++ b/test/lit/help/wasm-split.test @@ -124,15 +124,6 @@ ;; CHECK-NEXT: memory created to store profile ;; CHECK-NEXT: information. ;; CHECK-NEXT: -;; CHECK-NEXT: --emit-module-names [split, multi-split, instrument] Emit -;; CHECK-NEXT: module names, even if not emitting the -;; CHECK-NEXT: rest of the names section. Can help -;; CHECK-NEXT: differentiate the modules in stack -;; CHECK-NEXT: traces. This option will be removed once -;; CHECK-NEXT: simpler ways of naming modules are widely -;; CHECK-NEXT: available. See -;; CHECK-NEXT: https://bugs.chromium.org/p/v8/issues/detail?id=11808. -;; CHECK-NEXT: ;; CHECK-NEXT: --initial-table [split, instrument] A hack to ensure the ;; CHECK-NEXT: split and instrumented modules have the ;; CHECK-NEXT: same table size when using Emscripten's @@ -182,6 +173,10 @@ ;; CHECK-NEXT: --experimental-poppy Parse wast files as Poppy IR for testing ;; CHECK-NEXT: purposes. ;; CHECK-NEXT: +;; CHECK-NEXT: --emit-module-names Emit module names, even if not +;; CHECK-NEXT: emitting the rest of the names +;; CHECK-NEXT: section +;; CHECK-NEXT: ;; CHECK-NEXT: --enable-sign-ext Enable sign extension operations ;; CHECK-NEXT: ;; CHECK-NEXT: --disable-sign-ext Disable sign extension operations diff --git a/test/lit/help/wasm2js.test b/test/lit/help/wasm2js.test index 550677a376f..acfc47bfc6f 100644 --- a/test/lit/help/wasm2js.test +++ b/test/lit/help/wasm2js.test @@ -662,6 +662,10 @@ ;; CHECK-NEXT: --experimental-poppy Parse wast files as Poppy IR for ;; CHECK-NEXT: testing purposes. ;; CHECK-NEXT: +;; CHECK-NEXT: --emit-module-names Emit module names, even if not +;; CHECK-NEXT: emitting the rest of the names +;; CHECK-NEXT: section +;; CHECK-NEXT: ;; CHECK-NEXT: --enable-sign-ext Enable sign extension operations ;; CHECK-NEXT: ;; CHECK-NEXT: --disable-sign-ext Disable sign extension From 312dbab56816ba9cb61f53fd2a338b1fbd93c4ab Mon Sep 17 00:00:00 2001 From: Martin Kustermann Date: Fri, 19 Jun 2026 14:31:30 +0200 Subject: [PATCH 4/6] Clang Format --- src/tools/wasm-opt.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tools/wasm-opt.cpp b/src/tools/wasm-opt.cpp index 972b75a322e..306ca5adaa9 100644 --- a/src/tools/wasm-opt.cpp +++ b/src/tools/wasm-opt.cpp @@ -269,7 +269,7 @@ For more on how to optimize effectively, see [&outputSourceMapUrl](Options* o, const std::string& argument) { outputSourceMapUrl = argument; }) - + .add_positional("INFILE", Options::Arguments::One, [](Options* o, const std::string& argument) { From fa5d4e6b8644de3f423ad5481c0e6026244a2019 Mon Sep 17 00:00:00 2001 From: Martin Kustermann Date: Fri, 19 Jun 2026 14:59:45 +0200 Subject: [PATCH 5/6] More expectation file updates --- test/lit/help/wasm-as.test | 5 ++--- test/lit/help/wasm-ctor-eval.test | 5 ++--- test/lit/help/wasm-dis.test | 5 ++--- test/lit/help/wasm-emscripten-finalize.test | 5 ++--- test/lit/help/wasm-merge.test | 5 ++--- test/lit/help/wasm-reduce.test | 5 ++--- test/lit/help/wasm-split.test | 5 ++--- 7 files changed, 14 insertions(+), 21 deletions(-) diff --git a/test/lit/help/wasm-as.test b/test/lit/help/wasm-as.test index 9e2724b6acf..2b4902683c5 100644 --- a/test/lit/help/wasm-as.test +++ b/test/lit/help/wasm-as.test @@ -38,9 +38,8 @@ ;; CHECK-NEXT: --experimental-poppy Parse wast files as Poppy IR for testing ;; CHECK-NEXT: purposes. ;; CHECK-NEXT: -;; CHECK-NEXT: --emit-module-names Emit module names, even if not -;; CHECK-NEXT: emitting the rest of the names -;; CHECK-NEXT: section +;; CHECK-NEXT: --emit-module-names Emit module names, even if not emitting +;; CHECK-NEXT: the rest of the names section ;; CHECK-NEXT: ;; CHECK-NEXT: --enable-sign-ext Enable sign extension operations ;; CHECK-NEXT: diff --git a/test/lit/help/wasm-ctor-eval.test b/test/lit/help/wasm-ctor-eval.test index 0111e35facc..1db625fc55d 100644 --- a/test/lit/help/wasm-ctor-eval.test +++ b/test/lit/help/wasm-ctor-eval.test @@ -45,9 +45,8 @@ ;; CHECK-NEXT: --experimental-poppy Parse wast files as Poppy IR for testing ;; CHECK-NEXT: purposes. ;; CHECK-NEXT: -;; CHECK-NEXT: --emit-module-names Emit module names, even if not -;; CHECK-NEXT: emitting the rest of the names -;; CHECK-NEXT: section +;; CHECK-NEXT: --emit-module-names Emit module names, even if not emitting +;; CHECK-NEXT: the rest of the names section ;; CHECK-NEXT: ;; CHECK-NEXT: --enable-sign-ext Enable sign extension operations ;; CHECK-NEXT: diff --git a/test/lit/help/wasm-dis.test b/test/lit/help/wasm-dis.test index f6bdedf4dc4..ab022774484 100644 --- a/test/lit/help/wasm-dis.test +++ b/test/lit/help/wasm-dis.test @@ -31,9 +31,8 @@ ;; CHECK-NEXT: --experimental-poppy Parse wast files as Poppy IR for testing ;; CHECK-NEXT: purposes. ;; CHECK-NEXT: -;; CHECK-NEXT: --emit-module-names Emit module names, even if not -;; CHECK-NEXT: emitting the rest of the names -;; CHECK-NEXT: section +;; CHECK-NEXT: --emit-module-names Emit module names, even if not emitting +;; CHECK-NEXT: the rest of the names section ;; CHECK-NEXT: ;; CHECK-NEXT: --enable-sign-ext Enable sign extension operations ;; CHECK-NEXT: diff --git a/test/lit/help/wasm-emscripten-finalize.test b/test/lit/help/wasm-emscripten-finalize.test index d5f218dcda9..ac5cab80db4 100644 --- a/test/lit/help/wasm-emscripten-finalize.test +++ b/test/lit/help/wasm-emscripten-finalize.test @@ -73,9 +73,8 @@ ;; CHECK-NEXT: --experimental-poppy Parse wast files as Poppy IR for testing ;; CHECK-NEXT: purposes. ;; CHECK-NEXT: -;; CHECK-NEXT: --emit-module-names Emit module names, even if not -;; CHECK-NEXT: emitting the rest of the names -;; CHECK-NEXT: section +;; CHECK-NEXT: --emit-module-names Emit module names, even if not emitting +;; CHECK-NEXT: the rest of the names section ;; CHECK-NEXT: ;; CHECK-NEXT: --enable-sign-ext Enable sign extension operations ;; CHECK-NEXT: diff --git a/test/lit/help/wasm-merge.test b/test/lit/help/wasm-merge.test index 37a8ee55655..3909411ec08 100644 --- a/test/lit/help/wasm-merge.test +++ b/test/lit/help/wasm-merge.test @@ -68,9 +68,8 @@ ;; CHECK-NEXT: --experimental-poppy Parse wast files as Poppy IR for testing ;; CHECK-NEXT: purposes. ;; CHECK-NEXT: -;; CHECK-NEXT: --emit-module-names Emit module names, even if not -;; CHECK-NEXT: emitting the rest of the names -;; CHECK-NEXT: section +;; CHECK-NEXT: --emit-module-names Emit module names, even if not emitting +;; CHECK-NEXT: the rest of the names section ;; CHECK-NEXT: ;; CHECK-NEXT: --enable-sign-ext Enable sign extension operations ;; CHECK-NEXT: diff --git a/test/lit/help/wasm-reduce.test b/test/lit/help/wasm-reduce.test index fb2804283db..f881c3d24f3 100644 --- a/test/lit/help/wasm-reduce.test +++ b/test/lit/help/wasm-reduce.test @@ -121,9 +121,8 @@ ;; CHECK-NEXT: --experimental-poppy Parse wast files as Poppy IR for testing ;; CHECK-NEXT: purposes. ;; CHECK-NEXT: -;; CHECK-NEXT: --emit-module-names Emit module names, even if not -;; CHECK-NEXT: emitting the rest of the names -;; CHECK-NEXT: section +;; CHECK-NEXT: --emit-module-names Emit module names, even if not emitting +;; CHECK-NEXT: the rest of the names section ;; CHECK-NEXT: ;; CHECK-NEXT: --enable-sign-ext Enable sign extension operations ;; CHECK-NEXT: diff --git a/test/lit/help/wasm-split.test b/test/lit/help/wasm-split.test index c395b8edc6b..c39cf69e534 100644 --- a/test/lit/help/wasm-split.test +++ b/test/lit/help/wasm-split.test @@ -173,9 +173,8 @@ ;; CHECK-NEXT: --experimental-poppy Parse wast files as Poppy IR for testing ;; CHECK-NEXT: purposes. ;; CHECK-NEXT: -;; CHECK-NEXT: --emit-module-names Emit module names, even if not -;; CHECK-NEXT: emitting the rest of the names -;; CHECK-NEXT: section +;; CHECK-NEXT: --emit-module-names Emit module names, even if not emitting +;; CHECK-NEXT: the rest of the names section ;; CHECK-NEXT: ;; CHECK-NEXT: --enable-sign-ext Enable sign extension operations ;; CHECK-NEXT: From 388213f94f35ebdb4f98ec403936d09f99defb5d Mon Sep 17 00:00:00 2001 From: Martin Kustermann Date: Fri, 19 Jun 2026 15:10:26 +0200 Subject: [PATCH 6/6] more clang format --- src/tools/wasm-split/split-options.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/tools/wasm-split/split-options.h b/src/tools/wasm-split/split-options.h index 1b061868873..25b681a95f1 100644 --- a/src/tools/wasm-split/split-options.h +++ b/src/tools/wasm-split/split-options.h @@ -52,7 +52,6 @@ struct WasmSplitOptions : ToolOptions { bool placeholderMap = false; bool stripDebug = false; - std::string profileFile; std::string profileExport = DEFAULT_PROFILE_EXPORT;