Skip to content

Commit 0502257

Browse files
Blue-B-codeBlue-B-code
committed
refactor(claims): rename RAR terminology to ZIP across app
- rename BuildConfig key RAR_PASSWORD to ZIP_PASSWORD - update password APIs/fields and SharedPreferences key to zip naming - update settings layout ids and localized string resources - keep export behavior on ZIP (zip4j/.zip) while aligning wording
1 parent bb7f6ea commit 0502257

14 files changed

Lines changed: 65 additions & 65 deletions

File tree

‎claimManagement/build.gradle‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ android {
5959
resValue "string", "ReleaseDateValue", getDate()
6060
buildConfigField "String", "API_BASE_URL", '"http://demo.openimis.org/"'
6161
buildConfigField "String", "REST_API_PREFIX", '"rest"'
62-
buildConfigField "String", "RAR_PASSWORD", '")(#$1HsD"'
62+
buildConfigField "String", "ZIP_PASSWORD", '")(#$1HsD"'
6363
buildConfigField "String", "API_VERSION", '"3"'
6464
}
6565

‎claimManagement/custom-flavours.gradle.dist‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ android {
66
buildConfigField "String", "API_BASE_URL", [API_BASE_URL]
77
buildConfigField "String", "APP_DIR", [APP_DIR_NAME]
88
buildConfigField "String", "API_VERSION", [API_VERSION]
9-
buildConfigField "String", "RAR_PASSWORD", [RAR_PASSWORD]
9+
buildConfigField "String", "ZIP_PASSWORD", [ZIP_PASSWORD]
1010
resValue "string", "app_name_claims", [APP_NAME]
1111
}
1212
}

‎claimManagement/src/bepha/res/values/strings.xml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<resources>
33
<string name="settings">Settings</string>
4-
<string name="RarPassword">RAR Password</string>
5-
<string name="DefaultRarPassword">Set the default RAR password</string>
6-
<string name="SaveRarPassword">Save</string>
4+
<string name="ZipPassword">ZIP Password</string>
5+
<string name="DefaultZipPassword">Set the default ZIP password</string>
6+
<string name="SaveZipPassword">Save</string>
77
<string name="InsuranceNumber">Insuree number</string>
88
<string name="ErrorOccurred">Error occurred while processing data</string>
99
<string name="SomethingWrongServer">Something went wrong on the server.</string>

‎claimManagement/src/chf/res/values-sw/strings.xml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<resources>
33
<string name="settings">Mipangilio</string>
4-
<string name="RarPassword">Nenosiri la RAR</string>
5-
<string name="DefaultRarPassword">Weka nambari ya default ya RAR</string>
6-
<string name="SaveRarPassword">Hifadhi</string>
4+
<string name="ZipPassword">Nenosiri la ZIP</string>
5+
<string name="DefaultZipPassword">Weka nambari ya default ya ZIP</string>
6+
<string name="SaveZipPassword">Hifadhi</string>
77
<string name="InsuranceNumber">CHFID</string>
88
<string name="ErrorOccurred">Tatizo limetokea wakati wa kuchakata taarifa.</string>
99
<string name="SomethingWrongServer">Kuna kitu hakijakaa sawa kwenye kompuyta kuu.</string>

‎claimManagement/src/chf/res/values/strings.xml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<resources>
33
<string name="settings">Settings</string>
4-
<string name="RarPassword">RAR Password</string>
5-
<string name="DefaultRarPassword">Set the default RAR password</string>
6-
<string name="SaveRarPassword">Save</string>
4+
<string name="ZipPassword">ZIP Password</string>
5+
<string name="DefaultZipPassword">Set the default ZIP password</string>
6+
<string name="SaveZipPassword">Save</string>
77
<string name="InsuranceNumber">CHF number</string>
88
<string name="ErrorOccurred">Error occurred while processing data</string>
99
<string name="SomethingWrongServer">Something went wrong on the server.</string>

‎claimManagement/src/main/java/org/openimis/imisclaims/AppInformation.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import java.util.Locale;
55

66
import static org.openimis.imisclaims.BuildConfig.API_BASE_URL;
7-
import static org.openimis.imisclaims.BuildConfig.RAR_PASSWORD;
7+
import static org.openimis.imisclaims.BuildConfig.ZIP_PASSWORD;
88
import static org.openimis.imisclaims.BuildConfig.API_VERSION;
99

1010
public final class AppInformation {
@@ -13,8 +13,8 @@ public static String getDomain() {
1313
return API_BASE_URL;
1414
}
1515

16-
public static String getDefaultRarPassword() {
17-
return RAR_PASSWORD;
16+
public static String getDefaultZipPassword() {
17+
return ZIP_PASSWORD;
1818
}
1919

2020
public static String getApiVersion() {

‎claimManagement/src/main/java/org/openimis/imisclaims/Global.java‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525

2626
package org.openimis.imisclaims;
2727

28-
import static org.openimis.imisclaims.BuildConfig.RAR_PASSWORD;
28+
import static org.openimis.imisclaims.BuildConfig.ZIP_PASSWORD;
2929

3030
import android.Manifest;
3131
import android.app.Application;
@@ -72,7 +72,7 @@ public class Global extends Application {
7272
private int UserId;
7373
private String AppDirectory;
7474
private final Map<String, String> SubDirectories = new HashMap<>();
75-
private static final String _DefaultRarPassword = RAR_PASSWORD;
75+
private static final String _DefaultZipPassword = ZIP_PASSWORD;
7676
private Token JWTToken;
7777
private String[] permissions;
7878

@@ -91,8 +91,8 @@ public static Context getContext() {
9191
return instance.getApplicationContext();
9292
}
9393

94-
public String getDefaultRarPassword() {
95-
return _DefaultRarPassword;
94+
public String getDefaultZipPassword() {
95+
return _DefaultZipPassword;
9696
}
9797

9898
public String getOfficerCode() {
@@ -276,26 +276,26 @@ public String getSDCardStatus() {
276276
return Environment.getExternalStorageState();
277277
}
278278

279-
public String getRarPwd() {
279+
public String getZipPwd() {
280280
String password = "";
281281
SharedPreferences sharedPreferences = getDefaultSharedPreferences();
282-
if (!sharedPreferences.contains("rarPwd")) {
283-
password = getDefaultRarPassword();
282+
if (!sharedPreferences.contains("zipPwd")) {
283+
password = getDefaultZipPassword();
284284
} else {
285-
String encryptedRarPassword = sharedPreferences.getString("rarPwd", getDefaultRarPassword());
286-
String trimEncryptedPassword = encryptedRarPassword.trim();
285+
String encryptedZipPassword = sharedPreferences.getString("zipPwd", getDefaultZipPassword());
286+
String trimEncryptedPassword = encryptedZipPassword.trim();
287287
String salt = sharedPreferences.getString("salt", null);
288288
String trimSalt = salt.trim();
289289
try {
290-
password = decryptRarPwd(trimEncryptedPassword, trimSalt);
290+
password = decryptZipPwd(trimEncryptedPassword, trimSalt);
291291
} catch (Exception e) {
292292
e.printStackTrace();
293293
}
294294
}
295295
return password;
296296
}
297297

298-
private String decryptRarPwd(String dataToDecrypt, String decPassword) throws Exception {
298+
private String decryptZipPwd(String dataToDecrypt, String decPassword) throws Exception {
299299
SecretKeySpec key = generateKey(decPassword);
300300
Cipher c = Cipher.getInstance("AES");
301301
c.init(Cipher.DECRYPT_MODE, key);

‎claimManagement/src/main/java/org/openimis/imisclaims/MainActivity.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ public boolean onNavigationItemSelected(MenuItem item) {
258258
// } else if (id == R.id.nav_settings) {
259259
// Intent intent = new Intent(this, SettingsActivity.class);
260260
// startActivity(intent);
261-
// }
261+
}
262262

263263
drawer.closeDrawer(GravityCompat.START);
264264
return true;

‎claimManagement/src/main/java/org/openimis/imisclaims/SettingsActivity.java‎

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616

1717
public class SettingsActivity extends ImisActivity {
1818

19-
Button btnSaveRarPwd, btnDefaultRarPassword;
20-
EditText etRarPassword;
19+
Button btnSaveZipPwd, btnDefaultZipPassword;
20+
EditText etZipPassword;
2121
private String salt, password;
2222
public static String generatedSalt;
2323

@@ -28,27 +28,27 @@ protected void onCreate(Bundle savedInstanceState) {
2828

2929
actionBar.setTitle("Settings");
3030

31-
btnSaveRarPwd = (Button)findViewById(R.id.btnSaveRarPwd);
32-
etRarPassword = (EditText)findViewById(R.id.rarPassword);
33-
btnDefaultRarPassword = (Button) findViewById(R.id.btnDefaultRarPassword);
31+
btnSaveZipPwd = (Button)findViewById(R.id.btnSaveZipPwd);
32+
etZipPassword = (EditText)findViewById(R.id.zipPassword);
33+
btnDefaultZipPassword = (Button) findViewById(R.id.btnDefaultZipPassword);
3434

35-
btnSaveRarPwd.setOnClickListener(view -> {
36-
if(etRarPassword.getText().length() == 0){
37-
ShowDialog("Rar password required");
35+
btnSaveZipPwd.setOnClickListener(view -> {
36+
if(etZipPassword.getText().length() == 0){
37+
ShowDialog("Zip password required");
3838
}
3939
else {
40-
password = etRarPassword.getText().toString();
41-
saveRarPassword(password);
40+
password = etZipPassword.getText().toString();
41+
saveZipPassword(password);
4242
ShowDialog("Password has been changed");
43-
etRarPassword.setText("");
43+
etZipPassword.setText("");
4444
}
4545

4646
});
4747

48-
btnDefaultRarPassword.setOnClickListener(view -> {
49-
password = global.getDefaultRarPassword();
50-
saveRarPassword(password);
51-
ShowDialog("Password has been changed to the default rar password");
48+
btnDefaultZipPassword.setOnClickListener(view -> {
49+
password = global.getDefaultZipPassword();
50+
saveZipPassword(password);
51+
ShowDialog("Password has been changed to the default zip password");
5252
});
5353

5454
}
@@ -66,7 +66,7 @@ private SecretKeySpec generateKey(String encPassword) throws Exception {
6666
return secretKeySpec;
6767
}
6868

69-
public String encryptRarPwd(String dataToEncrypt, String encPassword) throws Exception{
69+
public String encryptZipPwd(String dataToEncrypt, String encPassword) throws Exception{
7070
SecretKeySpec key = generateKey(encPassword);
7171
Cipher c = Cipher.getInstance("AES");
7272
c.init(Cipher.ENCRYPT_MODE, key);
@@ -75,7 +75,7 @@ public String encryptRarPwd(String dataToEncrypt, String encPassword) throws Exc
7575
return encryptedValue;
7676
}
7777

78-
public String decryptRarPwd(String dataToDecrypt, String decPassword) throws Exception {
78+
public String decryptZipPwd(String dataToDecrypt, String decPassword) throws Exception {
7979
SecretKeySpec key = generateKey(decPassword);
8080
Cipher c = Cipher.getInstance("AES");
8181
c.init(Cipher.DECRYPT_MODE, key);
@@ -95,15 +95,15 @@ public String generateSalt(){
9595
return encodedSalt;
9696
}
9797

98-
public void saveRarPassword(String password){
98+
public void saveZipPassword(String password){
9999
try {
100100
SharedPreferences sharedPreferences = global.getDefaultSharedPreferences();
101101
SharedPreferences.Editor editor = sharedPreferences.edit();
102102
salt = generateSalt();
103103
String trimSalt = salt.trim();
104-
String encryptedPassword = encryptRarPwd(password, trimSalt);
104+
String encryptedPassword = encryptZipPwd(password, trimSalt);
105105
String trimEncryptedPassword = encryptedPassword.trim();
106-
editor.putString("rarPwd", trimEncryptedPassword);
106+
editor.putString("zipPwd", trimEncryptedPassword);
107107
editor.putString("salt", trimSalt);
108108
editor.apply();
109109
}

‎claimManagement/src/main/java/org/openimis/imisclaims/SynchronizeService.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -483,7 +483,7 @@ private Uri createClaimExportZip(ArrayList<File> exportedClaims) {
483483
String zipFilename = "Claims" + "_" + global.getOfficerCode() + "_" + d + ".zip";
484484
File zipFile = storageManager.createTempFile("exports/claim/" + zipFilename, true);
485485

486-
String password = global.getRarPwd();
486+
String password = global.getZipPwd();
487487
ZipUtils.zipFiles(exportedClaims, zipFile, password);
488488
FileUtils.deleteFiles(exportedClaims.toArray(new File[0]));
489489

0 commit comments

Comments
 (0)