From 6072d1de3919c1a3ae89ceb7c37eef356ea64d10 Mon Sep 17 00:00:00 2001 From: Jatin Agrawal Date: Thu, 19 Feb 2026 14:47:01 +0530 Subject: [PATCH 1/2] fix for query --- registry/app/store/database/download_stat.go | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/registry/app/store/database/download_stat.go b/registry/app/store/database/download_stat.go index bee72aed84..dca82bff60 100644 --- a/registry/app/store/database/download_stat.go +++ b/registry/app/store/database/download_stat.go @@ -130,9 +130,15 @@ func (d DownloadStatDao) CreateByRegistryIDImageAndArtifactName( db := dbtx.GetAccessor(ctx, d.db) // Execute the query with parameters - _, err = db.ExecContext(ctx, sqlStr, - time.Now().UnixMilli(), time.Now().UnixMilli(), time.Now().UnixMilli(), - user, user, version, regID, image, artifactType) + now := time.Now().UnixMilli() + args := []interface{}{now, now, now, user, user, version, regID, image} + + // Only add artifactType parameter if the WHERE clause includes it + if artifactType != nil && *artifactType != "" { + args = append(args, artifactType) + } + + _, err = db.ExecContext(ctx, sqlStr, args...) if err != nil { return fmt.Errorf("failed to insert download stat: %w", err) } From 9e710db0beea45582605fe57b3b58c06ab6d3ff8 Mon Sep 17 00:00:00 2001 From: Jatin Agrawal Date: Thu, 19 Feb 2026 14:48:40 +0530 Subject: [PATCH 2/2] formatted --- registry/app/store/database/download_stat.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/registry/app/store/database/download_stat.go b/registry/app/store/database/download_stat.go index dca82bff60..8e8eef1089 100644 --- a/registry/app/store/database/download_stat.go +++ b/registry/app/store/database/download_stat.go @@ -132,12 +132,12 @@ func (d DownloadStatDao) CreateByRegistryIDImageAndArtifactName( // Execute the query with parameters now := time.Now().UnixMilli() args := []interface{}{now, now, now, user, user, version, regID, image} - + // Only add artifactType parameter if the WHERE clause includes it if artifactType != nil && *artifactType != "" { args = append(args, artifactType) } - + _, err = db.ExecContext(ctx, sqlStr, args...) if err != nil { return fmt.Errorf("failed to insert download stat: %w", err)