Description
The MAP_REMOVE case in the apply method of DefaultLiveMap.MutableState silently returns when mapOp is missing, unlike the MAP_SET case which logs a warning. This creates inconsistent error handling and makes debugging more difficult.
Current Behavior
In Sources/AblyLiveObjects/Internal/DefaultLiveMap.swift around lines 458-460:
case .known(.mapRemove):
guard let mapOp = operation.mapOp else {
return // Silent return
}Expected Behavior
Add logging before the return to match the MAP_SET case behavior:
case .known(.mapRemove):
guard let mapOp = operation.mapOp else {
logger.log("Could not apply MAP_REMOVE since operation.mapOp is missing", level: .warn)
return
}Context
This inconsistency was identified during code review to ensure uniform error handling and easier debugging.
Backlinks:
┆Issue is synchronized with this Jira Task by Unito
Description
The MAP_REMOVE case in the
applymethod ofDefaultLiveMap.MutableStatesilently returns whenmapOpis missing, unlike the MAP_SET case which logs a warning. This creates inconsistent error handling and makes debugging more difficult.Current Behavior
In
Sources/AblyLiveObjects/Internal/DefaultLiveMap.swiftaround lines 458-460:Expected Behavior
Add logging before the return to match the MAP_SET case behavior:
Context
This inconsistency was identified during code review to ensure uniform error handling and easier debugging.
Backlinks:
OBJECTProtocolMessageoperations #23OBJECTProtocolMessageoperations #23 (comment)┆Issue is synchronized with this Jira Task by Unito