feat(errors): add SysModulesDisabledError typed error class#33
Merged
Conversation
Replaces bare `throw new Error(...)` raises in APCore.on / off / _requireSysModules with a typed SysModulesDisabledError (code SYS_MODULES_DISABLED, DEFAULT_RETRYABLE=false). Callers can now dispatch on `err instanceof SysModulesDisabledError` or `err.code === 'SYS_MODULES_DISABLED'` instead of catching the generic Error base. Cross-language equivalent of Rust's ErrorCode::SysModulesDisabled and the parallel apcore-python#29 SysModulesDisabledError. Exported from both the Node entry (`src/index.ts`) and browser entry (`src/browser/index.ts`). Test plan - pnpm run build → tsc clean - pnpm test --run → 2721 passed / 0 failed / 2 skipped (117 files) Signed-off-by: tercel <tercel.yi@gmail.com>
Signed-off-by: tercel <tercel.yi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces bare
throw new Error(...)raises inAPCore.on/off/_requireSysModuleswith a typedSysModulesDisabledError(codeSYS_MODULES_DISABLED,DEFAULT_RETRYABLE=false).Callers can now dispatch on
err instanceof SysModulesDisabledErrororerr.code === 'SYS_MODULES_DISABLED'instead of catching the genericErrorbase.Cross-language equivalent of Rust's
ErrorCode::SysModulesDisabledand the parallel apcore-python#29. Exported from both Node entry (src/index.ts) and browser entry (src/browser/index.ts).Test plan
pnpm run build(tsc) → cleanpnpm test --run→ 2721 passed / 0 failed / 2 skipped (117 files)DEFAULT_RETRYABLE=false— sys_modules state is config-time, not retry-fixable