From 3c818d3a72b06628172cc4954e0f0e0719442c3e Mon Sep 17 00:00:00 2001 From: Bill Murdock Date: Fri, 8 May 2026 10:46:21 -0400 Subject: [PATCH 1/2] fix: correct default-weights.yaml dead key, add repomix_config, document branch_protection MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Rename separation_concerns → separation_of_concerns to match the assessor's attribute_id (typo caused the yaml key to never match, overweighting all other attributes slightly) - Add repomix_config: 0.02 (Tier 3); absorb by reducing cyclomatic_complexity and structured_logging each from 0.03 to 0.02, keeping Tier 3 total at 14% - Add comment explaining branch_protection is intentionally omitted until GitHub API integration lands (issue #405) Total still sums to exactly 1.0 across 28 attributes. Closes #403 Co-Authored-By: Claude Sonnet 4.6 --- src/agentready/data/default-weights.yaml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/agentready/data/default-weights.yaml b/src/agentready/data/default-weights.yaml index 62d7292c..9385d068 100644 --- a/src/agentready/data/default-weights.yaml +++ b/src/agentready/data/default-weights.yaml @@ -47,18 +47,21 @@ one_command_setup: 0.03 # 8.1 - One-Command Build/Setup concise_documentation: 0.03 # 1.2 - Concise Structured Documentation inline_documentation: 0.03 # 2.2 - Inline Documentation file_size_limits: 0.03 # 1.3 - File Size Limits -separation_concerns: 0.03 # 4.2 - Separation of Concerns +separation_of_concerns: 0.03 # 4.2 - Separation of Concerns pattern_references: 0.03 # 17.1 - Pattern References for Common Changes NEW -# Tier 3 (Important) - 14% total weight +# Tier 3 (Important) - 14% total weight (6 attributes) design_intent: 0.02 # 17.2 - Design Intent Documentation NEW -cyclomatic_complexity: 0.03 # 3.1 - Cyclomatic Complexity Thresholds -structured_logging: 0.03 # 9.2 - Structured Logging +cyclomatic_complexity: 0.02 # 3.1 - Cyclomatic Complexity Thresholds +structured_logging: 0.02 # 9.2 - Structured Logging openapi_specs: 0.03 # 10.1 - OpenAPI/Swagger Specifications architecture_decisions: 0.03 # 2.3 - Architecture Decision Records +repomix_config: 0.02 # AI context generation (Repomix) # Tier 4 (Advanced) - 4% total weight code_smells: 0.01 # 3.4 - Code Smell Elimination issue_pr_templates: 0.01 # 7.3 - Issue & Pull Request Templates container_setup: 0.01 # 8.3 - Container/Virtualization Setup (conditional) progressive_disclosure: 0.01 # 17.3 - Progressive Disclosure (path-scoped rules, skills) NEW +# branch_protection intentionally omitted: always not_applicable until GitHub API +# integration is implemented (see issue #405). Uses default_weight=0.005 as fallback. From 49c3340230d2e42b3fb3cd3c7cef0da7be7314a6 Mon Sep 17 00:00:00 2001 From: Bill Murdock Date: Fri, 8 May 2026 14:47:35 -0400 Subject: [PATCH 2/2] fix: update stale attribute counts in default-weights.yaml header Header comments said 27 attributes and Tier 3 had 5 attributes. Both are stale after adding repomix_config. Now 28 total, 6 in Tier 3. Co-Authored-By: Claude Sonnet 4.6 --- src/agentready/data/default-weights.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/agentready/data/default-weights.yaml b/src/agentready/data/default-weights.yaml index 9385d068..b0506293 100644 --- a/src/agentready/data/default-weights.yaml +++ b/src/agentready/data/default-weights.yaml @@ -1,6 +1,6 @@ # Default Tier-Based Weight Distribution # -# This file defines the default weights for all 27 attributes. +# This file defines the default weights for all 28 attributes. # Weights are based on evidence from ETH Zurich (Feb 2026), Anthropic, # Red Hat best practices (April 2026), and LangChain Terminal-Bench. # @@ -9,7 +9,7 @@ # # Tier 1 (Essential): 55% total (9 attributes) # Tier 2 (Critical): 27% total (3% each, 9 attributes) -# Tier 3 (Important): 14% total (varies, 5 attributes) +# Tier 3 (Important): 14% total (varies, 6 attributes) # Tier 4 (Advanced): 4% total (1% each, 4 attributes) # TOTAL: 100% (sum to 1.0) #