fix replicateRate of batchRead in auto-recover is negative

fanjianye · fanjianye · commit 709bef6cec88 · 2025-08-26T14:51:50.000+08:00
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragmentReplicator.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragmentReplicator.java
@@ -455,8 +455,9 @@ void batchRecoverLedgerFragmentEntry(final long startEntryId,
         int entriesToReplicateCnt = (int) (endEntryId - startEntryId + 1);
         int maxBytesToReplicate = conf.getReplicationRateByBytes();
         if (replicationThrottle != null) {
-            if (maxBytesToReplicate != -1 && maxBytesToReplicate > averageEntrySize.get() * entriesToReplicateCnt) {
-                maxBytesToReplicate = averageEntrySize.get() * entriesToReplicateCnt;
+            long bytesToReplicateCnt = (long) averageEntrySize.get() * entriesToReplicateCnt;
+            if (bytesToReplicateCnt <= Integer.MAX_VALUE && bytesToReplicateCnt >= 0) {
+                maxBytesToReplicate = Math.min(maxBytesToReplicate, (int) bytesToReplicateCnt);
             }
             replicationThrottle.acquire(maxBytesToReplicate);
         }

Original file line number	Diff line number	Diff line change
`@@ -455,8 +455,9 @@ void batchRecoverLedgerFragmentEntry(final long startEntryId,`
`455`	`455`	`int entriesToReplicateCnt = (int) (endEntryId - startEntryId + 1);`
`456`	`456`	`int maxBytesToReplicate = conf.getReplicationRateByBytes();`
`457`	`457`	`if (replicationThrottle != null) {`
`458`		`- if (maxBytesToReplicate != -1 && maxBytesToReplicate > averageEntrySize.get() * entriesToReplicateCnt) {`
`459`		`- maxBytesToReplicate = averageEntrySize.get() * entriesToReplicateCnt;`
	`458`	`+ long bytesToReplicateCnt = (long) averageEntrySize.get() * entriesToReplicateCnt;`
	`459`	`+ if (bytesToReplicateCnt <= Integer.MAX_VALUE && bytesToReplicateCnt >= 0) {`
	`460`	`+ maxBytesToReplicate = Math.min(maxBytesToReplicate, (int) bytesToReplicateCnt);`
`460`	`461`	`}`
`461`	`462`	`replicationThrottle.acquire(maxBytesToReplicate);`
`462`	`463`	`}`