Skip to content

Commit f8f0d7d

Browse files
author
Prathyusha Garre
committed
Revert HFileName pattern
1 parent e753a6c commit f8f0d7d

2 files changed

Lines changed: 14 additions & 8 deletions

File tree

hbase-server/src/main/java/org/apache/hadoop/hbase/io/HFileLink.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -72,13 +72,13 @@ public class HFileLink extends FileLink {
7272
RegionInfoBuilder.ENCODED_REGION_NAME_REGEX, StoreFileInfo.HFILE_NAME_REGEX);
7373

7474
/** Define the HFile Link name parser in the form of: table=region-hfile */
75-
// public static final Pattern LINK_NAME_PATTERN =
76-
// Pattern.compile(String.format("^(?:(%s)(?:\\=))?(%s)=(%s)-(%s)$",
77-
// TableName.VALID_NAMESPACE_REGEX, TableName.VALID_TABLE_QUALIFIER_REGEX,
78-
// RegionInfoBuilder.ENCODED_REGION_NAME_REGEX, StoreFileInfo.HFILE_NAME_REGEX));
79-
public static final Pattern LINK_NAME_PATTERN = Pattern
80-
.compile(String.format("^(?:(%s)(?:\\=))?(%s)=(%s)-(.+)$", TableName.VALID_NAMESPACE_REGEX,
81-
TableName.VALID_TABLE_QUALIFIER_REGEX, RegionInfoBuilder.ENCODED_REGION_NAME_REGEX));
75+
public static final Pattern LINK_NAME_PATTERN =
76+
Pattern.compile(String.format("^(?:(%s)(?:\\=))?(%s)=(%s)-(%s)$",
77+
TableName.VALID_NAMESPACE_REGEX, TableName.VALID_TABLE_QUALIFIER_REGEX,
78+
RegionInfoBuilder.ENCODED_REGION_NAME_REGEX, StoreFileInfo.HFILE_NAME_REGEX));
79+
// public static final Pattern LINK_NAME_PATTERN = Pattern
80+
// .compile(String.format("^(?:(%s)(?:\\=))?(%s)=(%s)-(.+)$", TableName.VALID_NAMESPACE_REGEX,
81+
// TableName.VALID_TABLE_QUALIFIER_REGEX, RegionInfoBuilder.ENCODED_REGION_NAME_REGEX));
8282

8383
/**
8484
* The pattern should be used for hfile and reference links that can be found in

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
import org.apache.hadoop.hbase.io.hfile.ReaderContext;
4040
import org.apache.hadoop.hbase.io.hfile.ReaderContext.ReaderType;
4141
import org.apache.hadoop.hbase.io.hfile.ReaderContextBuilder;
42+
import org.apache.hadoop.hbase.mob.MobConstants;
4243
import org.apache.hadoop.hbase.mob.MobUtils;
4344
import org.apache.hadoop.hbase.regionserver.storefiletracker.StoreFileTracker;
4445
import org.apache.hadoop.hbase.util.FSUtils;
@@ -663,6 +664,11 @@ public static boolean isValid(final FileStatus fileStatus) throws IOException {
663664
if (fileStatus.isDirectory()) {
664665
return false;
665666
}
667+
668+
// Disable validation for MOB files
669+
if(p.toString().contains(MobConstants.MOB_DIR_NAME)) {
670+
return true;
671+
}
666672

667673
// Check for empty hfile. Should never be the case but can happen
668674
// after data loss in hdfs for whatever reason (upgrade, etc.): HBASE-646
@@ -674,7 +680,7 @@ public static boolean isValid(final FileStatus fileStatus) throws IOException {
674680

675681
return validateStoreFileName(p.getName());
676682
}
677-
683+
678684
/**
679685
* helper function to compute HDFS blocks distribution of a given reference file.For reference
680686
* file, we don't compute the exact value. We use some estimate instead given it might be good

0 commit comments

Comments
 (0)