[MSHARED-989] Undeprecate DirectoryScanner and MatchPattern(s)

[jira-importer]

Konrad Windszus opened MSHARED-989 and commented

In MSHARED-898 DirectoryScanner has been deprecated. Instead using the java.nio.file.DirectoryStream is now recommended.
The latter is often no replacement as the parametrization of DirectoryScanner with Ant-style globs for includes/excludes is not supported. Also the DEFAULTEXCLUDES are not part of Java NIO DirectoryStream either.

The same applies to MatchPatterns, which is deprecated and now recommends using java.nio.filejava.nio.file.DirectoryStream.Filter<T>. Please instead provide a Filter for Java NIO for those patterns (regex and ant) and make DirectoryScanner use File NIO internally while keeping API compatibility.

Otherwise every consumer of DirectoryScanner needs to come up with a custom implementation of pattern matching and a lot of glue code.

---

Affects: maven-shared-utils-3.3.4

Issue Links:

• MSHARED-898 deprecate DirectoryScanner

1 votes, 4 watchers

[jira-importer]

Michael Osipov commented

I think DirectoryScanner should be a thin wrapper around NIO2 providing everything NIO2 does not provide out of the box.

[jira-importer]

Konrad Windszus commented

Sounds good to me.

[jira-importer]

Konrad Windszus commented

I think this is mostly already provided in #54. Romain Manni-Bucau Is my understanding correct?

[jira-importer]

Romain Manni-Bucau commented

Konrad Windszus IIRC it was the idea yes

[jira-importer]

Elliotte Rusty Harold commented

Ant-style globs for includes/excludes would be added by DirectoryStream.Filter. There's an argument to be made that what we really want here is an implementation of DirectoryStream.Filter that supports includes and excludes and prrhaps DEFAULTEXCLUDES. Maven specific filtering no longer requires implementing our own error prone, platform-cautious file tree walking. Leave that effort to the projects that specialize in understanding the idiosyncrasies of various file systems.

[jira-importer]

Konrad Windszus commented

There is also FileSystem.getPathMatcher(String) which can digest "glob" patterns. Not sure if 100% compatible with the Ant style globs used in MatchPatterns.