From 6dfcd21547dea4a6640687a8d72eaa1eab7d0e50 Mon Sep 17 00:00:00 2001
From: Harrison Weinstock <hkobew@amazon.com>
Date: Wed, 20 May 2026 18:07:28 +0000
Subject: [PATCH] fix(ci): use npm-shrinkwrap.json for node_modules cache key

hashFiles('package-lock.json') returns empty string since only
npm-shrinkwrap.json is tracked, causing all runs to share a single
stale cache key. This led to lint and typecheck failures when the
stale node_modules had outdated type definitions.
---
 .github/workflows/lint.yml | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index 2c2625843..6b522474c 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -29,7 +29,7 @@ jobs:
         uses: actions/cache/save@v5
         with:
           path: node_modules
-          key: node-modules-${{ hashFiles('package-lock.json') }}
+          key: node-modules-${{ hashFiles('npm-shrinkwrap.json') }}
 
   format:
     needs: setup
@@ -42,7 +42,7 @@ jobs:
       - uses: actions/cache/restore@v5
         with:
           path: node_modules
-          key: node-modules-${{ hashFiles('package-lock.json') }}
+          key: node-modules-${{ hashFiles('npm-shrinkwrap.json') }}
       - run: npm run format:check
 
   lint:
@@ -56,7 +56,7 @@ jobs:
       - uses: actions/cache/restore@v5
         with:
           path: node_modules
-          key: node-modules-${{ hashFiles('package-lock.json') }}
+          key: node-modules-${{ hashFiles('npm-shrinkwrap.json') }}
       - run: npm run lint
 
   security:
@@ -70,7 +70,7 @@ jobs:
       - uses: actions/cache/restore@v5
         with:
           path: node_modules
-          key: node-modules-${{ hashFiles('package-lock.json') }}
+          key: node-modules-${{ hashFiles('npm-shrinkwrap.json') }}
       - run: npm run security:audit
 
   secrets:
@@ -84,7 +84,7 @@ jobs:
       - uses: actions/cache/restore@v5
         with:
           path: node_modules
-          key: node-modules-${{ hashFiles('package-lock.json') }}
+          key: node-modules-${{ hashFiles('npm-shrinkwrap.json') }}
       - run: npm run secrets:check
 
   typecheck:
@@ -98,7 +98,7 @@ jobs:
       - uses: actions/cache/restore@v5
         with:
           path: node_modules
-          key: node-modules-${{ hashFiles('package-lock.json') }}
+          key: node-modules-${{ hashFiles('npm-shrinkwrap.json') }}
       - run: npm run typecheck
 
   schema-check: