Skip to content

Commit eff0472

Browse files
committed
fix: rename wait options model from seconds to wait_seconds
1 parent 09f2eb4 commit eff0472

4 files changed

Lines changed: 24 additions & 2 deletions

File tree

.github/pull_request_template.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
*Issue #, if available:*
2+
3+
*Description of changes:*
4+
5+
## Dependencies
6+
If this PR requires testing against a specific branch of the Python Language SDK (e.g., for unreleased changes), uncomment and specify the branch below. Otherwise, leave commented to use the main branch.
7+
8+
<!-- PYTHON_LANGUAGE_SDK_BRANCH: branch-name -->
9+
10+
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

.github/workflows/ci.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,16 @@ jobs:
3232
- uses: webfactory/ssh-agent@v0.9.1
3333
with:
3434
ssh-private-key: ${{ secrets.SDK_KEY }}
35+
- name: Check for Python Language SDK branch override in PR
36+
if: github.event_name == 'pull_request'
37+
run: |
38+
OVERRIDE=$(echo "${{ github.event.pull_request.body }}" | grep -o 'PYTHON_LANGUAGE_SDK_BRANCH: [^[:space:]]*' | cut -d' ' -f2 || true)
39+
if [ ! -z "$OVERRIDE" ]; then
40+
echo "AWS_DURABLE_SDK_URL=git+ssh://git@github.com/aws/aws-durable-execution-sdk-python.git@$OVERRIDE" >> $GITHUB_ENV
41+
echo "Using Python Language SDK branch override: $OVERRIDE"
42+
else
43+
echo "Using default Python Language SDK (main branch)"
44+
fi
3545
- name: static analysis
3646
run: hatch fmt --check
3747
- name: type checking

src/aws_durable_execution_sdk_python_testing/checkpoint/processors/base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ def _create_wait_details(
127127
else:
128128
scheduled_timestamp = datetime.datetime.now(
129129
tz=datetime.UTC
130-
) + timedelta(seconds=update.wait_options.seconds)
130+
) + timedelta(seconds=update.wait_options.wait_seconds)
131131
return WaitDetails(scheduled_timestamp=scheduled_timestamp)
132132
return None
133133

src/aws_durable_execution_sdk_python_testing/checkpoint/processors/wait.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,9 @@ def process(
3838
"""Process WAIT operation update with scheduler integration for timers."""
3939
match update.action:
4040
case OperationAction.START:
41-
wait_seconds = update.wait_options.seconds if update.wait_options else 0
41+
wait_seconds = (
42+
update.wait_options.wait_seconds if update.wait_options else 0
43+
)
4244
scheduled_timestamp = datetime.now(UTC) + timedelta(
4345
seconds=wait_seconds
4446
)

0 commit comments

Comments
 (0)