From 7f9e0475d7e90e3bae986efbe8bff45392071cfb Mon Sep 17 00:00:00 2001 From: silanhe Date: Tue, 28 Jul 2026 23:39:44 +0000 Subject: [PATCH] feat(otel): drop faas/cloud attrs from invocation span Remove faas.invocation_id, faas.coldstart, cloud.provider, and cloud.platform from ExecutionOtelPlugin's invocation span (owned-provider mode), and delete the now-unused _is_cold_start field that only fed faas.coldstart. InvocationOtelPlugin never set these attributes. --- .../execution_plugin.py | 8 -------- 1 file changed, 8 deletions(-) diff --git a/packages/aws-durable-execution-sdk-python-otel/src/aws_durable_execution_sdk_python_otel/execution_plugin.py b/packages/aws-durable-execution-sdk-python-otel/src/aws_durable_execution_sdk_python_otel/execution_plugin.py index 837fe6b9..46a47109 100644 --- a/packages/aws-durable-execution-sdk-python-otel/src/aws_durable_execution_sdk_python_otel/execution_plugin.py +++ b/packages/aws-durable-execution-sdk-python-otel/src/aws_durable_execution_sdk_python_otel/execution_plugin.py @@ -146,7 +146,6 @@ def __init__(self, config: OtelPluginConfig | None = None) -> None: self._invocation_span: Span | None = None self._operation_spans: dict[str, Span] = {} self._lock = threading.RLock() - self._is_cold_start = True if self._config.enrich_logger: install_log_filter(self) @@ -224,8 +223,6 @@ def on_invocation_start(self, info: InvocationStartInfo) -> None: trace.set_span_in_context(self._workflow_span, self._extracted_context) ) - self._is_cold_start = False - def _start_workflow_span(self, info: InvocationStartInfo) -> None: if not self._execution_arn: logger.warning("No execution ARN; skipping Workflow span creation") @@ -269,12 +266,7 @@ def _start_invocation_span(self, info: InvocationStartInfo) -> None: attributes = { "durable.execution.arn": self._execution_arn, "durable.invocation.first": info.is_first_invocation, - "faas.coldstart": self._is_cold_start, - "cloud.provider": "aws", - "cloud.platform": "aws_lambda", } - if info.request_id: - attributes["faas.invocation_id"] = info.request_id self._invocation_span = self._tracer.start_span( name="invocation", kind=SpanKind.INTERNAL,