golangci-lint 2

Author: blizzy78

.github/workflows/lint.yml

@@ -21,7 +21,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v4
+        uses: golangci/golangci-lint-action@v8
         with:
           version: latest
 

.golangci.yml

@@ -1,31 +1,16 @@
-# https://github.com/golangci/golangci-lint/issues/456#issuecomment-617470264
-issues:
-  exclude-use-default: false
-  exclude:
-    # errcheck: Almost all programs ignore errors on these functions and in most cases it's ok
-    - Error return value of .((os\.)?std(out|err)\..*|.*print(f|ln)?|os\.(Un)?Setenv). is not checked
-    # golint: False positive when tests are defined in package 'test'
-    - func name will be used as test\.Test.* by other packages, and that stutters; consider calling this
-    # gosec: Duplicated errcheck checks
-    - G104
-    # gosec: Too many issues in popular repos
-    - (Expect directory permissions to be 0750 or less|Expect file permissions to be 0600 or less)
-    # gosec: False positive is triggered by 'src, err := ioutil.ReadFile(filename)'
-    - Potential file inclusion via variable
-
+version: "2"
 linters:
   enable:
     - asciicheck
     - bodyclose
+    - copyloopvar
     - cyclop
     - durationcheck
+    - err113
     - errorlint
-    - exportloopref
     - forcetypeassert
     - gocognit
     - gocritic
-    - goerr113
-    - gofmt
     - goprintffuncname
     - gosec
     - nakedret
@@ -39,7 +24,7 @@ linters:
     - revive
     - rowserrcheck
     - sqlclosecheck
-    - stylecheck
+    - staticcheck
     - thelper
     - tparallel
     - unconvert
@@ -49,42 +34,68 @@ linters:
     - wrapcheck
     - wsl
   disable:
-    # broken?
     - errname
-
-linters-settings:
-  gocognit:
-    min-complexity: 15
-  nakedret:
-    max-func-lines: 0
-  nolintlint:
-    allow-unused: false
-    allow-leading-space: false
-    require-explanation: true
-    require-specific: true
-  unused:
-    go: '1.24'
-  varnamelen:
-    check-return: true
-    ignore-type-assert-ok: true
-    ignore-map-index-ok: true
-    ignore-chan-recv-ok: true
-    ignore-decls:
-      - is *is.I
-      - t testing.T
-  wrapcheck:
-    ignoreSigs:
-      - .Errorf(
-      - errors.New(
-      - errors.Unwrap(
-      - .Wrap(
-      - .Wrapf(
-      - .WithMessage(
-      - .WithMessagef(
-      - .WithStack(
-      - .Err()
-    ignorePackageGlobs:
-      - github.com/blizzy78/consistent*
-      - golang.org/x/sync/errgroup*
-      - github.com/hashicorp/go-multierror*
-      - github.com/magefile/mage*
+  settings:
+    gocognit:
+      min-complexity: 15
+    nakedret:
+      max-func-lines: 0
+    nolintlint:
+      require-explanation: true
+      require-specific: true
+      allow-unused: false
+    varnamelen:
+      check-return: true
+      ignore-type-assert-ok: true
+      ignore-map-index-ok: true
+      ignore-chan-recv-ok: true
+      ignore-decls:
+        - is *is.I
+        - t testing.T
+    wrapcheck:
+      ignore-sigs:
+        - .Errorf(
+        - errors.New(
+        - errors.Unwrap(
+        - .Wrap(
+        - .Wrapf(
+        - .WithMessage(
+        - .WithMessagef(
+        - .WithStack(
+        - .Err()
+      ignore-package-globs:
+        - github.com/blizzy78/consistent*
+        - golang.org/x/sync/errgroup*
+        - github.com/hashicorp/go-multierror*
+        - github.com/magefile/mage*
+  exclusions:
+    generated: lax
+    rules:
+      # errcheck: Almost all programs ignore errors on these functions and in most cases it's ok
+      - path: (.+)\.go$
+        text: Error return value of .((os\.)?std(out|err)\..*|.*print(f|ln)?|os\.(Un)?Setenv). is not checked
+      # golint: False positive when tests are defined in package 'test'
+      - path: (.+)\.go$
+        text: func name will be used as test\.Test.* by other packages, and that stutters; consider calling this
+      # gosec: Duplicated errcheck checks
+      - path: (.+)\.go$
+        text: G104
+      # gosec: Too many issues in popular repos
+      - path: (.+)\.go$
+        text: (Expect directory permissions to be 0750 or less|Expect file permissions to be 0600 or less)
+      # gosec: False positive is triggered by 'src, err := ioutil.ReadFile(filename)'
+      - path: (.+)\.go$
+        text: Potential file inclusion via variable
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gofmt
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$