Skip to content

Commit c1ed31e

Browse files
authored
Release ModCDP 0.0.13 (#1)
* Update Go module path to browserbase * Export Go CDP event alias * Fix npm declaration exports * Lazy load client runtime components * Resolve extension service worker from manifest * Refresh packaged extension assets * Bump python package to 0.0.7 * Bump ModCDP packages to 0.0.8 * Keep injected server middleware self contained * Bump ModCDP server install version * Relax ModCDP server readiness version check * Serialize custom command results * Release ModCDP 0.0.13 * Fix proxy custom command result unwrapping
1 parent 7fe744c commit c1ed31e

51 files changed

Lines changed: 296 additions & 186 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

go/examples/demo/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import (
2525
"sync"
2626
"time"
2727

28-
modcdp "github.com/pirate/ModCDP/go/modcdp"
28+
modcdp "github.com/browserbase/modcdp/go/modcdp"
2929
"golang.org/x/term"
3030
)
3131

go/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
module github.com/pirate/ModCDP/go
1+
module github.com/browserbase/modcdp/go
22

33
go 1.25.0
44

go/modcdp/client/ModCDPClient.go

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -31,19 +31,19 @@ import (
3131
"time"
3232

3333
abxjsonschema "github.com/ArchiveBox/abxbus/abxbus-go/jsonschema"
34-
"github.com/pirate/ModCDP/go/modcdp/injector"
35-
"github.com/pirate/ModCDP/go/modcdp/launcher"
36-
"github.com/pirate/ModCDP/go/modcdp/router"
37-
"github.com/pirate/ModCDP/go/modcdp/translate"
38-
transportpkg "github.com/pirate/ModCDP/go/modcdp/transport"
39-
"github.com/pirate/ModCDP/go/modcdp/types"
34+
"github.com/browserbase/modcdp/go/modcdp/injector"
35+
"github.com/browserbase/modcdp/go/modcdp/launcher"
36+
"github.com/browserbase/modcdp/go/modcdp/router"
37+
"github.com/browserbase/modcdp/go/modcdp/translate"
38+
transportpkg "github.com/browserbase/modcdp/go/modcdp/transport"
39+
"github.com/browserbase/modcdp/go/modcdp/types"
4040
)
4141

4242
var (
4343
extIDFromURL = regexp.MustCompile(`^chrome-extension://([a-z]+)/`)
4444
)
4545

46-
const modcdpReadyExpression = `Boolean(globalThis.ModCDP?.__ModCDPServerVersion === 1 && globalThis.ModCDP?.handleCommand && globalThis.ModCDP?.addCustomEvent)`
46+
const modcdpReadyExpression = `Boolean(globalThis.ModCDP?.__ModCDPServerVersion >= 1 && globalThis.ModCDP?.handleCommand && globalThis.ModCDP?.addCustomEvent)`
4747

4848
const DefaultCDPSendTimeoutMS = 10_000
4949
const DefaultEventWaitTimeoutMS = 10_000
@@ -1385,14 +1385,14 @@ func handlerPointer(handler Handler) uintptr {
13851385
}
13861386

13871387
func (c *ModCDPClient) Close() {
1388-
if c.transport != nil {
1389-
_ = c.transport.Close()
1390-
c.transport = nil
1391-
}
13921388
if c.launchedBrowser != nil {
13931389
c.launchedBrowser.Close()
13941390
c.launchedBrowser = nil
13951391
}
1392+
if c.transport != nil {
1393+
_ = c.transport.Close()
1394+
c.transport = nil
1395+
}
13961396
for _, injector := range c.extensionInjectors {
13971397
_ = injector.Close()
13981398
}

go/modcdp/injector/BBBrowserExtensionInjector_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ package injector_test
22

33
import (
44
"fmt"
5-
modcdp "github.com/pirate/ModCDP/go/modcdp/client"
5+
modcdp "github.com/browserbase/modcdp/go/modcdp/client"
66
"os"
77
"path/filepath"
88
"regexp"

go/modcdp/injector/BorrowedExtensionInjector.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ const __name = (fn) => fn;
153153
%s
154154
const ModCDP = installModCDPServer(globalThis);
155155
return {
156-
ok: Boolean(ModCDP?.__ModCDPServerVersion === 1 && ModCDP?.handleCommand && ModCDP?.addCustomEvent),
156+
ok: Boolean(ModCDP?.__ModCDPServerVersion >= 1 && ModCDP?.handleCommand && ModCDP?.addCustomEvent),
157157
extension_id: globalThis.chrome?.runtime?.id ?? null,
158158
has_tabs: Boolean(globalThis.chrome?.tabs?.query),
159159
has_debugger: Boolean(globalThis.chrome?.debugger?.sendCommand && globalThis.chrome?.debugger?.getTargets),

go/modcdp/injector/BorrowedExtensionInjector_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package injector_test
22

33
import (
4-
modcdp "github.com/pirate/ModCDP/go/modcdp/client"
5-
. "github.com/pirate/ModCDP/go/modcdp/injector"
4+
modcdp "github.com/browserbase/modcdp/go/modcdp/client"
5+
. "github.com/browserbase/modcdp/go/modcdp/injector"
66
"path/filepath"
77
"testing"
88
)

go/modcdp/injector/DiscoveredExtensionInjector_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ package injector_test
22

33
import (
44
"encoding/json"
5-
modcdp "github.com/pirate/ModCDP/go/modcdp/client"
6-
. "github.com/pirate/ModCDP/go/modcdp/injector"
5+
modcdp "github.com/browserbase/modcdp/go/modcdp/client"
6+
. "github.com/browserbase/modcdp/go/modcdp/injector"
77
"os"
88
"path/filepath"
99
"testing"

go/modcdp/injector/ExtensionInjector.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import (
66
"strings"
77
"time"
88

9-
"github.com/pirate/ModCDP/go/modcdp/types"
9+
"github.com/browserbase/modcdp/go/modcdp/types"
1010
)
1111

1212
const DefaultModCDPExtensionID = "mdedooklbnfejodmnhmkdpkaedafkehf"
@@ -21,7 +21,7 @@ const DefaultTargetSessionPollIntervalMS = 20
2121
var DefaultModCDPServiceWorkerURLSuffixes = []string{"/modcdp/service_worker.js"}
2222
var extIDFromURL = regexp.MustCompile(`^chrome-extension://([a-z]+)/`)
2323

24-
const modcdpReadyExpression = `Boolean(globalThis.ModCDP?.__ModCDPServerVersion === 1 && globalThis.ModCDP?.handleCommand && globalThis.ModCDP?.addCustomEvent)`
24+
const modcdpReadyExpression = `Boolean(globalThis.ModCDP?.__ModCDPServerVersion >= 1 && globalThis.ModCDP?.handleCommand && globalThis.ModCDP?.addCustomEvent)`
2525

2626
type SendCDP = types.SendCDP
2727
type SessionIDForTarget = types.SessionIDForTarget

go/modcdp/injector/ExtensionInjector_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ import (
44
"context"
55
"encoding/json"
66
"fmt"
7-
modcdp "github.com/pirate/ModCDP/go/modcdp/client"
8-
. "github.com/pirate/ModCDP/go/modcdp/injector"
7+
modcdp "github.com/browserbase/modcdp/go/modcdp/client"
8+
. "github.com/browserbase/modcdp/go/modcdp/injector"
99
"path/filepath"
1010
"strings"
1111
"testing"
@@ -256,7 +256,7 @@ func TestExtensionInjectorKeepsModCDPServiceWorkerAliveThroughOffscreenKeepalive
256256
t.Fatal(err)
257257
}
258258
versionResult, _ := version["result"].(map[string]any)
259-
if versionResult["value"] != float64(1) {
259+
if versionResult["value"] != float64(2) {
260260
t.Fatalf("ModCDP server version = %#v", versionResult["value"])
261261
}
262262
}

go/modcdp/injector/ExtensionsLoadUnpackedInjector_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ import (
44
"context"
55
"encoding/json"
66
"fmt"
7-
modcdp "github.com/pirate/ModCDP/go/modcdp/client"
8-
. "github.com/pirate/ModCDP/go/modcdp/injector"
7+
modcdp "github.com/browserbase/modcdp/go/modcdp/client"
8+
. "github.com/browserbase/modcdp/go/modcdp/injector"
99
"path/filepath"
1010
"strings"
1111
"testing"

0 commit comments

Comments
 (0)