LOC-6740: move tests to phpunit 9.6 so CI can actually install and run them

The CI job added in the previous commit went red at dependency install:
Composer 2.10 refuses to install phpunit 4.8.* because every 4.8.x release
carries published security advisories (PKSA-z3gr-8qht-p93v,
PKSA-w57n-mhp6-c9sd). Suppressing advisories via policy.advisories.ignore-id
is not an acceptable trade on a security fix, so the test dependency moves
forward instead.

The `php -l` step DID pass on that run — all five lib/ and tests/ files,
including the 145 new lines in LocalBinary.php.

- composer.json: phpunit 4.8.* -> ^9.6. require-dev only; the library's own
  runtime floor stays php >= 5.3.19 and is unaffected.
- tests/: PHPUnit_Framework_TestCase -> PHPUnit\Framework\TestCase,
  setUp/tearDown given the `: void` signature phpunit 9 requires, and
  assertContains() on strings -> assertStringContainsString() (removed in 9).
- tests/LocalTest.php: tagged test_isRunning, test_checkPid and
  test_multiple_binary `@group network`. All three call Local::start(), which
  downloads and runs the real binary and needs BROWSERSTACK_ACCESS_KEY, so
  they can never pass on a credential-less runner. --exclude-group network
  now excludes them, which is what makes the CI job meaningfully green
  rather than green-because-skipped.
- phpunit.xml: phpunit 9 schema, bootstrap=vendor/autoload.php, and a
  Test.php suffix on the directory so tests/manual/ is not scanned.
- workflow: install git + unzip before Composer. Neither is in the official
  php image and ext-zip is not built in, so Composer has no way to unpack
  packages without one of them.

Refs LOC-6740

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: 07souravkunda

.github/workflows/php.yml

@@ -13,8 +13,9 @@ jobs:
   test:
     name: lint + phpunit
     runs-on: ubuntu-latest
-    # phpunit 4.x (pinned in composer.json, and the API both test files use) does
-    # not run on PHP 8. 7.4 is the newest runtime it supports.
+    # 7.4 rather than 8.x: lib/ sets properties dynamically, which PHP 8.2
+    # deprecates, and the library's own floor is php >= 5.3.19. phpunit 9.6
+    # supports 7.3+.
     container: php:7.4-cli
     steps:
       - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
@@ -29,8 +30,11 @@ jobs:
           php -l tests/LocalTest.php
           php -l tests/LocalBinaryTest.php
 
+      # git + unzip are not in the official php image, and Composer needs one of
+      # them to unpack downloaded packages (ext-zip is not built in either).
       - name: Install dependencies
         run: |
+          apt-get update -qq && apt-get install -y -qq --no-install-recommends git unzip >/dev/null
           curl -sS https://getcomposer.org/installer | php
           php composer.phar install --no-interaction --no-progress
 

composer.json

@@ -13,7 +13,7 @@
     "php": ">=5.3.19"
   },
   "require-dev": {
-    "phpunit/phpunit": "4.8.*"
+    "phpunit/phpunit": "^9.6"
   },
   "suggest": {
     "phpdocumentor/phpdocumentor": "2.*"

phpunit.xml

@@ -1,8 +1,11 @@
-<phpunit>
+<?xml version="1.0" encoding="UTF-8"?>
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.6/phpunit.xsd"
+         bootstrap="vendor/autoload.php"
+         colors="true">
   <testsuites>
     <testsuite name="local">
-      <directory>tests</directory>
+      <directory suffix="Test.php">tests</directory>
     </testsuite>
   </testsuites>
 </phpunit>
-

tests/LocalBinaryTest.php

@@ -29,18 +29,18 @@ public function call_verify_binary($path) {
   }
 }
 
-class LocalBinaryTest extends \PHPUnit_Framework_TestCase {
+class LocalBinaryTest extends \PHPUnit\Framework\TestCase {
 
   private $binary;
   private $dir;
 
-  public function setUp() {
+  protected function setUp(): void {
     $this->binary = new TestableLocalBinary();
     $this->dir = sys_get_temp_dir() . '/bs-local-binary-test-' . getmypid() . '-' . mt_rand();
     mkdir($this->dir, 0777, true);
   }
 
-  public function tearDown() {
+  protected function tearDown(): void {
     foreach (glob($this->dir . '/*') as $file) {
       unlink($file);
     }
@@ -72,7 +72,7 @@ public function test_download_rejects_untrusted_certificate() {
     $this->assertNotNull($raised, 'download_binary must reject an untrusted certificate');
     // cURL error 60 is CURLE_PEER_FAILED_VERIFICATION — pins the failure to
     // certificate validation rather than any later check.
-    $this->assertContains('cURL error 60', $raised->getMessage());
+    $this->assertStringContainsString('cURL error 60', $raised->getMessage());
     $this->assertFalse(file_exists($this->dest_path()), 'no file may be left behind on failure');
   }
 

tests/LocalTest.php

@@ -8,27 +8,27 @@
 
 require_once __DIR__ . '/../vendor/autoload.php';
 
-class LocalTest extends \PHPUnit_Framework_TestCase {
+class LocalTest extends \PHPUnit\Framework\TestCase {
 
   private $bs_local;
 
-  public function setUp(){
+  protected function setUp(): void {
     $this->bs_local = new Local();
   }
 
-  public function tearDown(){
+  protected function tearDown(): void {
     $this->bs_local->stop();
   }
 
   public function test_verbose() {
     $this->bs_local->add_args('v');
-    $this->assertContains('-v',$this->bs_local->start_command());
+    $this->assertStringContainsString('-v',$this->bs_local->start_command());
   }
 
   public function test_set_folder() {
     $this->bs_local->add_args('f', "/");
-    $this->assertContains('-f',$this->bs_local->start_command());
-    $this->assertContains('/',$this->bs_local->start_command());
+    $this->assertStringContainsString('-f',$this->bs_local->start_command());
+    $this->assertStringContainsString('/',$this->bs_local->start_command());
   }
 
   public function test_enable_force() {
@@ -37,56 +37,61 @@ public function test_enable_force() {
 
   public function test_set_local_identifier() {
     $this->bs_local->add_args("localIdentifier", "randomString");
-    $this->assertContains('-localIdentifier randomString',$this->bs_local->start_command());
+    $this->assertStringContainsString('-localIdentifier randomString',$this->bs_local->start_command());
   }
 
   public function test_enable_only() {
     $this->bs_local->add_args("only");
-    $this->assertContains('-only',$this->bs_local->start_command());
+    $this->assertStringContainsString('-only',$this->bs_local->start_command());
   }
 
   public function test_enable_only_automate() {
     $this->bs_local->add_args("onlyAutomate");
-    $this->assertContains('-onlyAutomate', $this->bs_local->start_command()); 
+    $this->assertStringContainsString('-onlyAutomate', $this->bs_local->start_command()); 
   }
 
   public function test_enable_force_local() {
     $this->bs_local->add_args("forcelocal");
-    $this->assertContains('-forcelocal',$this->bs_local->start_command());
+    $this->assertStringContainsString('-forcelocal',$this->bs_local->start_command());
   }
 
   public function test_custom_boolean_argument() {
     $this->bs_local->add_args("boolArg1", true);
     $this->bs_local->add_args("boolArg2", true);
-    $this->assertContains('-boolArg1',$this->bs_local->start_command());
-    $this->assertContains('-boolArg2',$this->bs_local->start_command());
+    $this->assertStringContainsString('-boolArg1',$this->bs_local->start_command());
+    $this->assertStringContainsString('-boolArg2',$this->bs_local->start_command());
   }
 
   public function test_custom_keyval() {
     $this->bs_local->add_args("customKey1", "custom value1");
     $this->bs_local->add_args("customKey2", "custom value2");
-    $this->assertContains('-customKey1 \'custom value1\'',$this->bs_local->start_command());
-    $this->assertContains('-customKey2 \'custom value2\'',$this->bs_local->start_command());
+    $this->assertStringContainsString('-customKey1 \'custom value1\'',$this->bs_local->start_command());
+    $this->assertStringContainsString('-customKey2 \'custom value2\'',$this->bs_local->start_command());
   }
 
   public function test_set_proxy() {
     $this->bs_local->add_args("proxyHost", "localhost");
     $this->bs_local->add_args("proxyPort", 8080);
     $this->bs_local->add_args("proxyUser", "user");
     $this->bs_local->add_args("proxyPass", "pass");
-    $this->assertContains('-proxyHost localhost -proxyPort 8080 -proxyUser user -proxyPass pass',$this->bs_local->start_command());
+    $this->assertStringContainsString('-proxyHost localhost -proxyPort 8080 -proxyUser user -proxyPass pass',$this->bs_local->start_command());
   }
 
   public function test_enable_force_proxy() {
     $this->bs_local->add_args("-forceproxy");
-    $this->assertContains('-forceproxy',$this->bs_local->start_command());
+    $this->assertStringContainsString('-forceproxy',$this->bs_local->start_command());
   }
 
   public function test_hosts() {
     $this->bs_local->add_args("-hosts", "localhost,8080,0");
-    $this->assertContains('localhost,8080,0',$this->bs_local->start_command());
+    $this->assertStringContainsString('localhost,8080,0',$this->bs_local->start_command());
   }
 
+  /**
+   * Starts the real binary — needs BROWSERSTACK_ACCESS_KEY and outbound network.
+   *
+   * @group network
+   */
   public function test_isRunning() {
     $this->assertFalse($this->bs_local->isRunning());
     $this->bs_local->start(array('v' => true));
@@ -97,12 +102,22 @@ public function test_isRunning() {
     $this->assertTrue($this->bs_local->isRunning());
   }
 
+  /**
+   * Starts the real binary — needs BROWSERSTACK_ACCESS_KEY and outbound network.
+   *
+   * @group network
+   */
   public function test_checkPid() {
     $this->assertFalse($this->bs_local->isRunning());
     $this->bs_local->start(array('v' => true));
     $this->assertTrue($this->bs_local->pid > 0);
   }
 
+  /**
+   * Starts the real binary twice — needs BROWSERSTACK_ACCESS_KEY and outbound network.
+   *
+   * @group network
+   */
   public function test_multiple_binary() {
     $this->bs_local->start(array('v' => true));
     $bs_local_2 = new Local();