Skip to content

zeph-tools: span naming inconsistency within crate (tool.X vs tools.X vs scrape.dns.X) #4714

@bug-ops

Description

@bug-ops

Description

crates/zeph-tools/src/ uses three different span name prefixes for the same crate, making trace analysis and filtering harder:

Span name Location Pattern used
tool.web_scrape scrape.rs:329 tool.
tools.scrape.apply_ipi_filter scrape.rs:1011 tools.scrape.
scrape.dns.resolve scrape.rs:1141 scrape.
tool.shell shell/mod.rs:624 tool.
tools.shell.resolve_context shell/mod.rs:1232 tools.
tools.risk_chain.check risk_chain.rs:126 tools.

Per CLAUDE.md convention, span names should be <crate_short>.<subsystem>.<operation>. For zeph-tools the canonical prefix should be tools. (short for zeph-tools). All spans should be normalized to tools.<subsystem>.<operation> (e.g. tools.scrape.fetch, tools.shell.execute, tools.dns.resolve).

The inconsistency was present before PR #4710 and not introduced by it, but the two new spans added in #4710 (tools.scrape.apply_ipi_filter, scrape.dns.resolve) add to the inconsistency rather than resolving it.

Expected Behavior

All span names in zeph-tools follow tools.<subsystem>.<operation>.

Actual Behavior

Mix of tool., tools., and bare scrape. prefixes.

Environment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Research — medium-high complexitystyleCode style/formatting changes

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions