cvm/overlay: Fix gc/arguments related tests#137
Merged
duanyangjing merged 2 commits intoMay 20, 2026
Merged
Conversation
98d5c9a to
3c85759
Compare
3c85759 to
83c6294
Compare
Baseline files for original jdk8 gc/arguments tests
83c6294 to
2c0b9e8
Compare
Collaborator
|
Better to write commit messages in English (this rule can be added to your AGENT.md) |
2c0b9e8 to
1f67fec
Compare
Collaborator
Author
Updated |
Adapt gc/arguments tests for the JDK 17 kernel differences in flag printing format, ergonomics derivation logic, and option deprecation/inheritance: 1. TestAggressiveHeap.java: Relax regex to accept both `=` and `:=` for PrintFlagsFinal output, matching the JDK 17 format change for command-line-originating values. 2. TestG1ConcRefinementThreads.java: Handle JDK 17 preserving explicit G1ConcRefinementThreads=0 instead of replacing it with the ergonomic ParallelGCThreads value. 3. TestG1HeapRegionSize.java: Lower the tested G1HeapRegionSize cap from 64m to 32m to avoid JVM initialization failure on the JDK 17 kernel. 4. TestHeapFreeRatio.java: Use generalized regex to match the changed illegal HeapFreeRatio error message format in JDK 17. 5. TestInitialTenuringThreshold.java: Accept MaxTenuringThreshold=16 combined with InitialTenuringThreshold=8 as a valid startup configuration on JDK 17. 6. TestUnrecognizedVMOptionsHandling.java: Adapt expectations for CompoundVM legacy option alias compatibility (PrintGc, MaxiumHeapSize); these no longer fail with "Did you mean..." suggestions. 7. TestUseCompressedOopsErgoTools.java: Use regex to extract the heap size value from stdout, avoiding NumberFormatException caused by JDK 17 WhiteBox registration warnings polluting the output.
1f67fec to
76e554e
Compare
superajun-wsj
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.